[INFO] updating cached repository reirep/fractal_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/reirep/fractal_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/reirep/fractal_rust" "work/ex/clippy-test-run/sources/stable/gh/reirep/fractal_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/reirep/fractal_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/reirep/fractal_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reirep/fractal_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reirep/fractal_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 72e6dd83c7464c0666d5ddcba9a96d8ae5063620 [INFO] sha for GitHub repo reirep/fractal_rust: 72e6dd83c7464c0666d5ddcba9a96d8ae5063620 [INFO] validating manifest of reirep/fractal_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reirep/fractal_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reirep/fractal_rust [INFO] finished frobbing reirep/fractal_rust [INFO] frobbed toml for reirep/fractal_rust written to work/ex/clippy-test-run/sources/stable/gh/reirep/fractal_rust/Cargo.toml [INFO] started frobbing reirep/fractal_rust [INFO] finished frobbing reirep/fractal_rust [INFO] frobbed toml for reirep/fractal_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reirep/fractal_rust/Cargo.toml [INFO] crate reirep/fractal_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reirep/fractal_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/reirep/fractal_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d2f57ceb2a005ccb8cda63a4356b5a3e0b05a5cdad4f42f38cb0531ae9a7b29 [INFO] running `"docker" "start" "-a" "6d2f57ceb2a005ccb8cda63a4356b5a3e0b05a5cdad4f42f38cb0531ae9a7b29"` [INFO] [stderr] Checking smallvec v0.6.1 [INFO] [stderr] Checking owning_ref v0.2.4 [INFO] [stderr] Checking smallvec v0.3.3 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking bmp v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking multiqueue v0.3.2 [INFO] [stderr] Checking fractal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:46:26 [INFO] [stderr] | [INFO] [stderr] 46 | agreg += pix.r as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | agreg += pix.g as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | agreg += pix.b as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | agreg as f64 / (3.0 * self.width as f64 * self.height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:51:51 [INFO] [stderr] | [INFO] [stderr] 51 | agreg as f64 / (3.0 * self.width as f64 * self.height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:184:8 [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.chars().next().unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `line.starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:184:47 [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.chars().next().unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] help: like this [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.starts_with(' [INFO] [stderr] 185 | ') { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:187:28 [INFO] [stderr] | [INFO] [stderr] 187 | let param = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / loop { [INFO] [stderr] 201 | | match input.recv() { [INFO] [stderr] 202 | | Ok(mut val) => { [INFO] [stderr] 203 | | val.set_all_pixels(); [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(mut val) = input.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:46:26 [INFO] [stderr] | [INFO] [stderr] 46 | agreg += pix.r as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | agreg += pix.g as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | agreg += pix.b as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(pix.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | agreg as f64 / (3.0 * self.width as f64 * self.height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fractal.rs:51:51 [INFO] [stderr] | [INFO] [stderr] 51 | agreg as f64 / (3.0 * self.width as f64 * self.height as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / loop { [INFO] [stderr] 225 | | match input.recv() { [INFO] [stderr] 226 | | Ok(val) => { [INFO] [stderr] 227 | | if let None = bigger {//saving the bigger one to save it at the end [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(val) = input.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | if let None = bigger {//saving the bigger one to save it at the end [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 228 | | bigger = Some(val.clone()); [INFO] [stderr] 229 | | avg = val.get_avg_pixel(); [INFO] [stderr] 230 | | } [INFO] [stderr] ... | [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________________- help: try this: `if bigger.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:184:8 [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.chars().next().unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `line.starts_with('#')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/main.rs:184:47 [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.chars().next().unwrap() == '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] help: like this [INFO] [stderr] | [INFO] [stderr] 184 | if line.chars().next().unwrap() == '#' || line.starts_with(' [INFO] [stderr] 185 | ') { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:187:28 [INFO] [stderr] | [INFO] [stderr] 187 | let param = line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / loop { [INFO] [stderr] 201 | | match input.recv() { [INFO] [stderr] 202 | | Ok(mut val) => { [INFO] [stderr] 203 | | val.set_all_pixels(); [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(mut val) = input.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / loop { [INFO] [stderr] 225 | | match input.recv() { [INFO] [stderr] 226 | | Ok(val) => { [INFO] [stderr] 227 | | if let None = bigger {//saving the bigger one to save it at the end [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(val) = input.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | if let None = bigger {//saving the bigger one to save it at the end [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 228 | | bigger = Some(val.clone()); [INFO] [stderr] 229 | | avg = val.get_avg_pixel(); [INFO] [stderr] 230 | | } [INFO] [stderr] ... | [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________________- help: try this: `if bigger.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.65s [INFO] running `"docker" "inspect" "6d2f57ceb2a005ccb8cda63a4356b5a3e0b05a5cdad4f42f38cb0531ae9a7b29"` [INFO] running `"docker" "rm" "-f" "6d2f57ceb2a005ccb8cda63a4356b5a3e0b05a5cdad4f42f38cb0531ae9a7b29"` [INFO] [stdout] 6d2f57ceb2a005ccb8cda63a4356b5a3e0b05a5cdad4f42f38cb0531ae9a7b29