[INFO] updating cached repository rehan-jaffer/conway-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rehan-jaffer/conway-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rehan-jaffer/conway-rust" "work/ex/clippy-test-run/sources/stable/gh/rehan-jaffer/conway-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rehan-jaffer/conway-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rehan-jaffer/conway-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rehan-jaffer/conway-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rehan-jaffer/conway-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b4fd578dc9b152712c17fe3e6f1eab44cd643119
[INFO] sha for GitHub repo rehan-jaffer/conway-rust: b4fd578dc9b152712c17fe3e6f1eab44cd643119
[INFO] validating manifest of rehan-jaffer/conway-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rehan-jaffer/conway-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rehan-jaffer/conway-rust
[INFO] finished frobbing rehan-jaffer/conway-rust
[INFO] frobbed toml for rehan-jaffer/conway-rust written to work/ex/clippy-test-run/sources/stable/gh/rehan-jaffer/conway-rust/Cargo.toml
[INFO] started frobbing rehan-jaffer/conway-rust
[INFO] finished frobbing rehan-jaffer/conway-rust
[INFO] frobbed toml for rehan-jaffer/conway-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rehan-jaffer/conway-rust/Cargo.toml
[INFO] crate rehan-jaffer/conway-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rehan-jaffer/conway-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rehan-jaffer/conway-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 431563b510f8aa5cf47561ba0f37153f2f2ca2b808fd9e96ed213e197532bacf
[INFO] running `"docker" "start" "-a" "431563b510f8aa5cf47561ba0f37153f2f2ca2b808fd9e96ed213e197532bacf"`
[INFO] [stderr] warning: dependency (rand) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions
[INFO] [stderr]     Checking conway v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return (((y1 * GRID_WIDTH) + x1) % GRID_SIZE) as usize;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((y1 * GRID_WIDTH) + x1) % GRID_SIZE) as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return grid;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `grid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return next_state;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next_state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:62:20
[INFO] [stderr]    |
[INFO] [stderr] 62 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 63 | |                 if (score == 3) {
[INFO] [stderr] 64 | |                     next_state.push(1);
[INFO] [stderr] 65 | |                 } else {
[INFO] [stderr] 66 | |                     next_state.push(0);
[INFO] [stderr] 67 | |                 }
[INFO] [stderr] 68 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 62 |             } else if (score == 3) {
[INFO] [stderr] 63 |     next_state.push(1);
[INFO] [stderr] 64 | } else {
[INFO] [stderr] 65 |     next_state.push(0);
[INFO] [stderr] 66 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:57:20
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 if (score > 3 || score < 2) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |                 if (score == 3) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return (((y1 * GRID_WIDTH) + x1) % GRID_SIZE) as usize;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((y1 * GRID_WIDTH) + x1) % GRID_SIZE) as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return grid;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `grid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return next_state;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next_state`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:62:20
[INFO] [stderr]    |
[INFO] [stderr] 62 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 63 | |                 if (score == 3) {
[INFO] [stderr] 64 | |                     next_state.push(1);
[INFO] [stderr] 65 | |                 } else {
[INFO] [stderr] 66 | |                     next_state.push(0);
[INFO] [stderr] 67 | |                 }
[INFO] [stderr] 68 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 62 |             } else if (score == 3) {
[INFO] [stderr] 63 |     next_state.push(1);
[INFO] [stderr] 64 | } else {
[INFO] [stderr] 65 |     next_state.push(0);
[INFO] [stderr] 66 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:57:20
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 if (score > 3 || score < 2) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |                 if (score == 3) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `x1` is never read
[INFO] [stderr]  --> src/main.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let mut x1: i32 = 0;
[INFO] [stderr]   |             ^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `y1` is never read
[INFO] [stderr]  --> src/main.rs:9:13
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let mut y1: i32 = 0;
[INFO] [stderr]   |             ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/main.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for i in 0..GRID_SIZE {
[INFO] [stderr]    |         ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `x1` is never read
[INFO] [stderr]  --> src/main.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let mut x1: i32 = 0;
[INFO] [stderr]   |             ^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `y1` is never read
[INFO] [stderr]  --> src/main.rs:9:13
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let mut y1: i32 = 0;
[INFO] [stderr]   |             ^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/main.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for i in 0..GRID_SIZE {
[INFO] [stderr]    |         ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub extern "C" fn display_grid(grid: &Vec<u8>) {
[INFO] [stderr]    |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:37
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub extern "C" fn update_grid(grid: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub extern "C" fn display_grid(grid: &Vec<u8>) {
[INFO] [stderr]    |                                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:37
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub extern "C" fn update_grid(grid: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.45s
[INFO] running `"docker" "inspect" "431563b510f8aa5cf47561ba0f37153f2f2ca2b808fd9e96ed213e197532bacf"`
[INFO] running `"docker" "rm" "-f" "431563b510f8aa5cf47561ba0f37153f2f2ca2b808fd9e96ed213e197532bacf"`
[INFO] [stdout] 431563b510f8aa5cf47561ba0f37153f2f2ca2b808fd9e96ed213e197532bacf