[INFO] updating cached repository rarewin/rsmonkey
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rarewin/rsmonkey
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rarewin/rsmonkey" "work/ex/clippy-test-run/sources/stable/gh/rarewin/rsmonkey"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rarewin/rsmonkey'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rarewin/rsmonkey" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rarewin/rsmonkey"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rarewin/rsmonkey'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ec7b81097dfdc59a0af1b703ebdcc9ab5fcb37b1
[INFO] sha for GitHub repo rarewin/rsmonkey: ec7b81097dfdc59a0af1b703ebdcc9ab5fcb37b1
[INFO] validating manifest of rarewin/rsmonkey on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rarewin/rsmonkey on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rarewin/rsmonkey
[INFO] finished frobbing rarewin/rsmonkey
[INFO] frobbed toml for rarewin/rsmonkey written to work/ex/clippy-test-run/sources/stable/gh/rarewin/rsmonkey/Cargo.toml
[INFO] started frobbing rarewin/rsmonkey
[INFO] finished frobbing rarewin/rsmonkey
[INFO] frobbed toml for rarewin/rsmonkey written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rarewin/rsmonkey/Cargo.toml
[INFO] crate rarewin/rsmonkey has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rarewin/rsmonkey against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rarewin/rsmonkey:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13c57659e833da2b9ae902c14ecc2d4d99ff01ef57e694556f1c4b242db1c413
[INFO] running `"docker" "start" "-a" "13c57659e833da2b9ae902c14ecc2d4d99ff01ef57e694556f1c4b242db1c413"`
[INFO] [stderr]     Checking rsmonkey v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return l;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `l`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         return token;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             return '\0';
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             return self.input.as_bytes()[self.read_position] as char;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.as_bytes()[self.read_position] as char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return ('a' <= ch && ch <= 'z') || ('A' <= ch && ch <= 'Z') || ch == '_';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `('a' <= ch && ch <= 'z') || ('A' <= ch && ch <= 'Z') || ch == '_'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:113:5
[INFO] [stderr]     |
[INFO] [stderr] 113 |     return '0' <= ch && ch <= '9';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `'0' <= ch && ch <= '9'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return l;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `l`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         return token;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             return '\0';
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             return self.input.as_bytes()[self.read_position] as char;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.input.as_bytes()[self.read_position] as char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return ('a' <= ch && ch <= 'z') || ('A' <= ch && ch <= 'Z') || ch == '_';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `('a' <= ch && ch <= 'z') || ('A' <= ch && ch <= 'Z') || ch == '_'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:113:5
[INFO] [stderr]     |
[INFO] [stderr] 113 |     return '0' <= ch && ch <= '9';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `'0' <= ch && ch <= '9'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Program`
[INFO] [stderr]   --> src/ast.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> Program {
[INFO] [stderr] 49 | |         Program {
[INFO] [stderr] 50 | |             statements: Vec::new(),
[INFO] [stderr] 51 | |         }
[INFO] [stderr] 52 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/ast.rs:56:12
[INFO] [stderr]    |
[INFO] [stderr] 56 |         if self.statements.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match self.parse_statement() {
[INFO] [stderr] 63 | |                 Node::StatementNode(s) => program.statements.push(Node::StatementNode(s)),
[INFO] [stderr] 64 | |                 _ => {}
[INFO] [stderr] 65 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Node::StatementNode(s) = self.parse_statement() { program.statements.push(Node::StatementNode(s)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Program`
[INFO] [stderr]   --> src/ast.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> Program {
[INFO] [stderr] 49 | |         Program {
[INFO] [stderr] 50 | |             statements: Vec::new(),
[INFO] [stderr] 51 | |         }
[INFO] [stderr] 52 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/token.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn clone(&self) -> Token {
[INFO] [stderr] 55 | |         Token::new(self.token_type, &self.literal)
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/ast.rs:56:12
[INFO] [stderr]    |
[INFO] [stderr] 56 |         if self.statements.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.statements.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match self.parse_statement() {
[INFO] [stderr] 63 | |                 Node::StatementNode(s) => program.statements.push(Node::StatementNode(s)),
[INFO] [stderr] 64 | |                 _ => {}
[INFO] [stderr] 65 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Node::StatementNode(s) = self.parse_statement() { program.statements.push(Node::StatementNode(s)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/token.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn clone(&self) -> Token {
[INFO] [stderr] 55 | |         Token::new(self.token_type, &self.literal)
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `tests`
[INFO] [stderr]    --> src/test/mod.rs:151:14
[INFO] [stderr]     |
[INFO] [stderr] 151 |     for i in 0..tests.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 151 |     for (i, <item>) in tests.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.56s
[INFO] running `"docker" "inspect" "13c57659e833da2b9ae902c14ecc2d4d99ff01ef57e694556f1c4b242db1c413"`
[INFO] running `"docker" "rm" "-f" "13c57659e833da2b9ae902c14ecc2d4d99ff01ef57e694556f1c4b242db1c413"`
[INFO] [stdout] 13c57659e833da2b9ae902c14ecc2d4d99ff01ef57e694556f1c4b242db1c413