[INFO] updating cached repository raphlinus/ghilbert
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/raphlinus/ghilbert
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/raphlinus/ghilbert" "work/ex/clippy-test-run/sources/stable/gh/raphlinus/ghilbert"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/raphlinus/ghilbert'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/raphlinus/ghilbert" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raphlinus/ghilbert"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raphlinus/ghilbert'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 52428c6e7797c288407a36238c822bf7f56639f3
[INFO] sha for GitHub repo raphlinus/ghilbert: 52428c6e7797c288407a36238c822bf7f56639f3
[INFO] validating manifest of raphlinus/ghilbert on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of raphlinus/ghilbert on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing raphlinus/ghilbert
[INFO] finished frobbing raphlinus/ghilbert
[INFO] frobbed toml for raphlinus/ghilbert written to work/ex/clippy-test-run/sources/stable/gh/raphlinus/ghilbert/Cargo.toml
[INFO] started frobbing raphlinus/ghilbert
[INFO] finished frobbing raphlinus/ghilbert
[INFO] frobbed toml for raphlinus/ghilbert written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raphlinus/ghilbert/Cargo.toml
[INFO] crate raphlinus/ghilbert has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting raphlinus/ghilbert against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/raphlinus/ghilbert:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 55de3897dca72668deb98bc4ae9cdcd4a4a63b7903b31ce820c346378e65194e
[INFO] running `"docker" "start" "-a" "55de3897dca72668deb98bc4ae9cdcd4a4a63b7903b31ce820c346378e65194e"`
[INFO] [stderr]     Checking itoa v0.3.3
[INFO] [stderr]     Checking union-find v0.3.1
[INFO] [stderr]     Checking serde_json v1.0.2
[INFO] [stderr]     Checking ghilbert v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/htmlout.rs:396:13
[INFO] [stderr]     |
[INFO] [stderr] 396 |             step_ix: step_ix,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `step_ix`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             text: text,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/session.rs:549:50
[INFO] [stderr]     |
[INFO] [stderr] 549 |         let lhs = Expr::Term { constructor: con, children: children };
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unify.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         constructor: constructor,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constructor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/unify.rs:362:13
[INFO] [stderr]     |
[INFO] [stderr] 362 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/htmlout.rs:396:13
[INFO] [stderr]     |
[INFO] [stderr] 396 |             step_ix: step_ix,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `step_ix`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             text: text,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `text`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/session.rs:549:50
[INFO] [stderr]     |
[INFO] [stderr] 549 |         let lhs = Expr::Term { constructor: con, children: children };
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/unify.rs:247:25
[INFO] [stderr]     |
[INFO] [stderr] 247 |                         constructor: constructor,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constructor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/unify.rs:362:13
[INFO] [stderr]     |
[INFO] [stderr] 362 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/htmlout.rs:282:20
[INFO] [stderr]     |
[INFO] [stderr] 282 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 283 | |                 if let Some(step_ix) = ctx.thm_info.underscores.get(&node.get_start()) {
[INFO] [stderr] 284 | |                     step_info = Some(json!({"def": step_ix}));
[INFO] [stderr] 285 | |                 }
[INFO] [stderr] 286 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 282 |             } else if let Some(step_ix) = ctx.thm_info.underscores.get(&node.get_start()) {
[INFO] [stderr] 283 |     step_info = Some(json!({"def": step_ix}));
[INFO] [stderr] 284 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sexp.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |             b')' => return Err(ParseError::UnexpectedClose),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::UnexpectedClose)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]    --> src/unify.rs:471:9
[INFO] [stderr]     |
[INFO] [stderr] 471 |         /// Maps node of bound var to set of term var nodes it can appear free in.
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/htmlout.rs:282:20
[INFO] [stderr]     |
[INFO] [stderr] 282 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 283 | |                 if let Some(step_ix) = ctx.thm_info.underscores.get(&node.get_start()) {
[INFO] [stderr] 284 | |                     step_info = Some(json!({"def": step_ix}));
[INFO] [stderr] 285 | |                 }
[INFO] [stderr] 286 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 282 |             } else if let Some(step_ix) = ctx.thm_info.underscores.get(&node.get_start()) {
[INFO] [stderr] 283 |     step_info = Some(json!({"def": step_ix}));
[INFO] [stderr] 284 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sexp.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |             b')' => return Err(ParseError::UnexpectedClose),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::UnexpectedClose)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]    --> src/unify.rs:471:9
[INFO] [stderr]     |
[INFO] [stderr] 471 |         /// Maps node of bound var to set of term var nodes it can appear free in.
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `writer`
[INFO] [stderr]    --> src/htmlout.rs:128:39
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub fn write<W: Write>(&mut self, writer: &mut W, parser: &Parser) -> io::Result<()> {
[INFO] [stderr]     |                                       ^^^^^^ help: consider using `_writer` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `line`
[INFO] [stderr]    --> src/htmlout.rs:371:30
[INFO] [stderr]     |
[INFO] [stderr] 371 |     fn start_line(&mut self, line: &ParseNode) {
[INFO] [stderr]     |                              ^^^^ help: consider using `_line` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `writer`
[INFO] [stderr]    --> src/htmlout.rs:128:39
[INFO] [stderr]     |
[INFO] [stderr] 128 |     pub fn write<W: Write>(&mut self, writer: &mut W, parser: &Parser) -> io::Result<()> {
[INFO] [stderr]     |                                       ^^^^^^ help: consider using `_writer` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `line`
[INFO] [stderr]    --> src/htmlout.rs:371:30
[INFO] [stderr]     |
[INFO] [stderr] 371 |     fn start_line(&mut self, line: &ParseNode) {
[INFO] [stderr]     |                              ^^^^ help: consider using `_line` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lexer.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |         let mut node = self.root.traverse(s.chars());
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `cur_info`
[INFO] [stderr]    --> src/htmlout.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 |     fn cur_info(&self) -> &ThmInfo {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_end`
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn get_end(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `session`
[INFO] [stderr]    --> src/session.rs:566:5
[INFO] [stderr]     |
[INFO] [stderr] 566 |     session: &'b Session<'a>,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lexer.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |         let mut node = self.root.traverse(s.chars());
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/htmlout.rs:144:57
[INFO] [stderr]     |
[INFO] [stderr] 144 |           let thm_info = self.thm_info.get(&thm_name_tok).expect(
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 145 | |             &format!("no info for thm {}", parser.tok_str(thm_name_tok)));
[INFO] [stderr]     | |_________________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("no info for thm {}", parser.tok_str(thm_name_tok)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/htmlout.rs:308:9
[INFO] [stderr]     |
[INFO] [stderr] 308 |         self.thm_info.get(&self.cur_tok.unwrap()).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.thm_info[&self.cur_tok.unwrap()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lexer.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |             node = {node}.succ.entry(c).or_insert_with(|| Node::new());
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^ help: remove closure as shown: `Node::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lexer.rs:237:35
[INFO] [stderr]     |
[INFO] [stderr] 237 |                     x.checked_add((c - b'0') as u32))
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:572:13
[INFO] [stderr]     |
[INFO] [stderr] 572 | /             loop {
[INFO] [stderr] 573 | |                 if let Some(tok) = self.lexer.peek() {
[INFO] [stderr] 574 | |                     if Some(tok) == closer || self.binops.contains_key(&tok) {
[INFO] [stderr] 575 | |                         break;
[INFO] [stderr] ...   |
[INFO] [stderr] 580 | |                 }
[INFO] [stderr] 581 | |             }
[INFO] [stderr]     | |_____________^ help: try: `while let Some(tok) = self.lexer.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/session.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     fn apply_proof<L: ProofListener>(&self, proof: &ParseNode, graph: &mut Graph,
[INFO] [stderr] 323 | |         steps: &mut BTreeMap<Token, StepIx>,
[INFO] [stderr] 324 | |         var_map: &mut BTreeMap<Token, usize>,
[INFO] [stderr] 325 | |         bound_map: &mut BTreeMap<Token, usize>,
[INFO] [stderr] ...   |
[INFO] [stderr] 397 | |         last_line.ok_or(Error::EmptyProof)
[INFO] [stderr] 398 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `cur_info`
[INFO] [stderr]    --> src/htmlout.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 |     fn cur_info(&self) -> &ThmInfo {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_end`
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn get_end(&self) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `session`
[INFO] [stderr]    --> src/session.rs:566:5
[INFO] [stderr]     |
[INFO] [stderr] 566 |     session: &'b Session<'a>,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/htmlout.rs:144:57
[INFO] [stderr]     |
[INFO] [stderr] 144 |           let thm_info = self.thm_info.get(&thm_name_tok).expect(
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 145 | |             &format!("no info for thm {}", parser.tok_str(thm_name_tok)));
[INFO] [stderr]     | |_________________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("no info for thm {}", parser.tok_str(thm_name_tok)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/htmlout.rs:308:9
[INFO] [stderr]     |
[INFO] [stderr] 308 |         self.thm_info.get(&self.cur_tok.unwrap()).unwrap()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.thm_info[&self.cur_tok.unwrap()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap`
[INFO] [stderr]    --> src/session.rs:620:5
[INFO] [stderr]     |
[INFO] [stderr] 620 | /     if map.contains_key(&key) {
[INFO] [stderr] 621 | |         None
[INFO] [stderr] 622 | |     } else {
[INFO] [stderr] 623 | |         map.insert(key, val);
[INFO] [stderr] 624 | |         Some(())
[INFO] [stderr] 625 | |     }
[INFO] [stderr]     | |_____^ help: consider using: `map.entry(key)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lexer.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |             node = {node}.succ.entry(c).or_insert_with(|| Node::new());
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^ help: remove closure as shown: `Node::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lexer.rs:237:35
[INFO] [stderr]     |
[INFO] [stderr] 237 |                     x.checked_add((c - b'0') as u32))
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^ help: try: `u32::from(c - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/unify.rs:201:12
[INFO] [stderr]     |
[INFO] [stderr] 201 |         -> Result<(Vec<StepIx>, Vec<Option<usize>>, Vec<Option<usize>>), Error>
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/parser.rs:572:13
[INFO] [stderr]     |
[INFO] [stderr] 572 | /             loop {
[INFO] [stderr] 573 | |                 if let Some(tok) = self.lexer.peek() {
[INFO] [stderr] 574 | |                     if Some(tok) == closer || self.binops.contains_key(&tok) {
[INFO] [stderr] 575 | |                         break;
[INFO] [stderr] ...   |
[INFO] [stderr] 580 | |                 }
[INFO] [stderr] 581 | |             }
[INFO] [stderr]     | |_____________^ help: try: `while let Some(tok) = self.lexer.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/unify.rs:505:19
[INFO] [stderr]     |
[INFO] [stderr] 505 |     fn is_free_in(&mut self, bfind: usize, var: usize,
[INFO] [stderr]     |                   ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/session.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     fn apply_proof<L: ProofListener>(&self, proof: &ParseNode, graph: &mut Graph,
[INFO] [stderr] 323 | |         steps: &mut BTreeMap<Token, StepIx>,
[INFO] [stderr] 324 | |         var_map: &mut BTreeMap<Token, usize>,
[INFO] [stderr] 325 | |         bound_map: &mut BTreeMap<Token, usize>,
[INFO] [stderr] ...   |
[INFO] [stderr] 397 | |         last_line.ok_or(Error::EmptyProof)
[INFO] [stderr] 398 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap`
[INFO] [stderr]    --> src/session.rs:620:5
[INFO] [stderr]     |
[INFO] [stderr] 620 | /     if map.contains_key(&key) {
[INFO] [stderr] 621 | |         None
[INFO] [stderr] 622 | |     } else {
[INFO] [stderr] 623 | |         map.insert(key, val);
[INFO] [stderr] 624 | |         Some(())
[INFO] [stderr] 625 | |     }
[INFO] [stderr]     | |_____^ help: consider using: `map.entry(key)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/unify.rs:201:12
[INFO] [stderr]     |
[INFO] [stderr] 201 |         -> Result<(Vec<StepIx>, Vec<Option<usize>>, Vec<Option<usize>>), Error>
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/unify.rs:505:19
[INFO] [stderr]     |
[INFO] [stderr] 505 |     fn is_free_in(&mut self, bfind: usize, var: usize,
[INFO] [stderr]     |                   ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.83s
[INFO] running `"docker" "inspect" "55de3897dca72668deb98bc4ae9cdcd4a4a63b7903b31ce820c346378e65194e"`
[INFO] running `"docker" "rm" "-f" "55de3897dca72668deb98bc4ae9cdcd4a4a63b7903b31ce820c346378e65194e"`
[INFO] [stdout] 55de3897dca72668deb98bc4ae9cdcd4a4a63b7903b31ce820c346378e65194e