[INFO] updating cached repository rantogno/builder.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rantogno/builder.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rantogno/builder.rs" "work/ex/clippy-test-run/sources/stable/gh/rantogno/builder.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rantogno/builder.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rantogno/builder.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rantogno/builder.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rantogno/builder.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f0e01f64fae5773ca3d6d58c691189f30f9e0b8 [INFO] sha for GitHub repo rantogno/builder.rs: 3f0e01f64fae5773ca3d6d58c691189f30f9e0b8 [INFO] validating manifest of rantogno/builder.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rantogno/builder.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rantogno/builder.rs [INFO] finished frobbing rantogno/builder.rs [INFO] frobbed toml for rantogno/builder.rs written to work/ex/clippy-test-run/sources/stable/gh/rantogno/builder.rs/Cargo.toml [INFO] started frobbing rantogno/builder.rs [INFO] finished frobbing rantogno/builder.rs [INFO] frobbed toml for rantogno/builder.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rantogno/builder.rs/Cargo.toml [INFO] crate rantogno/builder.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rantogno/builder.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rantogno/builder.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59482b921fb30905028b1d252386bb9f133b591d053166e21ce4024167bcb261 [INFO] running `"docker" "start" "-a" "59482b921fb30905028b1d252386bb9f133b591d053166e21ce4024167bcb261"` [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking builder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:26 [INFO] [stderr] | [INFO] [stderr] 84 | Config { verbose: v, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:84:26 [INFO] [stderr] | [INFO] [stderr] 84 | Config { verbose: v, cmd: cmd } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pkglist [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | let pkglist = match matches.values_of("PACKAGE") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 49 | | Some(values) => parse_pkg_list(values.collect()), [INFO] [stderr] 50 | | None => Some(PACKAGES.to_vec()), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `invalid` [INFO] [stderr] --> src/main.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | (invalid, Some(_)) => Command::Invalid, [INFO] [stderr] | ^^^^^^^ help: consider using `_invalid` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cmd` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | cmd: Command, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `force` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | force: bool, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `options` [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | Install{options: InstallOptions}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / match notfound { [INFO] [stderr] 38 | | true => None, [INFO] [stderr] 39 | | false => Some(pkglist), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if notfound { None } else { Some(pkglist) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let v = if matches.is_present("v") { [INFO] [stderr] | _____________^ [INFO] [stderr] 70 | | true [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | false [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `matches.is_present("v")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pkglist [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | let pkglist = match matches.values_of("PACKAGE") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 49 | | Some(values) => parse_pkg_list(values.collect()), [INFO] [stderr] 50 | | None => Some(PACKAGES.to_vec()), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `invalid` [INFO] [stderr] --> src/main.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | (invalid, Some(_)) => Command::Invalid, [INFO] [stderr] | ^^^^^^^ help: consider using `_invalid` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cmd` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | cmd: Command, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `force` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | force: bool, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `options` [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | Install{options: InstallOptions}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / match notfound { [INFO] [stderr] 38 | | true => None, [INFO] [stderr] 39 | | false => Some(pkglist), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if notfound { None } else { Some(pkglist) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let v = if matches.is_present("v") { [INFO] [stderr] | _____________^ [INFO] [stderr] 70 | | true [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | false [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `matches.is_present("v")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.76s [INFO] running `"docker" "inspect" "59482b921fb30905028b1d252386bb9f133b591d053166e21ce4024167bcb261"` [INFO] running `"docker" "rm" "-f" "59482b921fb30905028b1d252386bb9f133b591d053166e21ce4024167bcb261"` [INFO] [stdout] 59482b921fb30905028b1d252386bb9f133b591d053166e21ce4024167bcb261