[INFO] updating cached repository ramon54321/StateScrubStructure [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ramon54321/StateScrubStructure [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ramon54321/StateScrubStructure" "work/ex/clippy-test-run/sources/stable/gh/ramon54321/StateScrubStructure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ramon54321/StateScrubStructure'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ramon54321/StateScrubStructure" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramon54321/StateScrubStructure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramon54321/StateScrubStructure'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d5830e1c17d4d7dc60423f5fd2031f59ce50f82 [INFO] sha for GitHub repo ramon54321/StateScrubStructure: 1d5830e1c17d4d7dc60423f5fd2031f59ce50f82 [INFO] validating manifest of ramon54321/StateScrubStructure on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ramon54321/StateScrubStructure on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ramon54321/StateScrubStructure [INFO] finished frobbing ramon54321/StateScrubStructure [INFO] frobbed toml for ramon54321/StateScrubStructure written to work/ex/clippy-test-run/sources/stable/gh/ramon54321/StateScrubStructure/Cargo.toml [INFO] started frobbing ramon54321/StateScrubStructure [INFO] finished frobbing ramon54321/StateScrubStructure [INFO] frobbed toml for ramon54321/StateScrubStructure written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramon54321/StateScrubStructure/Cargo.toml [INFO] crate ramon54321/StateScrubStructure has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ramon54321/StateScrubStructure against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramon54321/StateScrubStructure:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76eba5f3ff69c83d39d18edb11bf72be9c08f1013341fa93def4706336a00b44 [INFO] running `"docker" "start" "-a" "76eba5f3ff69c83d39d18edb11bf72be9c08f1013341fa93def4706336a00b44"` [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking rust_simple v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | / return Some(interpolate::between(*key_l, *value_l, [INFO] [stderr] 173 | | *key_r, *value_r, t)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | Some(interpolate::between(*key_l, *value_l, [INFO] [stderr] 173 | *key_r, *value_r, t)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | return Some(*value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:22 [INFO] [stderr] | [INFO] [stderr] 193 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | return y0 + (t - x0) as f64 * ((y1 - y0) / (x1 - x0) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y0 + (t - x0) as f64 * ((y1 - y0) / (x1 - x0) as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | / return Some(interpolate::between(*key_l, *value_l, [INFO] [stderr] 173 | | *key_r, *value_r, t)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | Some(interpolate::between(*key_l, *value_l, [INFO] [stderr] 173 | *key_r, *value_r, t)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | return Some(*value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:193:22 [INFO] [stderr] | [INFO] [stderr] 193 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | return y0 + (t - x0) as f64 * ((y1 - y0) / (x1 - x0) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y0 + (t - x0) as f64 * ((y1 - y0) / (x1 - x0) as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/main.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | for (id, entity) in &self.entities { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/main.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for (label, graph) in &self.graphs { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:190:23 [INFO] [stderr] | [INFO] [stderr] 190 | Some((key, value)) => { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let mut new_entity = Entity { id: NEXT_ENTITY_ID, [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/main.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | for (id, entity) in &self.entities { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `label` [INFO] [stderr] --> src/main.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for (label, graph) in &self.graphs { [INFO] [stderr] | ^^^^^ help: consider using `_label` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:190:23 [INFO] [stderr] | [INFO] [stderr] 190 | Some((key, value)) => { [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | id : u16, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PositionY` [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | PositionY = 1, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PositionZ` [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | PositionZ = 2 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new(state : &mut State) { [INFO] [stderr] 52 | | unsafe { [INFO] [stderr] 53 | | let mut new_entity = Entity { id: NEXT_ENTITY_ID, [INFO] [stderr] 54 | | graphs: HashMap::new() }; [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match graph { [INFO] [stderr] 84 | | Some(g) => g.add_key(t, v), [INFO] [stderr] 85 | | None => () [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(g) = graph { g.add_key(t, v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | let mut new_entity = Entity { id: NEXT_ENTITY_ID, [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `keyOption` should have a snake case name such as `key_option` [INFO] [stderr] --> src/main.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let keyOption = self.keys.range((Unbounded, (Included(t)))).next_back(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | simple_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `id` [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | id : u16, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PositionY` [INFO] [stderr] --> src/main.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | PositionY = 1, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PositionZ` [INFO] [stderr] --> src/main.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | PositionZ = 2 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn print(self : &Self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new(state : &mut State) { [INFO] [stderr] 52 | | unsafe { [INFO] [stderr] 53 | | let mut new_entity = Entity { id: NEXT_ENTITY_ID, [INFO] [stderr] 54 | | graphs: HashMap::new() }; [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match graph { [INFO] [stderr] 84 | | Some(g) => g.add_key(t, v), [INFO] [stderr] 85 | | None => () [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(g) = graph { g.add_key(t, v) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable `keyOption` should have a snake case name such as `key_option` [INFO] [stderr] --> src/main.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let keyOption = self.keys.range((Unbounded, (Included(t)))).next_back(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | simple_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "76eba5f3ff69c83d39d18edb11bf72be9c08f1013341fa93def4706336a00b44"` [INFO] running `"docker" "rm" "-f" "76eba5f3ff69c83d39d18edb11bf72be9c08f1013341fa93def4706336a00b44"` [INFO] [stdout] 76eba5f3ff69c83d39d18edb11bf72be9c08f1013341fa93def4706336a00b44