[INFO] updating cached repository ramn/repay [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ramn/repay [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/repay" "work/ex/clippy-test-run/sources/stable/gh/ramn/repay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ramn/repay'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/repay" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/repay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/repay'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eba02f095c86c01f0bf98b7bc48af383a34f0d8a [INFO] sha for GitHub repo ramn/repay: eba02f095c86c01f0bf98b7bc48af383a34f0d8a [INFO] validating manifest of ramn/repay on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ramn/repay on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ramn/repay [INFO] finished frobbing ramn/repay [INFO] frobbed toml for ramn/repay written to work/ex/clippy-test-run/sources/stable/gh/ramn/repay/Cargo.toml [INFO] started frobbing ramn/repay [INFO] finished frobbing ramn/repay [INFO] frobbed toml for ramn/repay written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/repay/Cargo.toml [INFO] crate ramn/repay has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ramn/repay against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/repay:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef36925bb8bc9ca0220cab2dc32c9fe1fc5b40fbaf4f19ea08ff66fad589bab7 [INFO] running `"docker" "start" "-a" "ef36925bb8bc9ca0220cab2dc32c9fe1fc5b40fbaf4f19ea08ff66fad589bab7"` [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking num-iter v0.1.32 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking repay v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | Record { debtors: debtors, .. record } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `debtors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | creditor: creditor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creditor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | Record { debtors: debtors, .. record } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `debtors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | creditor: creditor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `creditor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:456:21 [INFO] [stderr] | [INFO] [stderr] 456 | const INPUT_1: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:204:39 [INFO] [stderr] | [INFO] [stderr] 204 | .filter(|&(_, ref v)| v > &money::zero()) [INFO] [stderr] | ^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `money::zero()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:212:39 [INFO] [stderr] | [INFO] [stderr] 212 | .filter(|&(_, ref v)| v < &money::zero()) [INFO] [stderr] | ^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `money::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:235:15 [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && &debt != &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 235 | while debt != last_debt && &debt != &zero { [INFO] [stderr] | ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && &debt != &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && debt != zero { [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:238:48 [INFO] [stderr] | [INFO] [stderr] 238 | .position(|x| x.0 != person && &x.1 < &zero); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 238 | .position(|x| x.0 != person && x.1 < zero); [INFO] [stderr] | ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | if &remainder >= &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 242 | if remainder >= zero { [INFO] [stderr] | ^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:247:27 [INFO] [stderr] | [INFO] [stderr] 247 | } else if &remainder < &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 247 | } else if remainder < zero { [INFO] [stderr] | ^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:204:39 [INFO] [stderr] | [INFO] [stderr] 204 | .filter(|&(_, ref v)| v > &money::zero()) [INFO] [stderr] | ^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `money::zero()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:212:39 [INFO] [stderr] | [INFO] [stderr] 212 | .filter(|&(_, ref v)| v < &money::zero()) [INFO] [stderr] | ^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `money::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:235:15 [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && &debt != &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 235 | while debt != last_debt && &debt != &zero { [INFO] [stderr] | ^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:235:38 [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && &debt != &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 235 | while &debt != &last_debt && debt != zero { [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:238:48 [INFO] [stderr] | [INFO] [stderr] 238 | .position(|x| x.0 != person && &x.1 < &zero); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 238 | .position(|x| x.0 != person && x.1 < zero); [INFO] [stderr] | ^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | if &remainder >= &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 242 | if remainder >= zero { [INFO] [stderr] | ^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:247:27 [INFO] [stderr] | [INFO] [stderr] 247 | } else if &remainder < &zero { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 247 | } else if remainder < zero { [INFO] [stderr] | ^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.13s [INFO] running `"docker" "inspect" "ef36925bb8bc9ca0220cab2dc32c9fe1fc5b40fbaf4f19ea08ff66fad589bab7"` [INFO] running `"docker" "rm" "-f" "ef36925bb8bc9ca0220cab2dc32c9fe1fc5b40fbaf4f19ea08ff66fad589bab7"` [INFO] [stdout] ef36925bb8bc9ca0220cab2dc32c9fe1fc5b40fbaf4f19ea08ff66fad589bab7