[INFO] updating cached repository ramn/allehanda-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ramn/allehanda-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/allehanda-rs" "work/ex/clippy-test-run/sources/stable/gh/ramn/allehanda-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ramn/allehanda-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ramn/allehanda-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/allehanda-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/allehanda-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fcdf830c4a7970f47f7c3b3e32a1dd859e03d69 [INFO] sha for GitHub repo ramn/allehanda-rs: 2fcdf830c4a7970f47f7c3b3e32a1dd859e03d69 [INFO] validating manifest of ramn/allehanda-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ramn/allehanda-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ramn/allehanda-rs [INFO] finished frobbing ramn/allehanda-rs [INFO] frobbed toml for ramn/allehanda-rs written to work/ex/clippy-test-run/sources/stable/gh/ramn/allehanda-rs/Cargo.toml [INFO] started frobbing ramn/allehanda-rs [INFO] finished frobbing ramn/allehanda-rs [INFO] frobbed toml for ramn/allehanda-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/allehanda-rs/Cargo.toml [INFO] crate ramn/allehanda-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ramn/allehanda-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ramn/allehanda-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30788d51ec9025c4d60e32502c2346a653604068d81ccacc01e10fc7625f7409 [INFO] running `"docker" "start" "-a" "30788d51ec9025c4d60e32502c2346a653604068d81ccacc01e10fc7625f7409"` [INFO] [stderr] Checking allehanda v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | vertex_count: vertex_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | adjacents: adjacents [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | vertex_count: vertex_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | adjacents: adjacents [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | dimensions: dimensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dimensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recurse.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(fact((12, 1)).run(), 479001600); [INFO] [stderr] | ^^^^^^^^^ help: consider: `479_001_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recurse.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(fact((13, 1)).run(), 6227020800); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_227_020_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recurse.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(fact((14, 1)).run(), 87178291200); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `87_178_291_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recurse.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(take(1000000, 0).run(), 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/recurse.rs:67:44 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(take(1000000, 0).run(), 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/list.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | let (tail, result) = match &*self.0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 29 | | &List::Nil => { [INFO] [stderr] 30 | | (self.0.clone(), None) [INFO] [stderr] 31 | | } [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | let (tail, result) = match *self.0 { [INFO] [stderr] 29 | List::Nil => { [INFO] [stderr] 30 | (self.0.clone(), None) [INFO] [stderr] 31 | } [INFO] [stderr] 32 | List::Cons(ref x, ref xs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/knapsack.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for j in (w[i]..max_w+1).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(w[i]..max_w+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/knapsack.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for j in (w[i]..max_w+1).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(w[i]..=max_w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knapsack.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | let selections: Vec = list::iter(selections[max_w].clone()) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 31 | | .map(|x| *x) [INFO] [stderr] | |____________________^ help: Consider calling the dedicated `cloned` method: `list::iter(selections[max_w].clone()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/permutation.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | .fold(0, |memo, (j, a)| if a > &xs[i] { j } else { memo }); [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `xs[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/list.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | let (tail, result) = match &*self.0 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 29 | | &List::Nil => { [INFO] [stderr] 30 | | (self.0.clone(), None) [INFO] [stderr] 31 | | } [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | let (tail, result) = match *self.0 { [INFO] [stderr] 29 | List::Nil => { [INFO] [stderr] 30 | (self.0.clone(), None) [INFO] [stderr] 31 | } [INFO] [stderr] 32 | List::Cons(ref x, ref xs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/knapsack.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for j in (w[i]..max_w+1).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(w[i]..max_w+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/knapsack.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | for j in (w[i]..max_w+1).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(w[i]..=max_w)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knapsack.rs:30:34 [INFO] [stderr] | [INFO] [stderr] 30 | let selections: Vec = list::iter(selections[max_w].clone()) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 31 | | .map(|x| *x) [INFO] [stderr] | |____________________^ help: Consider calling the dedicated `cloned` method: `list::iter(selections[max_w].clone()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/permutation.rs:7:40 [INFO] [stderr] | [INFO] [stderr] 7 | .fold(0, |memo, (j, a)| if a > &xs[i] { j } else { memo }); [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `xs[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "30788d51ec9025c4d60e32502c2346a653604068d81ccacc01e10fc7625f7409"` [INFO] running `"docker" "rm" "-f" "30788d51ec9025c4d60e32502c2346a653604068d81ccacc01e10fc7625f7409"` [INFO] [stdout] 30788d51ec9025c4d60e32502c2346a653604068d81ccacc01e10fc7625f7409