[INFO] updating cached repository quitesimpleorg/raou
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/quitesimpleorg/raou
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/quitesimpleorg/raou" "work/ex/clippy-test-run/sources/stable/gh/quitesimpleorg/raou"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/quitesimpleorg/raou'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/quitesimpleorg/raou" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quitesimpleorg/raou"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quitesimpleorg/raou'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 352989756ccb691db1ddb9a40887aebb11b7918d
[INFO] sha for GitHub repo quitesimpleorg/raou: 352989756ccb691db1ddb9a40887aebb11b7918d
[INFO] validating manifest of quitesimpleorg/raou on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of quitesimpleorg/raou on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing quitesimpleorg/raou
[INFO] finished frobbing quitesimpleorg/raou
[INFO] frobbed toml for quitesimpleorg/raou written to work/ex/clippy-test-run/sources/stable/gh/quitesimpleorg/raou/Cargo.toml
[INFO] started frobbing quitesimpleorg/raou
[INFO] finished frobbing quitesimpleorg/raou
[INFO] frobbed toml for quitesimpleorg/raou written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quitesimpleorg/raou/Cargo.toml
[INFO] crate quitesimpleorg/raou has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting quitesimpleorg/raou against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quitesimpleorg/raou:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0030d16585d146254addaae1811e98e9ac1ce131d1939a9f59c5e67ad1485a7b
[INFO] running `"docker" "start" "-a" "0030d16585d146254addaae1811e98e9ac1ce131d1939a9f59c5e67ad1485a7b"`
[INFO] [stderr]     Checking raou v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         return Entry {
[INFO] [stderr] 26 | |             users: Vec::new(),
[INFO] [stderr] 27 | |             dest_user: String::new(),
[INFO] [stderr] 28 | |             cmd: String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             arbitrary_args: false,
[INFO] [stderr] 34 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Entry {
[INFO] [stderr] 26 |             users: Vec::new(),
[INFO] [stderr] 27 |             dest_user: String::new(),
[INFO] [stderr] 28 |             cmd: String::new(),
[INFO] [stderr] 29 |             args: String::new(),
[INFO] [stderr] 30 |             argv0: String::new(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     return errnowrapper(unsafe {
[INFO] [stderr] 53 | |         libc::initgroups(userarg.unwrap().as_ptr(), group)
[INFO] [stderr] 54 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |     errnowrapper(unsafe {
[INFO] [stderr] 53 |         libc::initgroups(userarg.unwrap().as_ptr(), group)
[INFO] [stderr] 54 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return errnowrapper(unsafe { libc::setuid(id) });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::setuid(id) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return errnowrapper(unsafe { libc::setgid(gid) });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::setgid(gid) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return libc::geteuid();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `libc::geteuid()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     return Err(Error::new(
[INFO] [stderr] 117 | |         ErrorKind::PermissionDenied,
[INFO] [stderr] 118 | |         "Not allowed to become target user",
[INFO] [stderr] 119 | |     ));
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 116 |     Err(Error::new(
[INFO] [stderr] 117 |         ErrorKind::PermissionDenied,
[INFO] [stderr] 118 |         "Not allowed to become target user",
[INFO] [stderr] 119 |     ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/main.rs:144:48
[INFO] [stderr]     |
[INFO] [stderr] 144 |         "allow_args" => entry.arbitrary_args = (val == "1" || val == "true"),
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/main.rs:146:48
[INFO] [stderr]     |
[INFO] [stderr] 146 |         "no_new_privs" => entry.no_new_privs = (val == "1" || val == "true"),
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 |     return errnowrapper(unsafe { libc::clearenv() });
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::clearenv() })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:208:8
[INFO] [stderr]     |
[INFO] [stderr] 208 |     if (entry.no_new_privs) {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:219:5
[INFO] [stderr]     |
[INFO] [stderr] 219 |     return CString::new(s.as_ref()).unwrap().into_raw();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(s.as_ref()).unwrap().into_raw()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:243:5
[INFO] [stderr]     |
[INFO] [stderr] 243 |     return args;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 | /         return Err(Error::new(
[INFO] [stderr] 267 | |             ErrorKind::PermissionDenied,
[INFO] [stderr] 268 | |             "Failed to switch user: ".to_owned() + &e.to_string(),
[INFO] [stderr] 269 | |         ));
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 266 |         Err(Error::new(
[INFO] [stderr] 267 |             ErrorKind::PermissionDenied,
[INFO] [stderr] 268 |             "Failed to switch user: ".to_owned() + &e.to_string(),
[INFO] [stderr] 269 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:273:13
[INFO] [stderr]     |
[INFO] [stderr] 273 | /             return Err(Error::new(
[INFO] [stderr] 274 | |                 ErrorKind::Other,
[INFO] [stderr] 275 | |                 "Environment setup failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 276 | |             ));
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 273 |             Err(Error::new(
[INFO] [stderr] 274 |                 ErrorKind::Other,
[INFO] [stderr] 275 |                 "Environment setup failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 276 |             ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:279:9
[INFO] [stderr]     |
[INFO] [stderr] 279 | /         return Err(Error::new(
[INFO] [stderr] 280 | |             ErrorKind::Other,
[INFO] [stderr] 281 | |             "Sandbox init failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 282 | |         ));
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 279 |         Err(Error::new(
[INFO] [stderr] 280 |             ErrorKind::Other,
[INFO] [stderr] 281 |             "Sandbox init failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 282 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:288:17
[INFO] [stderr]     |
[INFO] [stderr] 288 | /                 return Err(Error::new(
[INFO] [stderr] 289 | |                     ErrorKind::Other,
[INFO] [stderr] 290 | |                     "execv failed: ".to_owned() + &e.to_string(),
[INFO] [stderr] 291 | |                 ));
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 Err(Error::new(
[INFO] [stderr] 289 |                     ErrorKind::Other,
[INFO] [stderr] 290 |                     "execv failed: ".to_owned() + &e.to_string(),
[INFO] [stderr] 291 |                 ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         return Entry {
[INFO] [stderr] 26 | |             users: Vec::new(),
[INFO] [stderr] 27 | |             dest_user: String::new(),
[INFO] [stderr] 28 | |             cmd: String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             arbitrary_args: false,
[INFO] [stderr] 34 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Entry {
[INFO] [stderr] 26 |             users: Vec::new(),
[INFO] [stderr] 27 |             dest_user: String::new(),
[INFO] [stderr] 28 |             cmd: String::new(),
[INFO] [stderr] 29 |             args: String::new(),
[INFO] [stderr] 30 |             argv0: String::new(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     return errnowrapper(unsafe {
[INFO] [stderr] 53 | |         libc::initgroups(userarg.unwrap().as_ptr(), group)
[INFO] [stderr] 54 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |     errnowrapper(unsafe {
[INFO] [stderr] 53 |         libc::initgroups(userarg.unwrap().as_ptr(), group)
[INFO] [stderr] 54 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return errnowrapper(unsafe { libc::setuid(id) });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::setuid(id) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return errnowrapper(unsafe { libc::setgid(gid) });
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::setgid(gid) })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |         return libc::geteuid();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `libc::geteuid()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     return Err(Error::new(
[INFO] [stderr] 117 | |         ErrorKind::PermissionDenied,
[INFO] [stderr] 118 | |         "Not allowed to become target user",
[INFO] [stderr] 119 | |     ));
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 116 |     Err(Error::new(
[INFO] [stderr] 117 |         ErrorKind::PermissionDenied,
[INFO] [stderr] 118 |         "Not allowed to become target user",
[INFO] [stderr] 119 |     ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/main.rs:144:48
[INFO] [stderr]     |
[INFO] [stderr] 144 |         "allow_args" => entry.arbitrary_args = (val == "1" || val == "true"),
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around assigned value
[INFO] [stderr]    --> src/main.rs:146:48
[INFO] [stderr]     |
[INFO] [stderr] 146 |         "no_new_privs" => entry.no_new_privs = (val == "1" || val == "true"),
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 |     return errnowrapper(unsafe { libc::clearenv() });
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `errnowrapper(unsafe { libc::clearenv() })`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:208:8
[INFO] [stderr]     |
[INFO] [stderr] 208 |     if (entry.no_new_privs) {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:219:5
[INFO] [stderr]     |
[INFO] [stderr] 219 |     return CString::new(s.as_ref()).unwrap().into_raw();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(s.as_ref()).unwrap().into_raw()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:243:5
[INFO] [stderr]     |
[INFO] [stderr] 243 |     return args;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:266:9
[INFO] [stderr]     |
[INFO] [stderr] 266 | /         return Err(Error::new(
[INFO] [stderr] 267 | |             ErrorKind::PermissionDenied,
[INFO] [stderr] 268 | |             "Failed to switch user: ".to_owned() + &e.to_string(),
[INFO] [stderr] 269 | |         ));
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 266 |         Err(Error::new(
[INFO] [stderr] 267 |             ErrorKind::PermissionDenied,
[INFO] [stderr] 268 |             "Failed to switch user: ".to_owned() + &e.to_string(),
[INFO] [stderr] 269 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:273:13
[INFO] [stderr]     |
[INFO] [stderr] 273 | /             return Err(Error::new(
[INFO] [stderr] 274 | |                 ErrorKind::Other,
[INFO] [stderr] 275 | |                 "Environment setup failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 276 | |             ));
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 273 |             Err(Error::new(
[INFO] [stderr] 274 |                 ErrorKind::Other,
[INFO] [stderr] 275 |                 "Environment setup failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 276 |             ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:279:9
[INFO] [stderr]     |
[INFO] [stderr] 279 | /         return Err(Error::new(
[INFO] [stderr] 280 | |             ErrorKind::Other,
[INFO] [stderr] 281 | |             "Sandbox init failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 282 | |         ));
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 279 |         Err(Error::new(
[INFO] [stderr] 280 |             ErrorKind::Other,
[INFO] [stderr] 281 |             "Sandbox init failure: ".to_owned() + &e.to_string(),
[INFO] [stderr] 282 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:288:17
[INFO] [stderr]     |
[INFO] [stderr] 288 | /                 return Err(Error::new(
[INFO] [stderr] 289 | |                     ErrorKind::Other,
[INFO] [stderr] 290 | |                     "execv failed: ".to_owned() + &e.to_string(),
[INFO] [stderr] 291 | |                 ));
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 288 |                 Err(Error::new(
[INFO] [stderr] 289 |                     ErrorKind::Other,
[INFO] [stderr] 290 |                     "execv failed: ".to_owned() + &e.to_string(),
[INFO] [stderr] 291 |                 ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/main.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 |     Ok(())
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `pw_passwd`
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pw_passwd: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `pw_gecos`
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pw_gecos: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]   --> src/main.rs:84:55
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let pwnamresult: *mut passwd = libc::getpwnam(CString::new(username).unwrap().as_ptr());
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default
[INFO] [stderr]    = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]   --> src/main.rs:84:55
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let pwnamresult: *mut passwd = libc::getpwnam(CString::new(username).unwrap().as_ptr());
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]    --> src/main.rs:295:5
[INFO] [stderr]     |
[INFO] [stderr] 295 |     Ok(())
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/main.rs:158:8
[INFO] [stderr]     |
[INFO] [stderr] 158 |     if !key.is_some() || !value.is_some() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.is_none() || value.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:222:46
[INFO] [stderr]     |
[INFO] [stderr] 222 | fn create_execv_args(entry: &Entry, cmdargs: &Vec<String>) -> Vec<*const libc::c_char> {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 | /     let mut args: Vec<*const libc::c_char>;
[INFO] [stderr] 226 | |     if entry.arbitrary_args && cmdargs.len() > 2 {
[INFO] [stderr] 227 | |         args = cmdargs.iter().skip(2).map(to_cstring).collect();
[INFO] [stderr] 228 | |     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |             .collect();
[INFO] [stderr] 235 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 225 |     let <mut> args = if entry.arbitrary_args && cmdargs.len() > 2 { cmdargs.iter().skip(2).map(to_cstring).collect() } else { entry
[INFO] [stderr] 226 |             .args
[INFO] [stderr] 227 |             .as_str()
[INFO] [stderr] 228 |             .split_whitespace()
[INFO] [stderr] 229 |             .map(to_cstring)
[INFO] [stderr] 230 |             .collect() };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:239:41
[INFO] [stderr]     |
[INFO] [stderr] 239 |         let cmdbegin = &entry.cmd.rfind("/").unwrap() + 1;
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:245:35
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn exec(entryname: &str, cmdargs: &Vec<String>) -> std::io::Result<()> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:247:5
[INFO] [stderr]     |
[INFO] [stderr] 247 |     filepath = filepath + entryname;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filepath += entryname`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:304:9
[INFO] [stderr]     |
[INFO] [stderr] 304 | /         match exec(&entryname.unwrap(), &cmdargs) {
[INFO] [stderr] 305 | |             Err(e) => {
[INFO] [stderr] 306 | |                 eprintln!("The following error ocurred:");
[INFO] [stderr] 307 | |                 eprintln!("{}", e);
[INFO] [stderr] ...   |
[INFO] [stderr] 311 | |             _ => {}
[INFO] [stderr] 312 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 304 |         if let Err(e) = exec(&entryname.unwrap(), &cmdargs) {
[INFO] [stderr] 305 |     eprintln!("The following error ocurred:");
[INFO] [stderr] 306 |     eprintln!("{}", e);
[INFO] [stderr] 307 | 
[INFO] [stderr] 308 |     std::process::exit(1);
[INFO] [stderr] 309 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `raou`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: field is never used: `pw_passwd`
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pw_passwd: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `pw_gecos`
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pw_gecos: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: you are getting the inner pointer of a temporary `CString`
[INFO] [stderr]   --> src/main.rs:84:55
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let pwnamresult: *mut passwd = libc::getpwnam(CString::new(username).unwrap().as_ptr());
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default
[INFO] [stderr]    = note: that pointer will be invalid outside this expression
[INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime
[INFO] [stderr]   --> src/main.rs:84:55
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let pwnamresult: *mut passwd = libc::getpwnam(CString::new(username).unwrap().as_ptr());
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/main.rs:158:8
[INFO] [stderr]     |
[INFO] [stderr] 158 |     if !key.is_some() || !value.is_some() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `key.is_none() || value.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:222:46
[INFO] [stderr]     |
[INFO] [stderr] 222 | fn create_execv_args(entry: &Entry, cmdargs: &Vec<String>) -> Vec<*const libc::c_char> {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 | /     let mut args: Vec<*const libc::c_char>;
[INFO] [stderr] 226 | |     if entry.arbitrary_args && cmdargs.len() > 2 {
[INFO] [stderr] 227 | |         args = cmdargs.iter().skip(2).map(to_cstring).collect();
[INFO] [stderr] 228 | |     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |             .collect();
[INFO] [stderr] 235 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 225 |     let <mut> args = if entry.arbitrary_args && cmdargs.len() > 2 { cmdargs.iter().skip(2).map(to_cstring).collect() } else { entry
[INFO] [stderr] 226 |             .args
[INFO] [stderr] 227 |             .as_str()
[INFO] [stderr] 228 |             .split_whitespace()
[INFO] [stderr] 229 |             .map(to_cstring)
[INFO] [stderr] 230 |             .collect() };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:239:41
[INFO] [stderr]     |
[INFO] [stderr] 239 |         let cmdbegin = &entry.cmd.rfind("/").unwrap() + 1;
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:245:35
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn exec(entryname: &str, cmdargs: &Vec<String>) -> std::io::Result<()> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:247:5
[INFO] [stderr]     |
[INFO] [stderr] 247 |     filepath = filepath + entryname;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filepath += entryname`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:304:9
[INFO] [stderr]     |
[INFO] [stderr] 304 | /         match exec(&entryname.unwrap(), &cmdargs) {
[INFO] [stderr] 305 | |             Err(e) => {
[INFO] [stderr] 306 | |                 eprintln!("The following error ocurred:");
[INFO] [stderr] 307 | |                 eprintln!("{}", e);
[INFO] [stderr] ...   |
[INFO] [stderr] 311 | |             _ => {}
[INFO] [stderr] 312 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 304 |         if let Err(e) = exec(&entryname.unwrap(), &cmdargs) {
[INFO] [stderr] 305 |     eprintln!("The following error ocurred:");
[INFO] [stderr] 306 |     eprintln!("{}", e);
[INFO] [stderr] 307 | 
[INFO] [stderr] 308 |     std::process::exit(1);
[INFO] [stderr] 309 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `raou`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "0030d16585d146254addaae1811e98e9ac1ce131d1939a9f59c5e67ad1485a7b"`
[INFO] running `"docker" "rm" "-f" "0030d16585d146254addaae1811e98e9ac1ce131d1939a9f59c5e67ad1485a7b"`
[INFO] [stdout] 0030d16585d146254addaae1811e98e9ac1ce131d1939a9f59c5e67ad1485a7b