[INFO] updating cached repository quadrifoglio/olvmc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/quadrifoglio/olvmc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/quadrifoglio/olvmc" "work/ex/clippy-test-run/sources/stable/gh/quadrifoglio/olvmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/quadrifoglio/olvmc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/quadrifoglio/olvmc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadrifoglio/olvmc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadrifoglio/olvmc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b50771276acc714813697f018753c56fac3b1893 [INFO] sha for GitHub repo quadrifoglio/olvmc: b50771276acc714813697f018753c56fac3b1893 [INFO] validating manifest of quadrifoglio/olvmc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quadrifoglio/olvmc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quadrifoglio/olvmc [INFO] finished frobbing quadrifoglio/olvmc [INFO] frobbed toml for quadrifoglio/olvmc written to work/ex/clippy-test-run/sources/stable/gh/quadrifoglio/olvmc/Cargo.toml [INFO] started frobbing quadrifoglio/olvmc [INFO] finished frobbing quadrifoglio/olvmc [INFO] frobbed toml for quadrifoglio/olvmc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadrifoglio/olvmc/Cargo.toml [INFO] crate quadrifoglio/olvmc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quadrifoglio/olvmc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/quadrifoglio/olvmc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f182e3af3c28f40214c314a0416a42128ec97db30ea8067b938c81db0acaa819 [INFO] running `"docker" "start" "-a" "f182e3af3c28f40214c314a0416a42128ec97db30ea8067b938c81db0acaa819"` [INFO] [stderr] Checking term v0.4.5 [INFO] [stderr] Checking encode_unicode v0.2.0 [INFO] [stderr] Checking lazy_static v0.2.4 [INFO] [stderr] Checking json v0.11.5 [INFO] [stderr] Checking csv v0.14.7 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking prettytable-rs v0.6.6 [INFO] [stderr] Checking olvmc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interface.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/interface.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/main.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / fn main() { [INFO] [stderr] 65 | | let srv = "127.0.0.1:1997"; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | let matches = App::new("olvm") [INFO] [stderr] ... | [INFO] [stderr] 458 | | } [INFO] [stderr] 459 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/main.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / fn main() { [INFO] [stderr] 65 | | let srv = "127.0.0.1:1997"; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | let matches = App::new("olvm") [INFO] [stderr] ... | [INFO] [stderr] 458 | | } [INFO] [stderr] 459 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | else if let Some(_) = matches.subcommand_matches("listimg") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 303 | | match image::list(srv) { [INFO] [stderr] 304 | | Ok(_) => {}, [INFO] [stderr] 305 | | Err(e) => println!("Failed to get image: {}", e) [INFO] [stderr] 306 | | }; [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listimg").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | else if let Some(_) = matches.subcommand_matches("listnet") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 339 | | match network::list(srv) { [INFO] [stderr] 340 | | Ok(_) => {}, [INFO] [stderr] 341 | | Err(e) => println!("Failed to get network: {}", e) [INFO] [stderr] 342 | | }; [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listnet").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:367:17 [INFO] [stderr] | [INFO] [stderr] 367 | else if let Some(_) = matches.subcommand_matches("listvm") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 368 | | match vm::list(srv) { [INFO] [stderr] 369 | | Ok(_) => {}, [INFO] [stderr] 370 | | Err(e) => println!("Failed to get vm: {}", e) [INFO] [stderr] 371 | | }; [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listvm").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | else if let Some(_) = matches.subcommand_matches("listimg") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 303 | | match image::list(srv) { [INFO] [stderr] 304 | | Ok(_) => {}, [INFO] [stderr] 305 | | Err(e) => println!("Failed to get image: {}", e) [INFO] [stderr] 306 | | }; [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listimg").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | else if let Some(_) = matches.subcommand_matches("listnet") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 339 | | match network::list(srv) { [INFO] [stderr] 340 | | Ok(_) => {}, [INFO] [stderr] 341 | | Err(e) => println!("Failed to get network: {}", e) [INFO] [stderr] 342 | | }; [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listnet").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:367:17 [INFO] [stderr] | [INFO] [stderr] 367 | else if let Some(_) = matches.subcommand_matches("listvm") { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 368 | | match vm::list(srv) { [INFO] [stderr] 369 | | Ok(_) => {}, [INFO] [stderr] 370 | | Err(e) => println!("Failed to get vm: {}", e) [INFO] [stderr] 371 | | }; [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("listvm").is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.80s [INFO] running `"docker" "inspect" "f182e3af3c28f40214c314a0416a42128ec97db30ea8067b938c81db0acaa819"` [INFO] running `"docker" "rm" "-f" "f182e3af3c28f40214c314a0416a42128ec97db30ea8067b938c81db0acaa819"` [INFO] [stdout] f182e3af3c28f40214c314a0416a42128ec97db30ea8067b938c81db0acaa819