[INFO] updating cached repository qhapaq-49/rust-hyperloglog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/qhapaq-49/rust-hyperloglog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/qhapaq-49/rust-hyperloglog" "work/ex/clippy-test-run/sources/stable/gh/qhapaq-49/rust-hyperloglog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qhapaq-49/rust-hyperloglog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/qhapaq-49/rust-hyperloglog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qhapaq-49/rust-hyperloglog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qhapaq-49/rust-hyperloglog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ab14d2f4309c974f5f080b8707b4cfcef87301d [INFO] sha for GitHub repo qhapaq-49/rust-hyperloglog: 9ab14d2f4309c974f5f080b8707b4cfcef87301d [INFO] validating manifest of qhapaq-49/rust-hyperloglog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qhapaq-49/rust-hyperloglog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qhapaq-49/rust-hyperloglog [INFO] finished frobbing qhapaq-49/rust-hyperloglog [INFO] frobbed toml for qhapaq-49/rust-hyperloglog written to work/ex/clippy-test-run/sources/stable/gh/qhapaq-49/rust-hyperloglog/Cargo.toml [INFO] started frobbing qhapaq-49/rust-hyperloglog [INFO] finished frobbing qhapaq-49/rust-hyperloglog [INFO] frobbed toml for qhapaq-49/rust-hyperloglog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qhapaq-49/rust-hyperloglog/Cargo.toml [INFO] crate qhapaq-49/rust-hyperloglog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qhapaq-49/rust-hyperloglog against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qhapaq-49/rust-hyperloglog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b5b56627eaf54d84b8ee018d14d7c59959583d1692d83b2d856c3672cb6e3f8 [INFO] running `"docker" "start" "-a" "9b5b56627eaf54d84b8ee018d14d7c59959583d1692d83b2d856c3672cb6e3f8"` [INFO] [stderr] Checking hyperloglog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | if e > 1.0/30.0 * 4294967296.0{ [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | e = -4294967296.0 * (1.0 - e/4294967296.0).log2(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | e = -4294967296.0 * (1.0 - e/4294967296.0).log2(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:110:27 [INFO] [stderr] | [INFO] [stderr] 110 | if e > 1.0/30.0 * 4294967296.0{ [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | e = -4294967296.0 * (1.0 - e/4294967296.0).log2(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | e = -4294967296.0 * (1.0 - e/4294967296.0).log2(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4_294_967_296.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | fn hash(&self, str: &String) -> u64; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | fn add(self : &mut Self, str: &String); [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:100 [INFO] [stderr] | [INFO] [stderr] 40 | 128 | 256 | 512 | 1024 | 2048 | 4096 | 8192 | 16384 | 32768 => 0.7213 / (1.0 + 1.079 / (mm as f64)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(mm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | for j in 1..self.m+1{ [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=self.m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | ret += 1.0/2.0f64.powf(self.regs[j as usize] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.regs[j as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | for _ in 0..self.m+1{ [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=self.m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:65 [INFO] [stderr] | [INFO] [stderr] 97 | let mut e = self.alpha(self.m) * self.harmonic_mean() * ((self.m * self.m) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.m * self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | if e <= 2.5f64 * self.m as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:54 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | for j in 1..self.m+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=self.m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | outstr += &atoz[secret..secret+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `secret..=secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | fn hash(&self, str: &String) -> u64; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | fn add(self : &mut Self, str: &String); [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:100 [INFO] [stderr] | [INFO] [stderr] 40 | 128 | 256 | 512 | 1024 | 2048 | 4096 | 8192 | 16384 | 32768 => 0.7213 / (1.0 + 1.079 / (mm as f64)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(mm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | for j in 1..self.m+1{ [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=self.m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | ret += 1.0/2.0f64.powf(self.regs[j as usize] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.regs[j as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | for _ in 0..self.m+1{ [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=self.m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:97:65 [INFO] [stderr] | [INFO] [stderr] 97 | let mut e = self.alpha(self.m) * self.harmonic_mean() * ((self.m * self.m) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.m * self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | if e <= 2.5f64 * self.m as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:54 [INFO] [stderr] | [INFO] [stderr] 107 | e = self.m as f64 * (self.m as f64 / v as f64).ln(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | for j in 1..self.m+1 { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=self.m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | outstr += &atoz[secret..secret+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `secret..=secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "9b5b56627eaf54d84b8ee018d14d7c59959583d1692d83b2d856c3672cb6e3f8"` [INFO] running `"docker" "rm" "-f" "9b5b56627eaf54d84b8ee018d14d7c59959583d1692d83b2d856c3672cb6e3f8"` [INFO] [stdout] 9b5b56627eaf54d84b8ee018d14d7c59959583d1692d83b2d856c3672cb6e3f8