[INFO] updating cached repository qbart/cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/qbart/cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/qbart/cli" "work/ex/clippy-test-run/sources/stable/gh/qbart/cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/qbart/cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/qbart/cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qbart/cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qbart/cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d70d6d686ba41931492060d48acccb36c11d3801 [INFO] sha for GitHub repo qbart/cli: d70d6d686ba41931492060d48acccb36c11d3801 [INFO] validating manifest of qbart/cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qbart/cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qbart/cli [INFO] finished frobbing qbart/cli [INFO] frobbed toml for qbart/cli written to work/ex/clippy-test-run/sources/stable/gh/qbart/cli/Cargo.toml [INFO] started frobbing qbart/cli [INFO] finished frobbing qbart/cli [INFO] frobbed toml for qbart/cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qbart/cli/Cargo.toml [INFO] crate qbart/cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qbart/cli against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/qbart/cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5af3264ccc89917c76f6af47c4ce94d17bd1feacbfb9b23deaf61b012502f16d [INFO] running `"docker" "start" "-a" "5af3264ccc89917c76f6af47c4ce94d17bd1feacbfb9b23deaf61b012502f16d"` [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking colored v1.6.0 [INFO] [stderr] Checking cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tools/rvm.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | if params.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tools/rvm.rs:15:57 [INFO] [stderr] | [INFO] [stderr] 15 | let rvm_params: Vec<&str> = params[0].split("@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tools/rvm.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match file_version.write_all(self.version.as_bytes()) { [INFO] [stderr] 49 | | Err(e) => panic!("Failed to write to file {}: {}", ruby_version_path.display(), e.description()), [INFO] [stderr] 50 | | _ => (), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = file_version.write_all(self.version.as_bytes()) { panic!("Failed to write to file {}: {}", ruby_version_path.display(), e.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tools/rvm.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match file_gemset.write_all(self.gemset.as_bytes()) { [INFO] [stderr] 60 | | Err(e) => panic!("Failed to write to file {}: {}", ruby_gemset_path.display(), e.description()), [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = file_gemset.write_all(self.gemset.as_bytes()) { panic!("Failed to write to file {}: {}", ruby_gemset_path.display(), e.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tools/rvm.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | if params.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tools/rvm.rs:15:57 [INFO] [stderr] | [INFO] [stderr] 15 | let rvm_params: Vec<&str> = params[0].split("@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tools/rvm.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match file_version.write_all(self.version.as_bytes()) { [INFO] [stderr] 49 | | Err(e) => panic!("Failed to write to file {}: {}", ruby_version_path.display(), e.description()), [INFO] [stderr] 50 | | _ => (), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = file_version.write_all(self.version.as_bytes()) { panic!("Failed to write to file {}: {}", ruby_version_path.display(), e.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tools/rvm.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match file_gemset.write_all(self.gemset.as_bytes()) { [INFO] [stderr] 60 | | Err(e) => panic!("Failed to write to file {}: {}", ruby_gemset_path.display(), e.description()), [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = file_gemset.write_all(self.gemset.as_bytes()) { panic!("Failed to write to file {}: {}", ruby_gemset_path.display(), e.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `"docker" "inspect" "5af3264ccc89917c76f6af47c4ce94d17bd1feacbfb9b23deaf61b012502f16d"` [INFO] running `"docker" "rm" "-f" "5af3264ccc89917c76f6af47c4ce94d17bd1feacbfb9b23deaf61b012502f16d"` [INFO] [stdout] 5af3264ccc89917c76f6af47c4ce94d17bd1feacbfb9b23deaf61b012502f16d