[INFO] updating cached repository purpose51/phrases [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/purpose51/phrases [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/purpose51/phrases" "work/ex/clippy-test-run/sources/stable/gh/purpose51/phrases"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/purpose51/phrases'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/purpose51/phrases" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/purpose51/phrases"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/purpose51/phrases'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 004defd47cd7fbade0bb83b6b5460399617a7b45 [INFO] sha for GitHub repo purpose51/phrases: 004defd47cd7fbade0bb83b6b5460399617a7b45 [INFO] validating manifest of purpose51/phrases on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of purpose51/phrases on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing purpose51/phrases [INFO] finished frobbing purpose51/phrases [INFO] frobbed toml for purpose51/phrases written to work/ex/clippy-test-run/sources/stable/gh/purpose51/phrases/Cargo.toml [INFO] started frobbing purpose51/phrases [INFO] finished frobbing purpose51/phrases [INFO] frobbed toml for purpose51/phrases written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/purpose51/phrases/Cargo.toml [INFO] crate purpose51/phrases has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting purpose51/phrases against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/purpose51/phrases:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12898d144f5f52d208cefff0eb5796825065da69dd65d7e12eb347794e0a75b6 [INFO] running `"docker" "start" "-a" "12898d144f5f52d208cefff0eb5796825065da69dd65d7e12eb347794e0a75b6"` [INFO] [stderr] Checking phrases v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/greetings/english.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn hello() -> String { return "hello".to_string(); /* this is easy */ } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"hello".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/greetings/english.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn goodbye() -> String { return "goobye".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"goobye".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:6:32 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn hello() -> String { return "bonjour".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"bonjour".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn goodbye() -> String { return "au revoir".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"au revoir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/greetings/english.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn hello() -> String { return "hello".to_string(); /* this is easy */ } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"hello".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/greetings/english.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn goodbye() -> String { return "goobye".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"goobye".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:6:32 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn hello() -> String { return "bonjour".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"bonjour".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn goodbye() -> String { return "au revoir".to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"au revoir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "12898d144f5f52d208cefff0eb5796825065da69dd65d7e12eb347794e0a75b6"` [INFO] running `"docker" "rm" "-f" "12898d144f5f52d208cefff0eb5796825065da69dd65d7e12eb347794e0a75b6"` [INFO] [stdout] 12898d144f5f52d208cefff0eb5796825065da69dd65d7e12eb347794e0a75b6