[INFO] updating cached repository protoCall7/genetic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/protoCall7/genetic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/protoCall7/genetic" "work/ex/clippy-test-run/sources/stable/gh/protoCall7/genetic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/protoCall7/genetic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/protoCall7/genetic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/protoCall7/genetic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/protoCall7/genetic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07ecb793f904294889cf6bada30528a03789add1 [INFO] sha for GitHub repo protoCall7/genetic: 07ecb793f904294889cf6bada30528a03789add1 [INFO] validating manifest of protoCall7/genetic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of protoCall7/genetic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing protoCall7/genetic [INFO] finished frobbing protoCall7/genetic [INFO] frobbed toml for protoCall7/genetic written to work/ex/clippy-test-run/sources/stable/gh/protoCall7/genetic/Cargo.toml [INFO] started frobbing protoCall7/genetic [INFO] finished frobbing protoCall7/genetic [INFO] frobbed toml for protoCall7/genetic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/protoCall7/genetic/Cargo.toml [INFO] crate protoCall7/genetic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting protoCall7/genetic against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/protoCall7/genetic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ad8d164ea792b11a2490e550dd2c599316721dd91229e253eecb596aca6f472 [INFO] running `"docker" "start" "-a" "2ad8d164ea792b11a2490e550dd2c599316721dd91229e253eecb596aca6f472"` [INFO] [stderr] Checking genetic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:139:3 [INFO] [stderr] | [INFO] [stderr] 139 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:139:3 [INFO] [stderr] | [INFO] [stderr] 139 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:281:2 [INFO] [stderr] | [INFO] [stderr] 281 | return (retstr1, retstr2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retstr1, retstr2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:281:2 [INFO] [stderr] | [INFO] [stderr] 281 | return (retstr1, retstr2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retstr1, retstr2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:56:8 [INFO] [stderr] | [INFO] [stderr] 56 | if operator == false { // looking for an operand [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | match self.parsed_genes[parsed_len - 1] { [INFO] [stderr] | _________^ [INFO] [stderr] 87 | | 10...13 => self.parsed_genes.truncate(parsed_len - 1), [INFO] [stderr] 88 | | _ => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ help: try this: `if let 10...13 = self.parsed_genes[parsed_len - 1] { self.parsed_genes.truncate(parsed_len - 1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | if result == target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | if result == target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:130:4 [INFO] [stderr] | [INFO] [stderr] 130 | match i { [INFO] [stderr] | _____________^ [INFO] [stderr] 131 | | &0...9 => print!("{} ", i), [INFO] [stderr] 132 | | &10 => print!("+ "), [INFO] [stderr] 133 | | &11 => print!("- "), [INFO] [stderr] ... | [INFO] [stderr] 136 | | _ => continue, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *i { [INFO] [stderr] 131 | 0...9 => print!("{} ", i), [INFO] [stderr] 132 | 10 => print!("+ "), [INFO] [stderr] 133 | 11 => print!("- "), [INFO] [stderr] 134 | 12 => print!("* "), [INFO] [stderr] 135 | 13 => print!("/ "), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | 'outer: while found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | 'outer: while found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | if individual.fitness == 999.9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(individual.fitness - 999.9).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | if individual.fitness == 999.9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp_pop` [INFO] [stderr] --> src/main.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | for i in 0..tmp_pop.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for (i, ) in tmp_pop.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:265:2 [INFO] [stderr] | [INFO] [stderr] 265 | let retstr2: String; [INFO] [stderr] | _____^ [INFO] [stderr] 266 | | [INFO] [stderr] 267 | | if tmp_random < CROSSOVER_RATE { [INFO] [stderr] 268 | | tmp_random = rand::random::(); [INFO] [stderr] ... | [INFO] [stderr] 278 | | retstr2 = offspring2; [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let retstr2 = if tmp_random < CROSSOVER_RATE { ..; slice1.to_string() + slice2 } else { ..; offspring2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `genetic`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:56:8 [INFO] [stderr] | [INFO] [stderr] 56 | if operator == false { // looking for an operand [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | match self.parsed_genes[parsed_len - 1] { [INFO] [stderr] | _________^ [INFO] [stderr] 87 | | 10...13 => self.parsed_genes.truncate(parsed_len - 1), [INFO] [stderr] 88 | | _ => {}, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ help: try this: `if let 10...13 = self.parsed_genes[parsed_len - 1] { self.parsed_genes.truncate(parsed_len - 1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | if result == target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(result - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:117:6 [INFO] [stderr] | [INFO] [stderr] 117 | if result == target { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:130:4 [INFO] [stderr] | [INFO] [stderr] 130 | match i { [INFO] [stderr] | _____________^ [INFO] [stderr] 131 | | &0...9 => print!("{} ", i), [INFO] [stderr] 132 | | &10 => print!("+ "), [INFO] [stderr] 133 | | &11 => print!("- "), [INFO] [stderr] ... | [INFO] [stderr] 136 | | _ => continue, [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *i { [INFO] [stderr] 131 | 0...9 => print!("{} ", i), [INFO] [stderr] 132 | 10 => print!("+ "), [INFO] [stderr] 133 | 11 => print!("- "), [INFO] [stderr] 134 | 12 => print!("* "), [INFO] [stderr] 135 | 13 => print!("/ "), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | 'outer: while found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | 'outer: while found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | if individual.fitness == 999.9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(individual.fitness - 999.9).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | if individual.fitness == 999.9 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp_pop` [INFO] [stderr] --> src/main.rs:200:12 [INFO] [stderr] | [INFO] [stderr] 200 | for i in 0..tmp_pop.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for (i, ) in tmp_pop.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:265:2 [INFO] [stderr] | [INFO] [stderr] 265 | let retstr2: String; [INFO] [stderr] | _____^ [INFO] [stderr] 266 | | [INFO] [stderr] 267 | | if tmp_random < CROSSOVER_RATE { [INFO] [stderr] 268 | | tmp_random = rand::random::(); [INFO] [stderr] ... | [INFO] [stderr] 278 | | retstr2 = offspring2; [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let retstr2 = if tmp_random < CROSSOVER_RATE { ..; slice1.to_string() + slice2 } else { ..; offspring2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `genetic`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2ad8d164ea792b11a2490e550dd2c599316721dd91229e253eecb596aca6f472"` [INFO] running `"docker" "rm" "-f" "2ad8d164ea792b11a2490e550dd2c599316721dd91229e253eecb596aca6f472"` [INFO] [stdout] 2ad8d164ea792b11a2490e550dd2c599316721dd91229e253eecb596aca6f472