[INFO] updating cached repository proelbtn/school-calculator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/proelbtn/school-calculator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/proelbtn/school-calculator" "work/ex/clippy-test-run/sources/stable/gh/proelbtn/school-calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/proelbtn/school-calculator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/proelbtn/school-calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/proelbtn/school-calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/proelbtn/school-calculator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8b6aa16c9a7bfa4c04a8ced01f97931d5ade30e [INFO] sha for GitHub repo proelbtn/school-calculator: a8b6aa16c9a7bfa4c04a8ced01f97931d5ade30e [INFO] validating manifest of proelbtn/school-calculator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of proelbtn/school-calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing proelbtn/school-calculator [INFO] finished frobbing proelbtn/school-calculator [INFO] frobbed toml for proelbtn/school-calculator written to work/ex/clippy-test-run/sources/stable/gh/proelbtn/school-calculator/Cargo.toml [INFO] started frobbing proelbtn/school-calculator [INFO] finished frobbing proelbtn/school-calculator [INFO] frobbed toml for proelbtn/school-calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/proelbtn/school-calculator/Cargo.toml [INFO] crate proelbtn/school-calculator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting proelbtn/school-calculator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/proelbtn/school-calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6afde9ecd4b17749772af6a364a1cad0495b745b3313eb709750ba4a19ae5401 [INFO] running `"docker" "start" "-a" "6afde9ecd4b17749772af6a364a1cad0495b745b3313eb709750ba4a19ae5401"` [INFO] [stderr] Checking school-calculator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | return node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | return (Box::new(ASTNode::T(vec)), pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ASTNode::T(vec)), pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | return (Box::new(ASTNode::E(vec)), pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ASTNode::E(vec)), pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return read_statement(tokens, 0).0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_statement(tokens, 0).0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | return node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | return (Box::new(ASTNode::T(vec)), pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ASTNode::T(vec)), pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | return (Box::new(ASTNode::E(vec)), pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Box::new(ASTNode::E(vec)), pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:308:5 [INFO] [stderr] | [INFO] [stderr] 308 | return read_statement(tokens, 0).0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `read_statement(tokens, 0).0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/main.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let mut i = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `val` is never read [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let mut val: f64 = 0.; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match *vec[0] { [INFO] [stderr] 87 | | EElement::T(ref node) => { [INFO] [stderr] 88 | | val = node.eval(); [INFO] [stderr] 89 | | i = 1; [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | _ => (), [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let EElement::T(ref node) = *vec[0] { [INFO] [stderr] 87 | val = node.eval(); [INFO] [stderr] 88 | i = 1; [INFO] [stderr] 89 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | val = val + node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val += node.eval()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | val = val - node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val -= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | val = val * node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | val = val / node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val /= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:183:26 [INFO] [stderr] | [INFO] [stderr] 183 | if !(('0' as u8) <= buf[i] && buf[i] <= ('9' as u8)) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:183:61 [INFO] [stderr] | [INFO] [stderr] 183 | if !(('0' as u8) <= buf[i] && buf[i] <= ('9' as u8)) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'9' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | fn read_number(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | fn read_factor(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | fn read_term(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:254:28 [INFO] [stderr] | [INFO] [stderr] 254 | fn read_expression(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | pos = pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:266:17 [INFO] [stderr] | [INFO] [stderr] 266 | pos = pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:299:27 [INFO] [stderr] | [INFO] [stderr] 299 | fn read_statement(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:307:19 [INFO] [stderr] | [INFO] [stderr] 307 | fn parser(tokens: &Vec) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/main.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let mut i = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `val` is never read [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let mut val: f64 = 0.; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match *vec[0] { [INFO] [stderr] 87 | | EElement::T(ref node) => { [INFO] [stderr] 88 | | val = node.eval(); [INFO] [stderr] 89 | | i = 1; [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | _ => (), [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let EElement::T(ref node) = *vec[0] { [INFO] [stderr] 87 | val = node.eval(); [INFO] [stderr] 88 | i = 1; [INFO] [stderr] 89 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | val = val + node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val += node.eval()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | val = val - node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val -= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | val = val * node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val *= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | val = val / node.eval(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val /= node.eval()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:183:26 [INFO] [stderr] | [INFO] [stderr] 183 | if !(('0' as u8) <= buf[i] && buf[i] <= ('9' as u8)) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:183:61 [INFO] [stderr] | [INFO] [stderr] 183 | if !(('0' as u8) <= buf[i] && buf[i] <= ('9' as u8)) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'9' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | fn read_number(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | fn read_factor(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | fn read_term(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:254:28 [INFO] [stderr] | [INFO] [stderr] 254 | fn read_expression(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | pos = pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:266:17 [INFO] [stderr] | [INFO] [stderr] 266 | pos = pos + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:299:27 [INFO] [stderr] | [INFO] [stderr] 299 | fn read_statement(tokens: &Vec, pos: usize) -> (Box, usize) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:307:19 [INFO] [stderr] | [INFO] [stderr] 307 | fn parser(tokens: &Vec) -> Box { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "6afde9ecd4b17749772af6a364a1cad0495b745b3313eb709750ba4a19ae5401"` [INFO] running `"docker" "rm" "-f" "6afde9ecd4b17749772af6a364a1cad0495b745b3313eb709750ba4a19ae5401"` [INFO] [stdout] 6afde9ecd4b17749772af6a364a1cad0495b745b3313eb709750ba4a19ae5401