[INFO] updating cached repository prewk/subshift [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/prewk/subshift [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/prewk/subshift" "work/ex/clippy-test-run/sources/stable/gh/prewk/subshift"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/prewk/subshift'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/prewk/subshift" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prewk/subshift"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prewk/subshift'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 579454fe5c96e40c5a25c5703de4001c151fb236 [INFO] sha for GitHub repo prewk/subshift: 579454fe5c96e40c5a25c5703de4001c151fb236 [INFO] validating manifest of prewk/subshift on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prewk/subshift on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prewk/subshift [INFO] finished frobbing prewk/subshift [INFO] frobbed toml for prewk/subshift written to work/ex/clippy-test-run/sources/stable/gh/prewk/subshift/Cargo.toml [INFO] started frobbing prewk/subshift [INFO] finished frobbing prewk/subshift [INFO] frobbed toml for prewk/subshift written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prewk/subshift/Cargo.toml [INFO] crate prewk/subshift has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prewk/subshift against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/prewk/subshift:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1479682c187e25df4f229af7bd3682ad76858979d75888d3f7732b2075cf68eb [INFO] running `"docker" "start" "-a" "1479682c187e25df4f229af7bd3682ad76858979d75888d3f7732b2075cf68eb"` [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking subshift v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:153:40 [INFO] [stderr] | [INFO] [stderr] 153 | offset_from.nanosecond() / 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | offset_to.nanosecond() / 1000000 [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | writeln!(std::io::stderr(), "Usage: subshift FILE SECONDS").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | writeln!(std::io::stderr(), "Example: {} subtitle.srt -20", args[0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | writeln!(std::io::stderr(), "Invalid SECONDS format").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | / match capture_id(line) { [INFO] [stderr] 88 | | Some(id) => { [INFO] [stderr] 89 | | next_sub.id = id; [INFO] [stderr] 90 | | [INFO] [stderr] ... | [INFO] [stderr] 93 | | None => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let Some(id) = capture_id(line) { [INFO] [stderr] 88 | next_sub.id = id; [INFO] [stderr] 89 | [INFO] [stderr] 90 | mode = CaptureMode::Range; [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match capture_ranges(line) { [INFO] [stderr] 98 | | Some((from, to)) => { [INFO] [stderr] 99 | | next_sub.from = from; [INFO] [stderr] 100 | | next_sub.to = to; [INFO] [stderr] ... | [INFO] [stderr] 104 | | None => {}, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some((from, to)) = capture_ranges(line) { [INFO] [stderr] 98 | next_sub.from = from; [INFO] [stderr] 99 | next_sub.to = to; [INFO] [stderr] 100 | [INFO] [stderr] 101 | mode = CaptureMode::Texts; [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / match mode { [INFO] [stderr] 132 | | CaptureMode::Texts => { [INFO] [stderr] 133 | | subs.push(Subtitle { [INFO] [stderr] 134 | | id: next_sub.id, [INFO] [stderr] ... | [INFO] [stderr] 140 | | _ => {}, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let CaptureMode::Texts = mode { [INFO] [stderr] 132 | subs.push(Subtitle { [INFO] [stderr] 133 | id: next_sub.id, [INFO] [stderr] 134 | from: next_sub.from, [INFO] [stderr] 135 | to: next_sub.to, [INFO] [stderr] 136 | texts: next_sub.texts, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:153:40 [INFO] [stderr] | [INFO] [stderr] 153 | offset_from.nanosecond() / 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | offset_to.nanosecond() / 1000000 [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | writeln!(std::io::stderr(), "Usage: subshift FILE SECONDS").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | writeln!(std::io::stderr(), "Example: {} subtitle.srt -20", args[0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | writeln!(std::io::stderr(), "Invalid SECONDS format").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | / match capture_id(line) { [INFO] [stderr] 88 | | Some(id) => { [INFO] [stderr] 89 | | next_sub.id = id; [INFO] [stderr] 90 | | [INFO] [stderr] ... | [INFO] [stderr] 93 | | None => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let Some(id) = capture_id(line) { [INFO] [stderr] 88 | next_sub.id = id; [INFO] [stderr] 89 | [INFO] [stderr] 90 | mode = CaptureMode::Range; [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match capture_ranges(line) { [INFO] [stderr] 98 | | Some((from, to)) => { [INFO] [stderr] 99 | | next_sub.from = from; [INFO] [stderr] 100 | | next_sub.to = to; [INFO] [stderr] ... | [INFO] [stderr] 104 | | None => {}, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some((from, to)) = capture_ranges(line) { [INFO] [stderr] 98 | next_sub.from = from; [INFO] [stderr] 99 | next_sub.to = to; [INFO] [stderr] 100 | [INFO] [stderr] 101 | mode = CaptureMode::Texts; [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / match mode { [INFO] [stderr] 132 | | CaptureMode::Texts => { [INFO] [stderr] 133 | | subs.push(Subtitle { [INFO] [stderr] 134 | | id: next_sub.id, [INFO] [stderr] ... | [INFO] [stderr] 140 | | _ => {}, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let CaptureMode::Texts = mode { [INFO] [stderr] 132 | subs.push(Subtitle { [INFO] [stderr] 133 | id: next_sub.id, [INFO] [stderr] 134 | from: next_sub.from, [INFO] [stderr] 135 | to: next_sub.to, [INFO] [stderr] 136 | texts: next_sub.texts, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "1479682c187e25df4f229af7bd3682ad76858979d75888d3f7732b2075cf68eb"` [INFO] running `"docker" "rm" "-f" "1479682c187e25df4f229af7bd3682ad76858979d75888d3f7732b2075cf68eb"` [INFO] [stdout] 1479682c187e25df4f229af7bd3682ad76858979d75888d3f7732b2075cf68eb