[INFO] updating cached repository pontuslaestadius/goliath
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pontuslaestadius/goliath
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pontuslaestadius/goliath" "work/ex/clippy-test-run/sources/stable/gh/pontuslaestadius/goliath"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pontuslaestadius/goliath'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pontuslaestadius/goliath" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontuslaestadius/goliath"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontuslaestadius/goliath'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f264ab5bb7a22fd7795673ef07cb671b01a06713
[INFO] sha for GitHub repo pontuslaestadius/goliath: f264ab5bb7a22fd7795673ef07cb671b01a06713
[INFO] validating manifest of pontuslaestadius/goliath on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pontuslaestadius/goliath on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pontuslaestadius/goliath
[INFO] finished frobbing pontuslaestadius/goliath
[INFO] frobbed toml for pontuslaestadius/goliath written to work/ex/clippy-test-run/sources/stable/gh/pontuslaestadius/goliath/Cargo.toml
[INFO] started frobbing pontuslaestadius/goliath
[INFO] finished frobbing pontuslaestadius/goliath
[INFO] frobbed toml for pontuslaestadius/goliath written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontuslaestadius/goliath/Cargo.toml
[INFO] crate pontuslaestadius/goliath has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pontuslaestadius/goliath against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pontuslaestadius/goliath:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4063a49e93587cd7969da8de6ec5fd5bc0bff66140dcf0b5b00aba1c238f0c4c
[INFO] running `"docker" "start" "-a" "4063a49e93587cd7969da8de6ec5fd5bc0bff66140dcf0b5b00aba1c238f0c4c"`
[INFO] [stderr]     Checking goliath v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::fs::File`
[INFO] [stderr]  --> src/lib.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::fs::File;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/lib.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `index`
[INFO] [stderr]  --> src/lib.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | fn index<'a>(string: &'a mut String) -> Vec<Item<'a>> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_most_valued_sentence`
[INFO] [stderr]   --> src/lib.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | fn get_most_valued_sentence<'a>(string: &'a mut String, vec: Vec<Item>) -> &'a str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_value`
[INFO] [stderr]   --> src/lib.rs:70:1
[INFO] [stderr]    |
[INFO] [stderr] 70 | fn get_value(string: &str) -> usize {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `increase_value`
[INFO] [stderr]   --> src/lib.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     fn increase_value(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_value`
[INFO] [stderr]    --> src/lib.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     fn get_value(&self) -> usize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_key`
[INFO] [stderr]    --> src/lib.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     fn get_key(&self) -> &str {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs::File`
[INFO] [stderr]  --> src/lib.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::fs::File;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:62:29
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = sentence.clone();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = &(*sentence).clone();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = &str::clone(sentence);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `goliath`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/lib.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:147:13
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let mut vec = index(&mut string);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |         let mut vec = index(&mut string);
[INFO] [stderr]     |             ----^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:62:29
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = sentence.clone();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = &(*sentence).clone();
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 62 |             most_valuable = &str::clone(sentence);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:149:20
[INFO] [stderr]     |
[INFO] [stderr] 149 |         assert_eq!(vec.get(0).unwrap().get_value(), item.get_value());
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^ help: try this: `&vec[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `goliath`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4063a49e93587cd7969da8de6ec5fd5bc0bff66140dcf0b5b00aba1c238f0c4c"`
[INFO] running `"docker" "rm" "-f" "4063a49e93587cd7969da8de6ec5fd5bc0bff66140dcf0b5b00aba1c238f0c4c"`
[INFO] [stdout] 4063a49e93587cd7969da8de6ec5fd5bc0bff66140dcf0b5b00aba1c238f0c4c