[INFO] updating cached repository ponchoalv/advent_of_code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ponchoalv/advent_of_code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ponchoalv/advent_of_code" "work/ex/clippy-test-run/sources/stable/gh/ponchoalv/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ponchoalv/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ponchoalv/advent_of_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ponchoalv/advent_of_code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ponchoalv/advent_of_code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e7ce6a4d114264803d2b504f7c520a0e78edc606 [INFO] sha for GitHub repo ponchoalv/advent_of_code: e7ce6a4d114264803d2b504f7c520a0e78edc606 [INFO] validating manifest of ponchoalv/advent_of_code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ponchoalv/advent_of_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ponchoalv/advent_of_code [INFO] finished frobbing ponchoalv/advent_of_code [INFO] frobbed toml for ponchoalv/advent_of_code written to work/ex/clippy-test-run/sources/stable/gh/ponchoalv/advent_of_code/Cargo.toml [INFO] started frobbing ponchoalv/advent_of_code [INFO] finished frobbing ponchoalv/advent_of_code [INFO] frobbed toml for ponchoalv/advent_of_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ponchoalv/advent_of_code/Cargo.toml [INFO] crate ponchoalv/advent_of_code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ponchoalv/advent_of_code against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ponchoalv/advent_of_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cebfbfabba44153c39c04f68ad03675ddebb95f31ed60ababe89653cfd72c231 [INFO] running `"docker" "start" "-a" "cebfbfabba44153c39c04f68ad03675ddebb95f31ed60ababe89653cfd72c231"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_3_2017.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(363010, greater) [INFO] [stderr] | ^^^^^^ help: consider: `363_010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_3_2017.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | let input = 361527; [INFO] [stderr] | ^^^^^^ help: consider: `361_527` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_3_2017.rs:349:17 [INFO] [stderr] | [INFO] [stderr] 349 | let input = 361527; [INFO] [stderr] | ^^^^^^ help: consider: `361_527` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_row_by_name` [INFO] [stderr] --> src/day_7_2017.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / fn get_row_by_name( [INFO] [stderr] 115 | | data: &[(String, usize, Option>)], [INFO] [stderr] 116 | | name: &str, [INFO] [stderr] 117 | | ) -> Option<(String, usize, Option>)> { [INFO] [stderr] ... | [INFO] [stderr] 121 | | .last() [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_descendants` [INFO] [stderr] --> src/day_7_2017.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | / fn get_descendants( [INFO] [stderr] 125 | | data: &[(String, usize, Option>)], [INFO] [stderr] 126 | | name: &str, [INFO] [stderr] 127 | | ) -> Option>)>> { [INFO] [stderr] ... | [INFO] [stderr] 138 | | .collect::>)>>>() [INFO] [stderr] 139 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day_7_2_2017` [INFO] [stderr] --> src/day_7_2017.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn day_7_2_2017(input: &str) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day_7_2017.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|(row_name, _, _)| row_name.to_owned() == name.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `row_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day_7_2017.rs:120:59 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|(row_name, _, _)| row_name.to_owned() == name.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/day_7_2017.rs:127:6 [INFO] [stderr] | [INFO] [stderr] 127 | ) -> Option>)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/day_7_2017.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | .unwrap_or(vec!["".to_owned()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["".to_owned()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day_7_2017.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|(row_name, _, _)| row_name.to_owned() == name.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `row_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day_7_2017.rs:120:59 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|(row_name, _, _)| row_name.to_owned() == name.to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/day_7_2017.rs:127:6 [INFO] [stderr] | [INFO] [stderr] 127 | ) -> Option>)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/day_7_2017.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | .unwrap_or(vec!["".to_owned()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["".to_owned()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "cebfbfabba44153c39c04f68ad03675ddebb95f31ed60ababe89653cfd72c231"` [INFO] running `"docker" "rm" "-f" "cebfbfabba44153c39c04f68ad03675ddebb95f31ed60ababe89653cfd72c231"` [INFO] [stdout] cebfbfabba44153c39c04f68ad03675ddebb95f31ed60ababe89653cfd72c231