[INFO] updating cached repository poiko/nine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/poiko/nine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/poiko/nine" "work/ex/clippy-test-run/sources/stable/gh/poiko/nine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/poiko/nine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/poiko/nine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poiko/nine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poiko/nine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c702fffd4a008a4395bf08298422d066810eb97c [INFO] sha for GitHub repo poiko/nine: c702fffd4a008a4395bf08298422d066810eb97c [INFO] validating manifest of poiko/nine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of poiko/nine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing poiko/nine [INFO] finished frobbing poiko/nine [INFO] frobbed toml for poiko/nine written to work/ex/clippy-test-run/sources/stable/gh/poiko/nine/Cargo.toml [INFO] started frobbing poiko/nine [INFO] finished frobbing poiko/nine [INFO] frobbed toml for poiko/nine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poiko/nine/Cargo.toml [INFO] crate poiko/nine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting poiko/nine against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/poiko/nine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a57cc9d0326045c617e53a5ac48e40ef82ae87a5469268b9c6ad8e5691e3af94 [INFO] running `"docker" "start" "-a" "a57cc9d0326045c617e53a5ac48e40ef82ae87a5469268b9c6ad8e5691e3af94"` [INFO] [stderr] Checking nine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/nes/cpu.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/nes/cpu.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nes/ppu.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | let addr = (self.vram_addr_prev as usize) << 8 + self.vram_addr as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.vram_addr_prev as usize) << (8 + self.vram_addr as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/ppu.rs:68:50 [INFO] [stderr] | [INFO] [stderr] 68 | self.sprite_size = if (val & 0b100000) != 0 { 16 } else { 8 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/ppu.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | self.vblank_nmi = (val & 0b10000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nes/ppu.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | let addr = (self.vram_addr_prev as usize) << 8 + self.vram_addr as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self.vram_addr_prev as usize) << (8 + self.vram_addr as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/ppu.rs:68:50 [INFO] [stderr] | [INFO] [stderr] 68 | self.sprite_size = if (val & 0b100000) != 0 { 16 } else { 8 }; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/ppu.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | self.vblank_nmi = (val & 0b10000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: private type `nes::cpu::Instruction` in public interface (error E0446) [INFO] [stderr] --> src/nes/cpu.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn run_instruction(&mut self, instr: &Instruction) { [INFO] [stderr] 209 | | macro_rules! branch { [INFO] [stderr] 210 | | ($condition: expr, $rel_addr: expr) => [INFO] [stderr] 211 | | (if $condition { [INFO] [stderr] ... | [INFO] [stderr] 550 | | instr.addr_mode, value_hi, value_lo, result); [INFO] [stderr] 551 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:20 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:34 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:41 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:48 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:55 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: private type `nes::cpu::Instruction` in public interface (error E0446) [INFO] [stderr] --> src/nes/cpu.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn run_instruction(&mut self, instr: &Instruction) { [INFO] [stderr] 209 | | macro_rules! branch { [INFO] [stderr] 210 | | ($condition: expr, $rel_addr: expr) => [INFO] [stderr] 211 | | (if $condition { [INFO] [stderr] ... | [INFO] [stderr] 550 | | instr.addr_mode, value_hi, value_lo, result); [INFO] [stderr] 551 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:20 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:34 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:41 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:48 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/nes/cpu.rs:441:55 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INT_IRQ_POS` [INFO] [stderr] --> src/nes/cpu.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const INT_IRQ_POS: usize = 0xfffe; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `page_cycle` [INFO] [stderr] --> src/nes/cpu.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | page_cycle: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_stack` [INFO] [stderr] --> src/nes/cpu.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn print_stack(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spr_ram_addr` [INFO] [stderr] --> src/nes/ppu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | spr_ram_addr: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spr_ram` [INFO] [stderr] --> src/nes/ppu.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | spr_ram: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CHR_BANK_SIZE` [INFO] [stderr] --> src/nes/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub const CHR_BANK_SIZE: usize = 0x2000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRAINER_SIZE` [INFO] [stderr] --> src/nes/mod.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | const TRAINER_SIZE: usize = 512; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INT_IRQ_POS` [INFO] [stderr] --> src/nes/cpu.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const INT_IRQ_POS: usize = 0xfffe; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `page_cycle` [INFO] [stderr] --> src/nes/cpu.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | page_cycle: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_stack` [INFO] [stderr] --> src/nes/cpu.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn print_stack(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spr_ram_addr` [INFO] [stderr] --> src/nes/ppu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | spr_ram_addr: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spr_ram` [INFO] [stderr] --> src/nes/ppu.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | spr_ram: Vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CHR_BANK_SIZE` [INFO] [stderr] --> src/nes/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub const CHR_BANK_SIZE: usize = 0x2000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TRAINER_SIZE` [INFO] [stderr] --> src/nes/mod.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | const TRAINER_SIZE: usize = 512; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | self.ram[addr] as u16 | ((self.ram[addr+1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[addr])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | self.ram[addr] as u16 | ((self.ram[addr+1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[addr+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.read_byte_mapped(addr) as u16 | ((self.read_byte_mapped(addr+1) as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | self.read_byte_mapped(addr) as u16 | ((self.read_byte_mapped(addr+1) as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(addr+1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | self.ram[addr] as u16 | ((self.ram[addr+1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[addr])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | self.ram[addr] as u16 | ((self.ram[addr+1] as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.ram[addr+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.read_byte_mapped(addr) as u16 | ((self.read_byte_mapped(addr+1) as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | self.read_byte_mapped(addr) as u16 | ((self.read_byte_mapped(addr+1) as u16) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(addr+1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:236:49 [INFO] [stderr] | [INFO] [stderr] 236 | self.read_word(pc).wrapping_add(self.x_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.x_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:239:49 [INFO] [stderr] | [INFO] [stderr] 239 | self.read_word(pc).wrapping_add(self.y_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.y_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | (self.read_byte_mapped(ind_addr) as u16 | ((self.read_byte_mapped(ind_addr & 0xff00) as u16) << 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(ind_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:236:49 [INFO] [stderr] | [INFO] [stderr] 236 | self.read_word(pc).wrapping_add(self.x_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.x_reg)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:244:64 [INFO] [stderr] | [INFO] [stderr] 244 | (self.read_byte_mapped(ind_addr) as u16 | ((self.read_byte_mapped(ind_addr & 0xff00) as u16) << 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(ind_addr & 0xff00))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:239:49 [INFO] [stderr] | [INFO] [stderr] 239 | self.read_word(pc).wrapping_add(self.y_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.y_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | self.read_word(ind_addr).wrapping_add(self.y_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.y_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | self.pc_reg += instr.bytes as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instr.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | (self.read_byte_mapped(ind_addr) as u16 | ((self.read_byte_mapped(ind_addr & 0xff00) as u16) << 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(ind_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | self.cycles_run += instr.cycles as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.cycles)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] | [INFO] [stderr] --> src/nes/cpu.rs:244:64 [INFO] [stderr] | [INFO] [stderr] 244 | (self.read_byte_mapped(ind_addr) as u16 | ((self.read_byte_mapped(ind_addr & 0xff00) as u16) << 8)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte_mapped(ind_addr & 0xff00))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/cpu.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | self.read_word(ind_addr).wrapping_add(self.y_reg as u16) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.y_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | self.pc_reg += instr.bytes as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instr.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:261:28 [INFO] [stderr] | [INFO] [stderr] 261 | self.cycles_run += instr.cycles as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(instr.cycles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/cpu.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | 0x81 | 0x85 | 0x8d | 0x91 | 0x95 | 0x99 | 0x9d => { [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:295:36 [INFO] [stderr] | [INFO] [stderr] 295 | self.pc_reg = (self.pc_reg as i32 + rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:295:57 [INFO] [stderr] | [INFO] [stderr] 295 | self.pc_reg = (self.pc_reg as i32 + rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(rel_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:295:36 [INFO] [stderr] | [INFO] [stderr] 295 | self.pc_reg = (self.pc_reg as i32 + rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:329:32 [INFO] [stderr] | [INFO] [stderr] 329 | self.pc_reg = ((value_hi as u16) << 8) | value_lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(value_hi)` [INFO] [stderr] | [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:295:57 [INFO] [stderr] | [INFO] [stderr] 295 | self.pc_reg = (self.pc_reg as i32 + rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(rel_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:329:58 [INFO] [stderr] | [INFO] [stderr] 329 | self.pc_reg = ((value_hi as u16) << 8) | value_lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(value_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:329:32 [INFO] [stderr] | [INFO] [stderr] 329 | self.pc_reg = ((value_hi as u16) << 8) | value_lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(value_hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:329:58 [INFO] [stderr] | [INFO] [stderr] 329 | self.pc_reg = ((value_hi as u16) << 8) | value_lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(value_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:363:35 [INFO] [stderr] | [INFO] [stderr] 363 | let ret_addr_lo = self.pop_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:364:35 [INFO] [stderr] | [INFO] [stderr] 364 | let ret_addr_hi = self.pop_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:370:35 [INFO] [stderr] | [INFO] [stderr] 370 | let mut acc_int = self.acc_reg as i32 + val as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.acc_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:363:35 [INFO] [stderr] | [INFO] [stderr] 363 | let ret_addr_lo = self.pop_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_byte())` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:370:57 [INFO] [stderr] | [INFO] [stderr] 370 | let mut acc_int = self.acc_reg as i32 + val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:364:35 [INFO] [stderr] | [INFO] [stderr] 364 | let ret_addr_hi = self.pop_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:370:35 [INFO] [stderr] | [INFO] [stderr] 370 | let mut acc_int = self.acc_reg as i32 + val as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.acc_reg)` [INFO] [stderr] | [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 448 | branch!(!self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 448 | branch!(!self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 486 | branch!(self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 486 | branch!(self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 513 | branch!(!self.zero, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 513 | branch!(!self.zero, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:521:35 [INFO] [stderr] | [INFO] [stderr] 521 | let mut acc_int = self.acc_reg as i32 - val as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.acc_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:521:57 [INFO] [stderr] | [INFO] [stderr] 521 | let mut acc_int = self.acc_reg as i32 - val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 537 | branch!(self.zero, self.ram[addr] as i8); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 537 | branch!(self.zero, self.ram[addr] as i8); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:370:57 [INFO] [stderr] | [INFO] [stderr] 370 | let mut acc_int = self.acc_reg as i32 + val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 448 | branch!(!self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 448 | branch!(!self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 486 | branch!(self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 486 | branch!(self.carry, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 513 | branch!(!self.zero, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 513 | branch!(!self.zero, self.ram[addr] as i8); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:521:35 [INFO] [stderr] | [INFO] [stderr] 521 | let mut acc_int = self.acc_reg as i32 - val as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.acc_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:521:57 [INFO] [stderr] | [INFO] [stderr] 521 | let mut acc_int = self.acc_reg as i32 - val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.pc_reg)` [INFO] [stderr] ... [INFO] [stderr] 537 | branch!(self.zero, self.ram[addr] as i8); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:212:57 [INFO] [stderr] | [INFO] [stderr] 212 | self.pc_reg = (self.pc_reg as i32 + $rel_addr as i32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[addr] as i8)` [INFO] [stderr] ... [INFO] [stderr] 537 | branch!(self.zero, self.ram[addr] as i8); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/ppu.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | self.background_col = (val >> 5) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(val >> 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | rom.num_prg_banks = file_buf[4] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | rom.num_chr_banks = file_buf[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | rom.mapper_id = ((ctrl2 & 0xf0) | (ctrl1 >> 4)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((ctrl2 & 0xf0) | (ctrl1 >> 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | rom.num_ram_banks = file_buf[8] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/ppu.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | self.background_col = (val >> 5) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(val >> 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | rom.num_prg_banks = file_buf[4] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | rom.num_chr_banks = file_buf[5] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | rom.mapper_id = ((ctrl2 & 0xf0) | (ctrl1 >> 4)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((ctrl2 & 0xf0) | (ctrl1 >> 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | rom.num_ram_banks = file_buf[8] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(file_buf[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "a57cc9d0326045c617e53a5ac48e40ef82ae87a5469268b9c6ad8e5691e3af94"` [INFO] running `"docker" "rm" "-f" "a57cc9d0326045c617e53a5ac48e40ef82ae87a5469268b9c6ad8e5691e3af94"` [INFO] [stdout] a57cc9d0326045c617e53a5ac48e40ef82ae87a5469268b9c6ad8e5691e3af94