[INFO] updating cached repository pmeredit/mysql_test_gen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pmeredit/mysql_test_gen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pmeredit/mysql_test_gen" "work/ex/clippy-test-run/sources/stable/gh/pmeredit/mysql_test_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pmeredit/mysql_test_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pmeredit/mysql_test_gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmeredit/mysql_test_gen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmeredit/mysql_test_gen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] db28ef70826c333bbda653edb9bac7289b1b7a59
[INFO] sha for GitHub repo pmeredit/mysql_test_gen: db28ef70826c333bbda653edb9bac7289b1b7a59
[INFO] validating manifest of pmeredit/mysql_test_gen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pmeredit/mysql_test_gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pmeredit/mysql_test_gen
[INFO] finished frobbing pmeredit/mysql_test_gen
[INFO] frobbed toml for pmeredit/mysql_test_gen written to work/ex/clippy-test-run/sources/stable/gh/pmeredit/mysql_test_gen/Cargo.toml
[INFO] started frobbing pmeredit/mysql_test_gen
[INFO] finished frobbing pmeredit/mysql_test_gen
[INFO] frobbed toml for pmeredit/mysql_test_gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmeredit/mysql_test_gen/Cargo.toml
[INFO] crate pmeredit/mysql_test_gen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pmeredit/mysql_test_gen against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pmeredit/mysql_test_gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b7baaf04c700771ed60152eed0f67824194a0774f0edb4952a092ef4c31ef4a8
[INFO] running `"docker" "start" "-a" "b7baaf04c700771ed60152eed0f67824194a0774f0edb4952a092ef4c31ef4a8"`
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking num-traits v0.1.43
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking time v0.1.39
[INFO] [stderr]     Checking nix v0.9.0
[INFO] [stderr]     Checking net2 v0.2.31
[INFO] [stderr]     Checking yaml-rust v0.4.0
[INFO] [stderr]     Checking thread_local v0.3.5
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking serde_json v1.0.9
[INFO] [stderr]     Checking atoi v0.2.2
[INFO] [stderr]     Checking url v1.7.0
[INFO] [stderr]     Checking num-iter v0.1.35
[INFO] [stderr]     Checking regex v0.2.6
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking rand v0.3.22
[INFO] [stderr]     Checking twox-hash v1.1.0
[INFO] [stderr]     Checking mysql_common v0.5.0
[INFO] [stderr]     Checking mysql v12.2.0
[INFO] [stderr]     Checking mysql_test_gen v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     ()
[INFO] [stderr]     |     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     ()
[INFO] [stderr]     |     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:43:15
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let url = format!("mysql://root@localhost:3306/test");
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mysql://root@localhost:3306/test".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |     for ref table in tables {
[INFO] [stderr]    |         ^^^^^^^^^    ------ help: try: `let table = &tables;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |               if acc == "".to_string() { x }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:76:25
[INFO] [stderr]    |
[INFO] [stderr] 76 |               if acc == "".to_string() { x }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:108:26
[INFO] [stderr]     |
[INFO] [stderr] 108 |                if acc == "".to_string() { x }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:167:25
[INFO] [stderr]     |
[INFO] [stderr] 167 |               if acc == "".to_string() { x }
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:171:10
[INFO] [stderr]     |
[INFO] [stderr] 171 |         .expect(&format!("\nFailed to drop table {}\n", name));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to drop table {}\n", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:174:10
[INFO] [stderr]     |
[INFO] [stderr] 174 |         .expect(&format!("\nFailed to create table {}\n", name));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to create table {}\n", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:175:21
[INFO] [stderr]     |
[INFO] [stderr] 175 |     for row in data.into_iter().skip(1) {
[INFO] [stderr]     |                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:177:83
[INFO] [stderr]     |
[INFO] [stderr] 177 |         pool.prep_exec(format!(r"INSERT INTO {} VALUES({})", name, fmt_data), ()).expect(&format!("\nFailed to insert row: {}\n", fmt_data));
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to insert row: {}\n", fmt_data))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:188:6
[INFO] [stderr]     |
[INFO] [stderr] 188 |     .into_iter()
[INFO] [stderr]     |      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:192:28
[INFO] [stderr]     |
[INFO] [stderr] 192 |             Real(ref r) => format!("{}", r),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `r.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |               if acc == "".to_string() { x }
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:43:15
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let url = format!("mysql://root@localhost:3306/test");
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"mysql://root@localhost:3306/test".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |     for ref table in tables {
[INFO] [stderr]    |         ^^^^^^^^^    ------ help: try: `let table = &tables;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |               if acc == "".to_string() { x }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/main.rs:76:25
[INFO] [stderr]    |
[INFO] [stderr] 76 |               if acc == "".to_string() { x }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:108:26
[INFO] [stderr]     |
[INFO] [stderr] 108 |                if acc == "".to_string() { x }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:167:25
[INFO] [stderr]     |
[INFO] [stderr] 167 |               if acc == "".to_string() { x }
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:171:10
[INFO] [stderr]     |
[INFO] [stderr] 171 |         .expect(&format!("\nFailed to drop table {}\n", name));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to drop table {}\n", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:174:10
[INFO] [stderr]     |
[INFO] [stderr] 174 |         .expect(&format!("\nFailed to create table {}\n", name));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to create table {}\n", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:175:21
[INFO] [stderr]     |
[INFO] [stderr] 175 |     for row in data.into_iter().skip(1) {
[INFO] [stderr]     |                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:177:83
[INFO] [stderr]     |
[INFO] [stderr] 177 |         pool.prep_exec(format!(r"INSERT INTO {} VALUES({})", name, fmt_data), ()).expect(&format!("\nFailed to insert row: {}\n", fmt_data));
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("\nFailed to insert row: {}\n", fmt_data))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:188:6
[INFO] [stderr]     |
[INFO] [stderr] 188 |     .into_iter()
[INFO] [stderr]     |      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:192:28
[INFO] [stderr]     |
[INFO] [stderr] 192 |             Real(ref r) => format!("{}", r),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `r.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/main.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |               if acc == "".to_string() { x }
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 21.72s
[INFO] running `"docker" "inspect" "b7baaf04c700771ed60152eed0f67824194a0774f0edb4952a092ef4c31ef4a8"`
[INFO] running `"docker" "rm" "-f" "b7baaf04c700771ed60152eed0f67824194a0774f0edb4952a092ef4c31ef4a8"`
[INFO] [stdout] b7baaf04c700771ed60152eed0f67824194a0774f0edb4952a092ef4c31ef4a8