[INFO] updating cached repository plumephp/installer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/plumephp/installer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/plumephp/installer" "work/ex/clippy-test-run/sources/stable/gh/plumephp/installer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/plumephp/installer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/plumephp/installer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/plumephp/installer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/plumephp/installer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c239c26e4826860f131b03aa87e66c3f26d7bc8 [INFO] sha for GitHub repo plumephp/installer: 0c239c26e4826860f131b03aa87e66c3f26d7bc8 [INFO] validating manifest of plumephp/installer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plumephp/installer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plumephp/installer [INFO] finished frobbing plumephp/installer [INFO] frobbed toml for plumephp/installer written to work/ex/clippy-test-run/sources/stable/gh/plumephp/installer/Cargo.toml [INFO] started frobbing plumephp/installer [INFO] finished frobbing plumephp/installer [INFO] frobbed toml for plumephp/installer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/plumephp/installer/Cargo.toml [INFO] crate plumephp/installer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plumephp/installer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/plumephp/installer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8bf48a32369def4f0455576ac6beebc48b8c061e15bdffa4e35913ea106da962 [INFO] running `"docker" "start" "-a" "8bf48a32369def4f0455576ac6beebc48b8c061e15bdffa4e35913ea106da962"` [INFO] [stderr] Checking plume-installer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/usage.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | let project_name = args.get("project").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["project"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/helper/usage.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let project_path = current_path + &"/" + project_name; [INFO] [stderr] | ^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/helper/usage.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/helper/usage.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if check_args() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!check_args()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | let project_name = args.get("project").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["project"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | if args.get("new").unwrap() != "new" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["new"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/helper/usage.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if Path::new(path.as_str()).is_dir() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(path.as_str()).is_dir()` [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | let project_name = args.get("project").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["project"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/helper/usage.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let project_path = current_path + &"/" + project_name; [INFO] [stderr] | ^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/helper/usage.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut composer_str = "composer"; [INFO] [stderr] 165 | | [INFO] [stderr] 166 | | if OS == "windows" { [INFO] [stderr] 167 | | composer_str = "composer.bat"; [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let composer_str = if OS == "windows" { "composer.bat" } else { "composer" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/helper/usage.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if check_args() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!check_args()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | let project_name = args.get("project").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["project"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helper/usage.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | if args.get("new").unwrap() != "new" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&args["new"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/helper/usage.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if Path::new(path.as_str()).is_dir() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Path::new(path.as_str()).is_dir()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/helper/usage.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut composer_str = "composer"; [INFO] [stderr] 165 | | [INFO] [stderr] 166 | | if OS == "windows" { [INFO] [stderr] 167 | | composer_str = "composer.bat"; [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let composer_str = if OS == "windows" { "composer.bat" } else { "composer" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "8bf48a32369def4f0455576ac6beebc48b8c061e15bdffa4e35913ea106da962"` [INFO] running `"docker" "rm" "-f" "8bf48a32369def4f0455576ac6beebc48b8c061e15bdffa4e35913ea106da962"` [INFO] [stdout] 8bf48a32369def4f0455576ac6beebc48b8c061e15bdffa4e35913ea106da962