[INFO] updating cached repository planet0104/edge_detection [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/planet0104/edge_detection [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/edge_detection" "work/ex/clippy-test-run/sources/stable/gh/planet0104/edge_detection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/planet0104/edge_detection'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/planet0104/edge_detection" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/edge_detection"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/edge_detection'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 308648b1b6a46ec725779e0a4ee15e608d970ac8 [INFO] sha for GitHub repo planet0104/edge_detection: 308648b1b6a46ec725779e0a4ee15e608d970ac8 [INFO] validating manifest of planet0104/edge_detection on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of planet0104/edge_detection on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing planet0104/edge_detection [INFO] finished frobbing planet0104/edge_detection [INFO] frobbed toml for planet0104/edge_detection written to work/ex/clippy-test-run/sources/stable/gh/planet0104/edge_detection/Cargo.toml [INFO] started frobbing planet0104/edge_detection [INFO] finished frobbing planet0104/edge_detection [INFO] frobbed toml for planet0104/edge_detection written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/edge_detection/Cargo.toml [INFO] crate planet0104/edge_detection has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting planet0104/edge_detection against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/planet0104/edge_detection:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fcaa95b61fc09d8171b2c1e17c0b70bf3299ff98ad2c09ced9503abd0d2ea46 [INFO] running `"docker" "start" "-a" "5fcaa95b61fc09d8171b2c1e17c0b70bf3299ff98ad2c09ced9503abd0d2ea46"` [INFO] [stderr] Checking rgb v0.8.7 [INFO] [stderr] Checking lodepng v2.1.2 [INFO] [stderr] Checking image_contrast v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | fn edge_detection(buffer:&Vec>, width:usize, height:usize, threshold:f32)->Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[RGB]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | fn calc_pixel(pixel:&RGB, out:f32, threshold:f32)->f32{ [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `RGB` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | fn edge_detection(buffer:&Vec>, width:usize, height:usize, threshold:f32)->Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[RGB]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | fn calc_pixel(pixel:&RGB, out:f32, threshold:f32)->f32{ [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `RGB` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | if 0.299*pixel.r as f32+0.587*pixel.g as f32+0.114*pixel.b as f32>threshold{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(pixel.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.17s [INFO] running `"docker" "inspect" "5fcaa95b61fc09d8171b2c1e17c0b70bf3299ff98ad2c09ced9503abd0d2ea46"` [INFO] running `"docker" "rm" "-f" "5fcaa95b61fc09d8171b2c1e17c0b70bf3299ff98ad2c09ced9503abd0d2ea46"` [INFO] [stdout] 5fcaa95b61fc09d8171b2c1e17c0b70bf3299ff98ad2c09ced9503abd0d2ea46