[INFO] updating cached repository pipct/bananagrams-host [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pipct/bananagrams-host [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pipct/bananagrams-host" "work/ex/clippy-test-run/sources/stable/gh/pipct/bananagrams-host"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pipct/bananagrams-host'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pipct/bananagrams-host" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pipct/bananagrams-host"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pipct/bananagrams-host'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3bda27b51c5dbcb19d4c9ea391c0c74e9d87976f [INFO] sha for GitHub repo pipct/bananagrams-host: 3bda27b51c5dbcb19d4c9ea391c0c74e9d87976f [INFO] validating manifest of pipct/bananagrams-host on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pipct/bananagrams-host on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pipct/bananagrams-host [INFO] finished frobbing pipct/bananagrams-host [INFO] frobbed toml for pipct/bananagrams-host written to work/ex/clippy-test-run/sources/stable/gh/pipct/bananagrams-host/Cargo.toml [INFO] started frobbing pipct/bananagrams-host [INFO] finished frobbing pipct/bananagrams-host [INFO] frobbed toml for pipct/bananagrams-host written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pipct/bananagrams-host/Cargo.toml [INFO] crate pipct/bananagrams-host has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pipct/bananagrams-host against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pipct/bananagrams-host:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19fcb4ef09da8216dd589e8f311c84dca7de612c3f2bb7169f323e7e3b3503f1 [INFO] running `"docker" "start" "-a" "19fcb4ef09da8216dd589e8f311c84dca7de612c3f2bb7169f323e7e3b3503f1"` [INFO] [stderr] Checking bananagrams-host v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `GameState` [INFO] [stderr] --> src/main.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_GameState` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ProtocolError` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | ProtocolError, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnexpectedEOF` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | UnexpectedEOF, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LetterError` [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | LetterError [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `readDigit` should have a snake case name such as `read_digit` [INFO] [stderr] --> src/main.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / fn readDigit(chr: u8) -> u8 { [INFO] [stderr] 50 | | if chr < 0x30 || 0x39 < chr { [INFO] [stderr] 51 | | panic!("not a digit: {}", chr); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | chr - 0x30 [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: function `readInt` should have a snake case name such as `read_int` [INFO] [stderr] --> src/main.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / fn readInt(seq: T) -> u64 where T: IntoIterator { [INFO] [stderr] 58 | | seq.into_iter().fold(0, |acc, x| (acc*10) + readDigit(x) as u64) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:49 [INFO] [stderr] | [INFO] [stderr] 58 | seq.into_iter().fold(0, |acc, x| (acc*10) + readDigit(x) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(readDigit(x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `GameState` should have a snake case name such as `game_state` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `GameState` [INFO] [stderr] --> src/main.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_GameState` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ProtocolError` [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | ProtocolError, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UnexpectedEOF` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | UnexpectedEOF, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LetterError` [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | LetterError [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `readDigit` should have a snake case name such as `read_digit` [INFO] [stderr] --> src/main.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / fn readDigit(chr: u8) -> u8 { [INFO] [stderr] 50 | | if chr < 0x30 || 0x39 < chr { [INFO] [stderr] 51 | | panic!("not a digit: {}", chr); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | chr - 0x30 [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: function `readInt` should have a snake case name such as `read_int` [INFO] [stderr] --> src/main.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / fn readInt(seq: T) -> u64 where T: IntoIterator { [INFO] [stderr] 58 | | seq.into_iter().fold(0, |acc, x| (acc*10) + readDigit(x) as u64) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:49 [INFO] [stderr] | [INFO] [stderr] 58 | seq.into_iter().fold(0, |acc, x| (acc*10) + readDigit(x) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(readDigit(x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `GameState` should have a snake case name such as `game_state` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut GameState = GameState::Waiting(vec![false; 5]); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "19fcb4ef09da8216dd589e8f311c84dca7de612c3f2bb7169f323e7e3b3503f1"` [INFO] running `"docker" "rm" "-f" "19fcb4ef09da8216dd589e8f311c84dca7de612c3f2bb7169f323e7e3b3503f1"` [INFO] [stdout] 19fcb4ef09da8216dd589e8f311c84dca7de612c3f2bb7169f323e7e3b3503f1