[INFO] updating cached repository pierrechevalier83/2048-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pierrechevalier83/2048-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pierrechevalier83/2048-rs" "work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/2048-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/2048-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pierrechevalier83/2048-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/2048-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/2048-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8de61e8e0342d54b0ae44b937ecb3952c4d2a94c [INFO] sha for GitHub repo pierrechevalier83/2048-rs: 8de61e8e0342d54b0ae44b937ecb3952c4d2a94c [INFO] validating manifest of pierrechevalier83/2048-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pierrechevalier83/2048-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pierrechevalier83/2048-rs [INFO] finished frobbing pierrechevalier83/2048-rs [INFO] frobbed toml for pierrechevalier83/2048-rs written to work/ex/clippy-test-run/sources/stable/gh/pierrechevalier83/2048-rs/Cargo.toml [INFO] started frobbing pierrechevalier83/2048-rs [INFO] finished frobbing pierrechevalier83/2048-rs [INFO] frobbed toml for pierrechevalier83/2048-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/2048-rs/Cargo.toml [INFO] crate pierrechevalier83/2048-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pierrechevalier83/2048-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pierrechevalier83/2048-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a17747ffc73448c2baf6cac37337f5da62b7b57db5c8f34ac33e857c4dca3b5 [INFO] running `"docker" "start" "-a" "9a17747ffc73448c2baf6cac37337f5da62b7b57db5c8f34ac33e857c4dca3b5"` [INFO] [stderr] Checking termion v1.2.0 [INFO] [stderr] Checking num-complex v0.1.36 [INFO] [stderr] Checking matrix_display v0.3.0 [INFO] [stderr] Checking num-bigint v0.1.36 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking game-2048 v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/display.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / write!(out, [INFO] [stderr] 11 | | "2048-rs [pierrec.tech]{num:>pad$}\r\n", [INFO] [stderr] 12 | | num = score, [INFO] [stderr] 13 | | pad = 11) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/display.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / write!(out, [INFO] [stderr] 11 | | "2048-rs [pierrec.tech]{num:>pad$}\r\n", [INFO] [stderr] 12 | | num = score, [INFO] [stderr] 13 | | pad = 11) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/algorithm.rs:101:15 [INFO] [stderr] | [INFO] [stderr] 101 | let ret = data.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &(*data).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &[i32]::clone(data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/game.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / self.data [INFO] [stderr] 70 | | .chunks_mut(4) [INFO] [stderr] 71 | | .map(|row| { [INFO] [stderr] 72 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 87 | | }) [INFO] [stderr] 88 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/game.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / self.data [INFO] [stderr] 70 | | .chunks_mut(4) [INFO] [stderr] 71 | | .map(|row| { [INFO] [stderr] 72 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 87 | | }) [INFO] [stderr] 88 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-2048`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/algorithm.rs:101:15 [INFO] [stderr] | [INFO] [stderr] 101 | let ret = data.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &(*data).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &[i32]::clone(data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/game.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / self.data [INFO] [stderr] 70 | | .chunks_mut(4) [INFO] [stderr] 71 | | .map(|row| { [INFO] [stderr] 72 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 87 | | }) [INFO] [stderr] 88 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/game.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / self.data [INFO] [stderr] 70 | | .chunks_mut(4) [INFO] [stderr] 71 | | .map(|row| { [INFO] [stderr] 72 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 87 | | }) [INFO] [stderr] 88 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-2048`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9a17747ffc73448c2baf6cac37337f5da62b7b57db5c8f34ac33e857c4dca3b5"` [INFO] running `"docker" "rm" "-f" "9a17747ffc73448c2baf6cac37337f5da62b7b57db5c8f34ac33e857c4dca3b5"` [INFO] [stdout] 9a17747ffc73448c2baf6cac37337f5da62b7b57db5c8f34ac33e857c4dca3b5