[INFO] updating cached repository piatra/minigrep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/piatra/minigrep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/piatra/minigrep" "work/ex/clippy-test-run/sources/stable/gh/piatra/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/piatra/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/piatra/minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piatra/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piatra/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dec19c00c84c3fe9a7516ff2bef862866d0eddcf [INFO] sha for GitHub repo piatra/minigrep: dec19c00c84c3fe9a7516ff2bef862866d0eddcf [INFO] validating manifest of piatra/minigrep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piatra/minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piatra/minigrep [INFO] finished frobbing piatra/minigrep [INFO] frobbed toml for piatra/minigrep written to work/ex/clippy-test-run/sources/stable/gh/piatra/minigrep/Cargo.toml [INFO] started frobbing piatra/minigrep [INFO] finished frobbing piatra/minigrep [INFO] frobbed toml for piatra/minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piatra/minigrep/Cargo.toml [INFO] crate piatra/minigrep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piatra/minigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/piatra/minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b70c1f381738c0fbe62dc242830469c87af5ce23971d9a2a3992ce3f0e7044df [INFO] running `"docker" "start" "-a" "b70c1f381738c0fbe62dc242830469c87af5ce23971d9a2a3992ce3f0e7044df"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | contents.split("\n").filter(|line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:112:20 [INFO] [stderr] | [INFO] [stderr] 112 | contents.split("\n").filter(|line| line.contains(query)).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | if let Err(_) = Config::new(&few_args) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 14 | | assert!(true); [INFO] [stderr] 15 | | } else { [INFO] [stderr] 16 | | assert!(false); [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________- help: try this: `if Config::new(&few_args).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(_) = run(config) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 27 | | assert!(false); [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | assert!(true); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________- help: try this: `if run(config).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | contents.split("\n").filter(|line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:112:20 [INFO] [stderr] | [INFO] [stderr] 112 | contents.split("\n").filter(|line| line.contains(query)).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "b70c1f381738c0fbe62dc242830469c87af5ce23971d9a2a3992ce3f0e7044df"` [INFO] running `"docker" "rm" "-f" "b70c1f381738c0fbe62dc242830469c87af5ce23971d9a2a3992ce3f0e7044df"` [INFO] [stdout] b70c1f381738c0fbe62dc242830469c87af5ce23971d9a2a3992ce3f0e7044df