[INFO] updating cached repository phreaknik/ascii85
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/phreaknik/ascii85
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/phreaknik/ascii85" "work/ex/clippy-test-run/sources/stable/gh/phreaknik/ascii85"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phreaknik/ascii85'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/phreaknik/ascii85" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/ascii85"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/ascii85'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e2cc23f245c641a4296f82cd9cba5a5adb4d7d0d
[INFO] sha for GitHub repo phreaknik/ascii85: e2cc23f245c641a4296f82cd9cba5a5adb4d7d0d
[INFO] validating manifest of phreaknik/ascii85 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of phreaknik/ascii85 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing phreaknik/ascii85
[INFO] finished frobbing phreaknik/ascii85
[INFO] frobbed toml for phreaknik/ascii85 written to work/ex/clippy-test-run/sources/stable/gh/phreaknik/ascii85/Cargo.toml
[INFO] started frobbing phreaknik/ascii85
[INFO] finished frobbing phreaknik/ascii85
[INFO] frobbed toml for phreaknik/ascii85 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/ascii85/Cargo.toml
[INFO] crate phreaknik/ascii85 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting phreaknik/ascii85 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phreaknik/ascii85:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] eb11648d5bbdcc1f3be1595647c9306bd3c73fb22d1f1f00678f88fe6d1bbe55
[INFO] running `"docker" "start" "-a" "eb11648d5bbdcc1f3be1595647c9306bd3c73fb22d1f1f00678f88fe6d1bbe55"`
[INFO] [stderr]     Checking ascii85 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ascii85.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return String::from_utf8(bytes).unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(bytes).unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/ascii85.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |             bytes.push(((n & 0xFF000000) >> 24) as u8);
[INFO] [stderr]    |                              ^^^^^^^^^^ help: consider: `0xFF00_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ascii85.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return String::from_utf8(rad85).unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(rad85).unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ascii85.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return String::from_utf8(bytes).unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(bytes).unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/ascii85.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |             bytes.push(((n & 0xFF000000) >> 24) as u8);
[INFO] [stderr]    |                              ^^^^^^^^^^ help: consider: `0xFF00_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ascii85.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return String::from_utf8(rad85).unwrap_or("".to_string());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(rad85).unwrap_or("".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let mut temp: u32 = w[0] as u32;
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `u32::from(w[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `w`.
[INFO] [stderr]   --> src/ascii85.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for i in 1..w.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for <item> in w.iter().skip(1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 |             temp += w[i] as u32;
[INFO] [stderr]    |                     ^^^^^^^^^^^ help: try: `u32::from(w[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ascii85.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             n = n << 8;
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `n <<= 8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ascii85.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return String::from_utf8(bytes).unwrap_or("".to_string());
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:47:67
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let concat = w.iter().fold(0, |acc: u32, &x| (acc << 8) + (x as u32));
[INFO] [stderr]    |                                                                   ^^^^^^^^^^ help: try: `u32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ascii85.rs:81:37
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return String::from_utf8(rad85).unwrap_or("".to_string());
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let mut temp: u32 = w[0] as u32;
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `u32::from(w[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `w`.
[INFO] [stderr]   --> src/ascii85.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for i in 1..w.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for <item> in w.iter().skip(1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 |             temp += w[i] as u32;
[INFO] [stderr]    |                     ^^^^^^^^^^^ help: try: `u32::from(w[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ascii85.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             n = n << 8;
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `n <<= 8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ascii85.rs:36:37
[INFO] [stderr]    |
[INFO] [stderr] 36 |     return String::from_utf8(bytes).unwrap_or("".to_string());
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/ascii85.rs:47:67
[INFO] [stderr]    |
[INFO] [stderr] 47 |         let concat = w.iter().fold(0, |acc: u32, &x| (acc << 8) + (x as u32));
[INFO] [stderr]    |                                                                   ^^^^^^^^^^ help: try: `u32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ascii85.rs:81:37
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return String::from_utf8(rad85).unwrap_or("".to_string());
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.87s
[INFO] running `"docker" "inspect" "eb11648d5bbdcc1f3be1595647c9306bd3c73fb22d1f1f00678f88fe6d1bbe55"`
[INFO] running `"docker" "rm" "-f" "eb11648d5bbdcc1f3be1595647c9306bd3c73fb22d1f1f00678f88fe6d1bbe55"`
[INFO] [stdout] eb11648d5bbdcc1f3be1595647c9306bd3c73fb22d1f1f00678f88fe6d1bbe55