[INFO] updating cached repository php-coder/gtl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/php-coder/gtl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/php-coder/gtl" "work/ex/clippy-test-run/sources/stable/gh/php-coder/gtl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/php-coder/gtl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/php-coder/gtl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/php-coder/gtl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/php-coder/gtl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3154b56b80dec56a593f1c62d709784f5919fb2f [INFO] sha for GitHub repo php-coder/gtl: 3154b56b80dec56a593f1c62d709784f5919fb2f [INFO] validating manifest of php-coder/gtl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of php-coder/gtl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing php-coder/gtl [INFO] finished frobbing php-coder/gtl [INFO] frobbed toml for php-coder/gtl written to work/ex/clippy-test-run/sources/stable/gh/php-coder/gtl/Cargo.toml [INFO] started frobbing php-coder/gtl [INFO] finished frobbing php-coder/gtl [INFO] frobbed toml for php-coder/gtl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/php-coder/gtl/Cargo.toml [INFO] crate php-coder/gtl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting php-coder/gtl against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/php-coder/gtl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99a1c431747542a36e481cae2a34732a29c352b4acf66ae01351bfabf6b0b5de [INFO] running `"docker" "start" "-a" "99a1c431747542a36e481cae2a34732a29c352b4acf66ae01351bfabf6b0b5de"` [INFO] [stderr] Checking tgl v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let ref tokens: Vec = text_to_tokens("create function main"); [INFO] [stderr] | ----^^^^^^^^^^------------------------------------------------------ help: try: `let tokens: &Vec = &text_to_tokens("create function main");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | writeln!(stderr(), "ERROR: couldn't write to file '{}': {}", file, e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | fn write_str_to_file(filename: &str, text: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | let parts: Vec<&str> = text.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | let parts: Vec<&str> = text.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | .map(|part: &str| Token::new(part)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | let ref tokens: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^-------------------------- help: try: `let tokens: &Vec = &Vec::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let ref tokens: Vec = vec![Token::new("fn"), [INFO] [stderr] | _________- ^^^^^^^^^^ [INFO] [stderr] 164 | | Token::new(" "), [INFO] [stderr] 165 | | Token::new("main"), [INFO] [stderr] 166 | | Token::new("("), [INFO] [stderr] ... | [INFO] [stderr] 170 | | Token::new("\n"), [INFO] [stderr] 171 | | Token::new("}")]; [INFO] [stderr] | |_______________________________________________________- help: try: `let tokens: &Vec = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "99a1c431747542a36e481cae2a34732a29c352b4acf66ae01351bfabf6b0b5de"` [INFO] running `"docker" "rm" "-f" "99a1c431747542a36e481cae2a34732a29c352b4acf66ae01351bfabf6b0b5de"` [INFO] [stdout] 99a1c431747542a36e481cae2a34732a29c352b4acf66ae01351bfabf6b0b5de