[INFO] updating cached repository phonecleaner/cleaner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phonecleaner/cleaner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phonecleaner/cleaner" "work/ex/clippy-test-run/sources/stable/gh/phonecleaner/cleaner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phonecleaner/cleaner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phonecleaner/cleaner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonecleaner/cleaner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonecleaner/cleaner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c3f29051d28659bf06bf71b3d39942f83c56b5ff [INFO] sha for GitHub repo phonecleaner/cleaner: c3f29051d28659bf06bf71b3d39942f83c56b5ff [INFO] validating manifest of phonecleaner/cleaner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phonecleaner/cleaner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phonecleaner/cleaner [INFO] finished frobbing phonecleaner/cleaner [INFO] frobbed toml for phonecleaner/cleaner written to work/ex/clippy-test-run/sources/stable/gh/phonecleaner/cleaner/Cargo.toml [INFO] started frobbing phonecleaner/cleaner [INFO] finished frobbing phonecleaner/cleaner [INFO] frobbed toml for phonecleaner/cleaner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonecleaner/cleaner/Cargo.toml [INFO] crate phonecleaner/cleaner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting phonecleaner/cleaner against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phonecleaner/cleaner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd8b2e72cd97adc7907207b13d1a20f00b5a7dd0f098b9b82970cb9f78d0ad64 [INFO] running `"docker" "start" "-a" "cd8b2e72cd97adc7907207b13d1a20f00b5a7dd0f098b9b82970cb9f78d0ad64"` [INFO] [stderr] Checking siphasher v0.2.2 [INFO] [stderr] Checking simplecss v0.1.0 [INFO] [stderr] Checking float-cmp v0.2.3 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking phf_shared v0.7.21 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Checking svgparser v0.4.0 [INFO] [stderr] Checking svgdom v0.5.0 [INFO] [stderr] Checking svgcleaner v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task/trim_ids.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | let c = (y - (a * x + b)).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | let c = a * x + b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/task/trim_ids.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | let c = (y - (a * x + b)).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/task/paths/conv_segments.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | let c = a * x + b; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/group_by_style.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 177 | | if let Some(s) = start { [INFO] [stderr] 178 | | list.push((s, end)); [INFO] [stderr] 179 | | start = None; [INFO] [stderr] 180 | | end = 0; [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 176 | } else if let Some(s) = start { [INFO] [stderr] 177 | list.push((s, end)); [INFO] [stderr] 178 | start = None; [INFO] [stderr] 179 | end = 0; [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 68 | | if let AttributeValue::PredefValue(id) = attr.value { [INFO] [stderr] 69 | | if id == ValueId::Hidden { [INFO] [stderr] 70 | | rm_list.push(aid); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if let AttributeValue::PredefValue(id) = attr.value { [INFO] [stderr] 68 | if id == ValueId::Hidden { [INFO] [stderr] 69 | rm_list.push(aid); [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | / if tag_name == EId::Text && list.len() == 1 { [INFO] [stderr] 129 | | if list[0] == Length::zero() { [INFO] [stderr] 130 | | return true; [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if tag_name == EId::Text && list.len() == 1 && list[0] == Length::zero() { [INFO] [stderr] 129 | return true; [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | / if tag_name == EId::Circle || tag_name == EId::Ellipse { [INFO] [stderr] 168 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 169 | | return true; [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 167 | if (tag_name == EId::Circle || tag_name == EId::Ellipse) && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 168 | return true; [INFO] [stderr] 169 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | / if tag_name == EId::Marker { [INFO] [stderr] 175 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 176 | | return true; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | if tag_name == EId::Marker && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 175 | return true; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / if tag_name == EId::Line { [INFO] [stderr] 182 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 183 | | return true; [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 181 | if tag_name == EId::Line && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 182 | return true; [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_dupl_defs/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) { [INFO] [stderr] 110 | | if attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 111 | | return false; [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 109 | if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) && attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 110 | return false; [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/rm_needless_attrs.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 213 | | if let Some(v) = node.attribute_value(AId::Stroke) { [INFO] [stderr] 214 | | if v == AttributeValue::PredefValue(ValueId::None) { [INFO] [stderr] 215 | | // Remove all stroke-based attributes, except 'stroke' itself, [INFO] [stderr] ... | [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if let Some(v) = node.attribute_value(AId::Stroke) { [INFO] [stderr] 213 | if v == AttributeValue::PredefValue(ValueId::None) { [INFO] [stderr] 214 | // Remove all stroke-based attributes, except 'stroke' itself, [INFO] [stderr] 215 | // if the stroke is 'none'. [INFO] [stderr] 216 | node.remove_attributes(STROKE_ATTRIBUTES); [INFO] [stderr] 217 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_text_attrs.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / if child.node_type() == NodeType::Text { [INFO] [stderr] 192 | | if is_text_contains_spaces(&child) { [INFO] [stderr] 193 | | has_spaces = true; [INFO] [stderr] 194 | | break; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if child.node_type() == NodeType::Text && is_text_contains_spaces(&child) { [INFO] [stderr] 192 | has_spaces = true; [INFO] [stderr] 193 | break; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_unused_coords.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / if attrs.contains(AId::Rx) { [INFO] [stderr] 52 | | if attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 53 | | rm_list.push(AId::Ry); [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if attrs.contains(AId::Rx) && attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 52 | rm_list.push(AId::Ry); [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / if aid == AId::Opacity { [INFO] [stderr] 138 | | if child.has_attribute(aid) { [INFO] [stderr] 139 | | // We can't just replace 'opacity' attribute, [INFO] [stderr] 140 | | // we should multiply it. [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | if aid == AId::Opacity && child.has_attribute(aid) { [INFO] [stderr] 138 | // We can't just replace 'opacity' attribute, [INFO] [stderr] 139 | // we should multiply it. [INFO] [stderr] 140 | let op1: f64 = *attr.value.as_number().unwrap(); [INFO] [stderr] 141 | let op2: f64 = *child.attribute_value(aid).unwrap() [INFO] [stderr] 142 | .as_number().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / if aid == AId::Transform { [INFO] [stderr] 150 | | if child.has_attribute(aid) { [INFO] [stderr] 151 | | // We should multiply transform matrices. [INFO] [stderr] 152 | | let mut t1 = *attr.value.as_transform().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if aid == AId::Transform && child.has_attribute(aid) { [INFO] [stderr] 150 | // We should multiply transform matrices. [INFO] [stderr] 151 | let mut t1 = *attr.value.as_transform().unwrap(); [INFO] [stderr] 152 | [INFO] [stderr] 153 | let a2 = child.attribute_value(aid).unwrap(); [INFO] [stderr] 154 | let t2 = a2.as_transform().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / if y.fuzzy_eq(&c) { [INFO] [stderr] 204 | | if ( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 205 | | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less) { [INFO] [stderr] 206 | | return true; [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | if y.fuzzy_eq(&c) && (( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 204 | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less)) { [INFO] [stderr] 205 | return true; [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / if options.apply_transform_to_paths { [INFO] [stderr] 46 | | if node.has_attribute(AId::Transform) { [INFO] [stderr] 47 | | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | if options.apply_transform_to_paths && node.has_attribute(AId::Transform) { [INFO] [stderr] 46 | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 47 | [INFO] [stderr] 48 | if ts_utils::is_valid_transform(&tsl) [INFO] [stderr] 49 | && ts_utils::is_valid_attrs(&node) { [INFO] [stderr] 50 | ts = Some(tsl); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/mod.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 119 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 120 | | // Defined in the parent node. [INFO] [stderr] 121 | | n.attribute_value(aid).unwrap() [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 119 | // Defined in the parent node. [INFO] [stderr] 120 | n.attribute_value(aid).unwrap() [INFO] [stderr] 121 | } else { [INFO] [stderr] 122 | // Default value. [INFO] [stderr] 123 | AttributeValue::default_value(aid).unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/mod.rs:142:16 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 143 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 144 | | // Defined in the parent node. [INFO] [stderr] 145 | | Some(n.attribute_value(aid).unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 143 | // Defined in the parent node. [INFO] [stderr] 144 | Some(n.attribute_value(aid).unwrap()) [INFO] [stderr] 145 | } else { [INFO] [stderr] 146 | None [INFO] [stderr] 147 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/group_by_style.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 177 | | if let Some(s) = start { [INFO] [stderr] 178 | | list.push((s, end)); [INFO] [stderr] 179 | | start = None; [INFO] [stderr] 180 | | end = 0; [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 176 | } else if let Some(s) = start { [INFO] [stderr] 177 | list.push((s, end)); [INFO] [stderr] 178 | start = None; [INFO] [stderr] 179 | end = 0; [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 68 | | if let AttributeValue::PredefValue(id) = attr.value { [INFO] [stderr] 69 | | if id == ValueId::Hidden { [INFO] [stderr] 70 | | rm_list.push(aid); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | } else if let AttributeValue::PredefValue(id) = attr.value { [INFO] [stderr] 68 | if id == ValueId::Hidden { [INFO] [stderr] 69 | rm_list.push(aid); [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:128:21 [INFO] [stderr] | [INFO] [stderr] 128 | / if tag_name == EId::Text && list.len() == 1 { [INFO] [stderr] 129 | | if list[0] == Length::zero() { [INFO] [stderr] 130 | | return true; [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if tag_name == EId::Text && list.len() == 1 && list[0] == Length::zero() { [INFO] [stderr] 129 | return true; [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | / if tag_name == EId::Circle || tag_name == EId::Ellipse { [INFO] [stderr] 168 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 169 | | return true; [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 167 | if (tag_name == EId::Circle || tag_name == EId::Ellipse) && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 168 | return true; [INFO] [stderr] 169 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | / if tag_name == EId::Marker { [INFO] [stderr] 175 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 176 | | return true; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | if tag_name == EId::Marker && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 175 | return true; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_default_attrs.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / if tag_name == EId::Line { [INFO] [stderr] 182 | | if attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 183 | | return true; [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 181 | if tag_name == EId::Line && attr.value == AttributeValue::from((0.0, Unit::None)) { [INFO] [stderr] 182 | return true; [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_dupl_defs/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) { [INFO] [stderr] 110 | | if attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 111 | | return false; [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 109 | if attrs1.contains(AId::XlinkHref) && attrs2.contains(AId::XlinkHref) && attrs1.get_value(AId::XlinkHref).unwrap() != attrs2.get_value(AId::XlinkHref).unwrap() { [INFO] [stderr] 110 | return false; [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/rm_needless_attrs.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 213 | | if let Some(v) = node.attribute_value(AId::Stroke) { [INFO] [stderr] 214 | | if v == AttributeValue::PredefValue(ValueId::None) { [INFO] [stderr] 215 | | // Remove all stroke-based attributes, except 'stroke' itself, [INFO] [stderr] ... | [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if let Some(v) = node.attribute_value(AId::Stroke) { [INFO] [stderr] 213 | if v == AttributeValue::PredefValue(ValueId::None) { [INFO] [stderr] 214 | // Remove all stroke-based attributes, except 'stroke' itself, [INFO] [stderr] 215 | // if the stroke is 'none'. [INFO] [stderr] 216 | node.remove_attributes(STROKE_ATTRIBUTES); [INFO] [stderr] 217 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_text_attrs.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | / if child.node_type() == NodeType::Text { [INFO] [stderr] 192 | | if is_text_contains_spaces(&child) { [INFO] [stderr] 193 | | has_spaces = true; [INFO] [stderr] 194 | | break; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | if child.node_type() == NodeType::Text && is_text_contains_spaces(&child) { [INFO] [stderr] 192 | has_spaces = true; [INFO] [stderr] 193 | break; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/rm_unused_coords.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / if attrs.contains(AId::Rx) { [INFO] [stderr] 52 | | if attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 53 | | rm_list.push(AId::Ry); [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if attrs.contains(AId::Rx) && attrs.get_value(AId::Rx) == attrs.get_value(AId::Ry) { [INFO] [stderr] 52 | rm_list.push(AId::Ry); [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / if aid == AId::Opacity { [INFO] [stderr] 138 | | if child.has_attribute(aid) { [INFO] [stderr] 139 | | // We can't just replace 'opacity' attribute, [INFO] [stderr] 140 | | // we should multiply it. [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | if aid == AId::Opacity && child.has_attribute(aid) { [INFO] [stderr] 138 | // We can't just replace 'opacity' attribute, [INFO] [stderr] 139 | // we should multiply it. [INFO] [stderr] 140 | let op1: f64 = *attr.value.as_number().unwrap(); [INFO] [stderr] 141 | let op2: f64 = *child.attribute_value(aid).unwrap() [INFO] [stderr] 142 | .as_number().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/ungroup_groups.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / if aid == AId::Transform { [INFO] [stderr] 150 | | if child.has_attribute(aid) { [INFO] [stderr] 151 | | // We should multiply transform matrices. [INFO] [stderr] 152 | | let mut t1 = *attr.value.as_transform().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if aid == AId::Transform && child.has_attribute(aid) { [INFO] [stderr] 150 | // We should multiply transform matrices. [INFO] [stderr] 151 | let mut t1 = *attr.value.as_transform().unwrap(); [INFO] [stderr] 152 | [INFO] [stderr] 153 | let a2 = child.attribute_value(aid).unwrap(); [INFO] [stderr] 154 | let t2 = a2.as_transform().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/conv_segments.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / if y.fuzzy_eq(&c) { [INFO] [stderr] 204 | | if ( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 205 | | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less) { [INFO] [stderr] 206 | | return true; [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | if y.fuzzy_eq(&c) && (( x.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x2) == Ordering::Less) [INFO] [stderr] 204 | || (x2.fuzzy_cmp(&x1) == Ordering::Greater && x.fuzzy_cmp(&x1) == Ordering::Less)) { [INFO] [stderr] 205 | return true; [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/task/paths/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / if options.apply_transform_to_paths { [INFO] [stderr] 46 | | if node.has_attribute(AId::Transform) { [INFO] [stderr] 47 | | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | if options.apply_transform_to_paths && node.has_attribute(AId::Transform) { [INFO] [stderr] 46 | let tsl = ts_utils::get_ts(&node); [INFO] [stderr] 47 | [INFO] [stderr] 48 | if ts_utils::is_valid_transform(&tsl) [INFO] [stderr] 49 | && ts_utils::is_valid_attrs(&node) { [INFO] [stderr] 50 | ts = Some(tsl); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/mod.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 119 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 120 | | // Defined in the parent node. [INFO] [stderr] 121 | | n.attribute_value(aid).unwrap() [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 118 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 119 | // Defined in the parent node. [INFO] [stderr] 120 | n.attribute_value(aid).unwrap() [INFO] [stderr] 121 | } else { [INFO] [stderr] 122 | // Default value. [INFO] [stderr] 123 | AttributeValue::default_value(aid).unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/task/mod.rs:142:16 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 143 | | if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 144 | | // Defined in the parent node. [INFO] [stderr] 145 | | Some(n.attribute_value(aid).unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if let Some(n) = node.parents().find(|n| n.has_attribute(aid)) { [INFO] [stderr] 143 | // Defined in the parent node. [INFO] [stderr] 144 | Some(n.attribute_value(aid).unwrap()) [INFO] [stderr] 145 | } else { [INFO] [stderr] 146 | None [INFO] [stderr] 147 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/cli.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | / writeln!(stderr(), "Error: You can use '--{}=true' only with '--{}=true'.", [INFO] [stderr] 337 | | KEYS[dep], KEYS[flag]).unwrap(); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/cleaner.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn clean_doc(doc: &Document, options: &Options, opt: &WriteOptions) [INFO] [stderr] 58 | | -> Result<(), error::Error> { [INFO] [stderr] 59 | | preclean_checks(doc)?; [INFO] [stderr] 60 | | [INFO] [stderr] ... | [INFO] [stderr] 233 | | Ok(()) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if f[idx] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `f[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/task/rm_default_attrs.rs:203:32 [INFO] [stderr] | [INFO] [stderr] 203 | } else if v == "1" { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 204 | | return true; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/task/rm_default_attrs.rs:201:54 [INFO] [stderr] | [INFO] [stderr] 201 | if tag_name == EId::FontFace && v == "0" { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 202 | | return true; [INFO] [stderr] 203 | | } else if v == "1" { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/trim_ids.rs:62:43 [INFO] [stderr] | [INFO] [stderr] 62 | fn shift(&mut self, pos: usize, head: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | / match attr.value { [INFO] [stderr] 88 | | AttributeValue::Transform(ref mut ts) => { [INFO] [stderr] 89 | | round_number(&mut ts.a, ts_precision); [INFO] [stderr] 90 | | round_number(&mut ts.b, ts_precision); [INFO] [stderr] ... | [INFO] [stderr] 96 | | _ => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let AttributeValue::Transform(ref mut ts) = attr.value { [INFO] [stderr] 88 | round_number(&mut ts.a, ts_precision); [INFO] [stderr] 89 | round_number(&mut ts.b, ts_precision); [INFO] [stderr] 90 | round_number(&mut ts.c, ts_precision); [INFO] [stderr] 91 | round_number(&mut ts.d, ts_precision); [INFO] [stderr] 92 | round_number(&mut ts.e, coord_precision); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | / match attr.value { [INFO] [stderr] 102 | | AttributeValue::Path(ref mut p) => { [INFO] [stderr] 103 | | round_path(p, paths_precision); [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let AttributeValue::Path(ref mut p) = attr.value { [INFO] [stderr] 102 | round_path(p, paths_precision); [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | / match attr.value { [INFO] [stderr] 112 | | AttributeValue::NumberList(ref mut list) => { [INFO] [stderr] 113 | | for n in list.iter_mut() { [INFO] [stderr] 114 | | round_number(n, paths_precision); [INFO] [stderr] ... | [INFO] [stderr] 117 | | _ => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let AttributeValue::NumberList(ref mut list) = attr.value { [INFO] [stderr] 112 | for n in list.iter_mut() { [INFO] [stderr] 113 | round_number(n, paths_precision); [INFO] [stderr] 114 | } [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/apply_transforms/mod.rs:135:72 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn scale_coord(attrs: &mut Attributes, aid: AId, scale_factor: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/paths/conv_segments.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match *curr_seg.data() { [INFO] [stderr] 110 | | SegmentData::CurveTo { x1, y1, x2, y2, x, y } => { [INFO] [stderr] 111 | | let is_vlineto = || { [INFO] [stderr] 112 | | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => {} [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let SegmentData::CurveTo { x1, y1, x2, y2, x, y } = *curr_seg.data() { [INFO] [stderr] 110 | let is_vlineto = || { [INFO] [stderr] 111 | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] 112 | // y1 must be equal or greater than prev_y. [INFO] [stderr] 113 | // y2 must be equal or less than y. [INFO] [stderr] 114 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svgcleaner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/cli.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | / writeln!(stderr(), "Error: You can use '--{}=true' only with '--{}=true'.", [INFO] [stderr] 337 | | KEYS[dep], KEYS[flag]).unwrap(); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/cleaner.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn clean_doc(doc: &Document, options: &Options, opt: &WriteOptions) [INFO] [stderr] 58 | | -> Result<(), error::Error> { [INFO] [stderr] 59 | | preclean_checks(doc)?; [INFO] [stderr] 60 | | [INFO] [stderr] ... | [INFO] [stderr] 233 | | Ok(()) [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if f[idx] == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `f[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/task/group_by_style.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | if *f == true { [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/task/rm_default_attrs.rs:203:32 [INFO] [stderr] | [INFO] [stderr] 203 | } else if v == "1" { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 204 | | return true; [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/task/rm_default_attrs.rs:201:54 [INFO] [stderr] | [INFO] [stderr] 201 | if tag_name == EId::FontFace && v == "0" { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 202 | | return true; [INFO] [stderr] 203 | | } else if v == "1" { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/trim_ids.rs:62:43 [INFO] [stderr] | [INFO] [stderr] 62 | fn shift(&mut self, pos: usize, head: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | / match attr.value { [INFO] [stderr] 88 | | AttributeValue::Transform(ref mut ts) => { [INFO] [stderr] 89 | | round_number(&mut ts.a, ts_precision); [INFO] [stderr] 90 | | round_number(&mut ts.b, ts_precision); [INFO] [stderr] ... | [INFO] [stderr] 96 | | _ => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let AttributeValue::Transform(ref mut ts) = attr.value { [INFO] [stderr] 88 | round_number(&mut ts.a, ts_precision); [INFO] [stderr] 89 | round_number(&mut ts.b, ts_precision); [INFO] [stderr] 90 | round_number(&mut ts.c, ts_precision); [INFO] [stderr] 91 | round_number(&mut ts.d, ts_precision); [INFO] [stderr] 92 | round_number(&mut ts.e, coord_precision); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | / match attr.value { [INFO] [stderr] 102 | | AttributeValue::Path(ref mut p) => { [INFO] [stderr] 103 | | round_path(p, paths_precision); [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let AttributeValue::Path(ref mut p) = attr.value { [INFO] [stderr] 102 | round_path(p, paths_precision); [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/round_numbers.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | / match attr.value { [INFO] [stderr] 112 | | AttributeValue::NumberList(ref mut list) => { [INFO] [stderr] 113 | | for n in list.iter_mut() { [INFO] [stderr] 114 | | round_number(n, paths_precision); [INFO] [stderr] ... | [INFO] [stderr] 117 | | _ => {} [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let AttributeValue::NumberList(ref mut list) = attr.value { [INFO] [stderr] 112 | for n in list.iter_mut() { [INFO] [stderr] 113 | round_number(n, paths_precision); [INFO] [stderr] 114 | } [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/task/apply_transforms/mod.rs:135:72 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn scale_coord(attrs: &mut Attributes, aid: AId, scale_factor: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task/paths/conv_segments.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match *curr_seg.data() { [INFO] [stderr] 110 | | SegmentData::CurveTo { x1, y1, x2, y2, x, y } => { [INFO] [stderr] 111 | | let is_vlineto = || { [INFO] [stderr] 112 | | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => {} [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let SegmentData::CurveTo { x1, y1, x2, y2, x, y } = *curr_seg.data() { [INFO] [stderr] 110 | let is_vlineto = || { [INFO] [stderr] 111 | // If prev_x, x1, x2 and x are equal than this CurveTo is VerticalLineTo. [INFO] [stderr] 112 | // y1 must be equal or greater than prev_y. [INFO] [stderr] 113 | // y2 must be equal or less than y. [INFO] [stderr] 114 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svgcleaner`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cd8b2e72cd97adc7907207b13d1a20f00b5a7dd0f098b9b82970cb9f78d0ad64"` [INFO] running `"docker" "rm" "-f" "cd8b2e72cd97adc7907207b13d1a20f00b5a7dd0f098b9b82970cb9f78d0ad64"` [INFO] [stdout] cd8b2e72cd97adc7907207b13d1a20f00b5a7dd0f098b9b82970cb9f78d0ad64