[INFO] updating cached repository phigley/wfc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/phigley/wfc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/phigley/wfc" "work/ex/clippy-test-run/sources/stable/gh/phigley/wfc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/phigley/wfc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/phigley/wfc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phigley/wfc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phigley/wfc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afd2a58416ade3897929863ff0069575e42b0c42 [INFO] sha for GitHub repo phigley/wfc: afd2a58416ade3897929863ff0069575e42b0c42 [INFO] validating manifest of phigley/wfc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of phigley/wfc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing phigley/wfc [INFO] finished frobbing phigley/wfc [INFO] frobbed toml for phigley/wfc written to work/ex/clippy-test-run/sources/stable/gh/phigley/wfc/Cargo.toml [INFO] started frobbing phigley/wfc [INFO] finished frobbing phigley/wfc [INFO] frobbed toml for phigley/wfc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phigley/wfc/Cargo.toml [INFO] crate phigley/wfc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting phigley/wfc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/phigley/wfc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8083fc60a5568ba994659efb958cfb4ff83b9f4396e81e7b3cc4d0d7372626df [INFO] running `"docker" "start" "-a" "8083fc60a5568ba994659efb958cfb4ff83b9f4396e81e7b3cc4d0d7372626df"` [INFO] [stderr] Checking wfc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/field.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 102 | | if self.invalidate_step[p] > self.max_invalidate_step { [INFO] [stderr] 103 | | self.max_invalidate_step = self.invalidate_step[p]; [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | } else if self.invalidate_step[p] > self.max_invalidate_step { [INFO] [stderr] 102 | self.max_invalidate_step = self.invalidate_step[p]; [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/field.rs:610:17 [INFO] [stderr] | [INFO] [stderr] 610 | / if source_point.allowed[source_index] { [INFO] [stderr] 611 | | if potentials[source_index].fits(&potentials[test_index], direction) { [INFO] [stderr] 612 | | fits = true; [INFO] [stderr] 613 | | break; [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 610 | if source_point.allowed[source_index] && potentials[source_index].fits(&potentials[test_index], direction) { [INFO] [stderr] 611 | fits = true; [INFO] [stderr] 612 | break; [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/field.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 102 | | if self.invalidate_step[p] > self.max_invalidate_step { [INFO] [stderr] 103 | | self.max_invalidate_step = self.invalidate_step[p]; [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | } else if self.invalidate_step[p] > self.max_invalidate_step { [INFO] [stderr] 102 | self.max_invalidate_step = self.invalidate_step[p]; [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/field.rs:610:17 [INFO] [stderr] | [INFO] [stderr] 610 | / if source_point.allowed[source_index] { [INFO] [stderr] 611 | | if potentials[source_index].fits(&potentials[test_index], direction) { [INFO] [stderr] 612 | | fits = true; [INFO] [stderr] 613 | | break; [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 610 | if source_point.allowed[source_index] && potentials[source_index].fits(&potentials[test_index], direction) { [INFO] [stderr] 611 | fits = true; [INFO] [stderr] 612 | break; [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/boundary.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | fn to_index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/boundary.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | fn to_opposite_index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/boundary.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn from_str(borders: &str) -> Result { [INFO] [stderr] 64 | | if borders.len() != 11 { [INFO] [stderr] 65 | | Err(format!( [INFO] [stderr] 66 | | "Boundary::from_str(\"{}\") is incorrect. Input length is {}, expected 11.", [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boundary.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | if *c == ('1' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boundary.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | } else if *c != ('0' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/main.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | if true || field.close_edges() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if true || field.close_edges() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if field.step(&mut rng) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!field.step(&mut rng)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wfc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/build_box.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `wfc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/main.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | if true || field.close_edges() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if true || field.close_edges() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if field.step(&mut rng) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!field.step(&mut rng)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wfc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/field.rs:701:5 [INFO] [stderr] | [INFO] [stderr] 701 | / fn revert_fieldpoint() { [INFO] [stderr] 702 | | let mut f0 = FieldPoint::new(3); [INFO] [stderr] 703 | | [INFO] [stderr] 704 | | assert_eq!(f0.allowed[0], true); [INFO] [stderr] ... | [INFO] [stderr] 765 | | assert_eq!(f0.max_invalidate_step, None); [INFO] [stderr] 766 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/boundary.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | fn to_index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/boundary.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | fn to_opposite_index(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/boundary.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn from_str(borders: &str) -> Result { [INFO] [stderr] 64 | | if borders.len() != 11 { [INFO] [stderr] 65 | | Err(format!( [INFO] [stderr] 66 | | "Boundary::from_str(\"{}\") is incorrect. Input length is {}, expected 11.", [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boundary.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | if *c == ('1' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'1' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boundary.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | } else if *c != ('0' as u8) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8083fc60a5568ba994659efb958cfb4ff83b9f4396e81e7b3cc4d0d7372626df"` [INFO] running `"docker" "rm" "-f" "8083fc60a5568ba994659efb958cfb4ff83b9f4396e81e7b3cc4d0d7372626df"` [INFO] [stdout] 8083fc60a5568ba994659efb958cfb4ff83b9f4396e81e7b3cc4d0d7372626df