[INFO] updating cached repository pgorczak/swat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pgorczak/swat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pgorczak/swat" "work/ex/clippy-test-run/sources/stable/gh/pgorczak/swat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pgorczak/swat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pgorczak/swat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pgorczak/swat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pgorczak/swat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a1764fc0483d74a0e4b117807ad0ea06a3be04f5
[INFO] sha for GitHub repo pgorczak/swat: a1764fc0483d74a0e4b117807ad0ea06a3be04f5
[INFO] validating manifest of pgorczak/swat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pgorczak/swat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pgorczak/swat
[INFO] finished frobbing pgorczak/swat
[INFO] frobbed toml for pgorczak/swat written to work/ex/clippy-test-run/sources/stable/gh/pgorczak/swat/Cargo.toml
[INFO] started frobbing pgorczak/swat
[INFO] finished frobbing pgorczak/swat
[INFO] frobbed toml for pgorczak/swat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pgorczak/swat/Cargo.toml
[INFO] crate pgorczak/swat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pgorczak/swat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pgorczak/swat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ee1da6a4d38221de37d5295da7f4d1bf7e53551f4625bdb9de92200ec38f4c34
[INFO] running `"docker" "start" "-a" "ee1da6a4d38221de37d5295da7f4d1bf7e53551f4625bdb9de92200ec38f4c34"`
[INFO] [stderr]     Checking encode_unicode v0.1.3
[INFO] [stderr]     Checking ioctl-rs v0.1.6
[INFO] [stderr]     Checking termios v0.2.2
[INFO] [stderr]     Checking serial-core v0.4.0
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking clap v2.30.0
[INFO] [stderr]     Checking serial-unix v0.4.0
[INFO] [stderr]     Checking serial v0.4.0
[INFO] [stderr]     Checking rustyline v1.0.0
[INFO] [stderr]     Checking swat v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/device.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return (send_cmd, receive_result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(send_cmd, receive_result)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/repl.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return recv.recv().unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recv.recv().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/device.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return (send_cmd, receive_result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(send_cmd, receive_result)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/repl.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return recv.recv().unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `recv.recv().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/repl.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     loop {
[INFO] [stderr] 32 | |         match rl.readline(&prompt) {
[INFO] [stderr] 33 | |             Ok(line) => {rl.add_history_entry(&line);
[INFO] [stderr] 34 | |                          print(eval(&line))},
[INFO] [stderr] 35 | |             Err(_)   => break,
[INFO] [stderr] 36 | |         }
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Ok(line) = rl.readline(&prompt) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/repl.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     loop {
[INFO] [stderr] 32 | |         match rl.readline(&prompt) {
[INFO] [stderr] 33 | |             Ok(line) => {rl.add_history_entry(&line);
[INFO] [stderr] 34 | |                          print(eval(&line))},
[INFO] [stderr] 35 | |             Err(_)   => break,
[INFO] [stderr] 36 | |         }
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Ok(line) = rl.readline(&prompt) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.41s
[INFO] running `"docker" "inspect" "ee1da6a4d38221de37d5295da7f4d1bf7e53551f4625bdb9de92200ec38f4c34"`
[INFO] running `"docker" "rm" "-f" "ee1da6a4d38221de37d5295da7f4d1bf7e53551f4625bdb9de92200ec38f4c34"`
[INFO] [stdout] ee1da6a4d38221de37d5295da7f4d1bf7e53551f4625bdb9de92200ec38f4c34