[INFO] updating cached repository peterpaul/rust-raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peterpaul/rust-raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peterpaul/rust-raytracer" "work/ex/clippy-test-run/sources/stable/gh/peterpaul/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peterpaul/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peterpaul/rust-raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterpaul/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterpaul/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 01bfff931c979bc8495bb5636f62a11f86db8589 [INFO] sha for GitHub repo peterpaul/rust-raytracer: 01bfff931c979bc8495bb5636f62a11f86db8589 [INFO] validating manifest of peterpaul/rust-raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peterpaul/rust-raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peterpaul/rust-raytracer [INFO] finished frobbing peterpaul/rust-raytracer [INFO] frobbed toml for peterpaul/rust-raytracer written to work/ex/clippy-test-run/sources/stable/gh/peterpaul/rust-raytracer/Cargo.toml [INFO] started frobbing peterpaul/rust-raytracer [INFO] finished frobbing peterpaul/rust-raytracer [INFO] frobbed toml for peterpaul/rust-raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterpaul/rust-raytracer/Cargo.toml [INFO] crate peterpaul/rust-raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peterpaul/rust-raytracer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterpaul/rust-raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f428c05f3cb2e4733f14de1b2135dfe1e4778135fc1840b5ac2ef96b3932ea79 [INFO] running `"docker" "start" "-a" "f428c05f3cb2e4733f14de1b2135dfe1e4778135fc1840b5ac2ef96b3932ea79"` [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / return if disc < 0.0 { [INFO] [stderr] 62 | | f64::INFINITY [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | let d: f64 = disc.sqrt(); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | if disc < 0.0 { [INFO] [stderr] 62 | f64::INFINITY [INFO] [stderr] 63 | } else { [INFO] [stderr] 64 | let d: f64 = disc.sqrt(); [INFO] [stderr] 65 | let t2: f64 = b + d; [INFO] [stderr] 66 | if t2 < 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / return if l >= i.lambda { [INFO] [stderr] 84 | | i.clone() [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | let n: Vector3d = ray.orig + ray.dir * l - self.center; [INFO] [stderr] 87 | | Hit::new(l, n.normalize(), self.color) [INFO] [stderr] 88 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | if l >= i.lambda { [INFO] [stderr] 84 | i.clone() [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | let n: Vector3d = ray.orig + ray.dir * l - self.center; [INFO] [stderr] 87 | Hit::new(l, n.normalize(), self.color) [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / return if disc < 0.0 { [INFO] [stderr] 96 | | false [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | b + disc.sqrt() >= 0.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | if disc < 0.0 { [INFO] [stderr] 96 | false [INFO] [stderr] 97 | } else { [INFO] [stderr] 98 | b + disc.sqrt() >= 0.0 [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / return if l >= i.lambda { [INFO] [stderr] 136 | | i.clone() [INFO] [stderr] 137 | | } else { [INFO] [stderr] 138 | | let mut out: Hit = i.clone(); [INFO] [stderr] ... | [INFO] [stderr] 142 | | out [INFO] [stderr] 143 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | if l >= i.lambda { [INFO] [stderr] 136 | i.clone() [INFO] [stderr] 137 | } else { [INFO] [stderr] 138 | let mut out: Hit = i.clone(); [INFO] [stderr] 139 | for scene in &self.objects { [INFO] [stderr] 140 | out = scene.intersect(&out, ray); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Box::new(Group::new(objects, ZERO)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(Group::new(objects, ZERO))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / return if disc < 0.0 { [INFO] [stderr] 62 | | f64::INFINITY [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | let d: f64 = disc.sqrt(); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | if disc < 0.0 { [INFO] [stderr] 62 | f64::INFINITY [INFO] [stderr] 63 | } else { [INFO] [stderr] 64 | let d: f64 = disc.sqrt(); [INFO] [stderr] 65 | let t2: f64 = b + d; [INFO] [stderr] 66 | if t2 < 0.0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / return if l >= i.lambda { [INFO] [stderr] 84 | | i.clone() [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | let n: Vector3d = ray.orig + ray.dir * l - self.center; [INFO] [stderr] 87 | | Hit::new(l, n.normalize(), self.color) [INFO] [stderr] 88 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | if l >= i.lambda { [INFO] [stderr] 84 | i.clone() [INFO] [stderr] 85 | } else { [INFO] [stderr] 86 | let n: Vector3d = ray.orig + ray.dir * l - self.center; [INFO] [stderr] 87 | Hit::new(l, n.normalize(), self.color) [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / return if disc < 0.0 { [INFO] [stderr] 96 | | false [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | b + disc.sqrt() >= 0.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | if disc < 0.0 { [INFO] [stderr] 96 | false [INFO] [stderr] 97 | } else { [INFO] [stderr] 98 | b + disc.sqrt() >= 0.0 [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / return if l >= i.lambda { [INFO] [stderr] 136 | | i.clone() [INFO] [stderr] 137 | | } else { [INFO] [stderr] 138 | | let mut out: Hit = i.clone(); [INFO] [stderr] ... | [INFO] [stderr] 142 | | out [INFO] [stderr] 143 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | if l >= i.lambda { [INFO] [stderr] 136 | i.clone() [INFO] [stderr] 137 | } else { [INFO] [stderr] 138 | let mut out: Hit = i.clone(); [INFO] [stderr] 139 | for scene in &self.objects { [INFO] [stderr] 140 | out = scene.intersect(&out, ray); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Box::new(Group::new(objects, ZERO)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(Group::new(objects, ZERO))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | i.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | fn bounding_box(objects: &Vec>) -> (Vector3d, Vector3d) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | i.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:138:32 [INFO] [stderr] | [INFO] [stderr] 138 | let mut out: Hit = i.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:205:50 [INFO] [stderr] | [INFO] [stderr] 205 | let c2: Vector3d = c + Vector3d::new(dx as f64, 1.0, dz as f64) * (rn); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:205:66 [INFO] [stderr] | [INFO] [stderr] 205 | let c2: Vector3d = c + Vector3d::new(dx as f64, 1.0, dz as f64) * (rn); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:37 [INFO] [stderr] | [INFO] [stderr] 215 | let color_scale: f64 = 255.0 / (ss as f64 * ss as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:49 [INFO] [stderr] | [INFO] [stderr] 215 | let color_scale: f64 = 255.0 / (ss as f64 * ss as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:36 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:48 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:60 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:60 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | n as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | i.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | fn bounding_box(objects: &Vec>) -> (Vector3d, Vector3d) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | i.clone() [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:138:32 [INFO] [stderr] | [INFO] [stderr] 138 | let mut out: Hit = i.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:205:50 [INFO] [stderr] | [INFO] [stderr] 205 | let c2: Vector3d = c + Vector3d::new(dx as f64, 1.0, dz as f64) * (rn); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:205:66 [INFO] [stderr] | [INFO] [stderr] 205 | let c2: Vector3d = c + Vector3d::new(dx as f64, 1.0, dz as f64) * (rn); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:37 [INFO] [stderr] | [INFO] [stderr] 215 | let color_scale: f64 = 255.0 / (ss as f64 * ss as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:49 [INFO] [stderr] | [INFO] [stderr] 215 | let color_scale: f64 = 255.0 / (ss as f64 * ss as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:36 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:48 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:230:60 [INFO] [stderr] | [INFO] [stderr] 230 | x as f64 + dx as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(dy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ss)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:60 [INFO] [stderr] | [INFO] [stderr] 231 | y as f64 + dy as f64 / ss as f64 - n as f64 * 0.5, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | n as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "f428c05f3cb2e4733f14de1b2135dfe1e4778135fc1840b5ac2ef96b3932ea79"` [INFO] running `"docker" "rm" "-f" "f428c05f3cb2e4733f14de1b2135dfe1e4778135fc1840b5ac2ef96b3932ea79"` [INFO] [stdout] f428c05f3cb2e4733f14de1b2135dfe1e4778135fc1840b5ac2ef96b3932ea79