[INFO] updating cached repository peterheesterman/ferrite-core [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/peterheesterman/ferrite-core [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/peterheesterman/ferrite-core" "work/ex/clippy-test-run/sources/stable/gh/peterheesterman/ferrite-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/peterheesterman/ferrite-core'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/peterheesterman/ferrite-core" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterheesterman/ferrite-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterheesterman/ferrite-core'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3d83a65b6b3304bc4b35235a05c764d81342d3f [INFO] sha for GitHub repo peterheesterman/ferrite-core: b3d83a65b6b3304bc4b35235a05c764d81342d3f [INFO] validating manifest of peterheesterman/ferrite-core on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of peterheesterman/ferrite-core on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing peterheesterman/ferrite-core [INFO] finished frobbing peterheesterman/ferrite-core [INFO] frobbed toml for peterheesterman/ferrite-core written to work/ex/clippy-test-run/sources/stable/gh/peterheesterman/ferrite-core/Cargo.toml [INFO] started frobbing peterheesterman/ferrite-core [INFO] finished frobbing peterheesterman/ferrite-core [INFO] frobbed toml for peterheesterman/ferrite-core written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterheesterman/ferrite-core/Cargo.toml [INFO] crate peterheesterman/ferrite-core has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting peterheesterman/ferrite-core against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/peterheesterman/ferrite-core:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dcb909f2b8467b95e70e89617cbb20367b4fb9a2d0f8ab5d01e94744f89ea976 [INFO] running `"docker" "start" "-a" "dcb909f2b8467b95e70e89617cbb20367b4fb9a2d0f8ab5d01e94744f89ea976"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/ferrite.rs` was erroneously implicitly accepted for library `ferrite`, [INFO] [stderr] please rename the file to `src/lib.rs` or set lib.path in Cargo.toml [INFO] [stderr] Checking ferrite-core v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ferrite.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ferrite.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return fibonacci(x - 1) + fibonacci(x - 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(x - 1) + fibonacci(x - 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ferrite.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ferrite.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return fibonacci(x - 1) + fibonacci(x - 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(x - 1) + fibonacci(x - 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "dcb909f2b8467b95e70e89617cbb20367b4fb9a2d0f8ab5d01e94744f89ea976"` [INFO] running `"docker" "rm" "-f" "dcb909f2b8467b95e70e89617cbb20367b4fb9a2d0f8ab5d01e94744f89ea976"` [INFO] [stdout] dcb909f2b8467b95e70e89617cbb20367b4fb9a2d0f8ab5d01e94744f89ea976