[INFO] updating cached repository pepyakin/wasm-export-table [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pepyakin/wasm-export-table [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pepyakin/wasm-export-table" "work/ex/clippy-test-run/sources/stable/gh/pepyakin/wasm-export-table"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pepyakin/wasm-export-table'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pepyakin/wasm-export-table" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/wasm-export-table"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/wasm-export-table'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e1e84f348e94210031ab6c56f6077c07c00e997f [INFO] sha for GitHub repo pepyakin/wasm-export-table: e1e84f348e94210031ab6c56f6077c07c00e997f [INFO] validating manifest of pepyakin/wasm-export-table on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pepyakin/wasm-export-table on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pepyakin/wasm-export-table [INFO] finished frobbing pepyakin/wasm-export-table [INFO] frobbed toml for pepyakin/wasm-export-table written to work/ex/clippy-test-run/sources/stable/gh/pepyakin/wasm-export-table/Cargo.toml [INFO] started frobbing pepyakin/wasm-export-table [INFO] finished frobbing pepyakin/wasm-export-table [INFO] frobbed toml for pepyakin/wasm-export-table written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/wasm-export-table/Cargo.toml [INFO] crate pepyakin/wasm-export-table has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pepyakin/wasm-export-table against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/wasm-export-table:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d5b996ec6cd71bb79052f22249eee19218a2f1f9b8423f98a0aaee4d6ee9bd7 [INFO] running `"docker" "start" "-a" "7d5b996ec6cd71bb79052f22249eee19218a2f1f9b8423f98a0aaee4d6ee9bd7"` [INFO] [stderr] Checking parking_lot_core v0.2.13 [INFO] [stderr] Checking parking_lot v0.5.4 [INFO] [stderr] Checking parity-wasm v0.27.1 [INFO] [stderr] Checking wasm-export-table v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if table_section.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table_section.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match *section { [INFO] [stderr] 38 | | elements::Section::Export(ref mut export_section) => { [INFO] [stderr] 39 | | // Search for any table exports in the export section. [INFO] [stderr] 40 | | let table_export_found = export_section.entries().iter().any(|ref entry| { [INFO] [stderr] ... | [INFO] [stderr] 58 | | _ => {} [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let elements::Section::Export(ref mut export_section) = *section { [INFO] [stderr] 38 | // Search for any table exports in the export section. [INFO] [stderr] 39 | let table_export_found = export_section.entries().iter().any(|ref entry| { [INFO] [stderr] 40 | if let elements::Internal::Table(_) = *entry.internal() { [INFO] [stderr] 41 | true [INFO] [stderr] 42 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if table_section.entries().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!table_section.entries().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match *section { [INFO] [stderr] 38 | | elements::Section::Export(ref mut export_section) => { [INFO] [stderr] 39 | | // Search for any table exports in the export section. [INFO] [stderr] 40 | | let table_export_found = export_section.entries().iter().any(|ref entry| { [INFO] [stderr] ... | [INFO] [stderr] 58 | | _ => {} [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let elements::Section::Export(ref mut export_section) = *section { [INFO] [stderr] 38 | // Search for any table exports in the export section. [INFO] [stderr] 39 | let table_export_found = export_section.entries().iter().any(|ref entry| { [INFO] [stderr] 40 | if let elements::Internal::Table(_) = *entry.internal() { [INFO] [stderr] 41 | true [INFO] [stderr] 42 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.20s [INFO] running `"docker" "inspect" "7d5b996ec6cd71bb79052f22249eee19218a2f1f9b8423f98a0aaee4d6ee9bd7"` [INFO] running `"docker" "rm" "-f" "7d5b996ec6cd71bb79052f22249eee19218a2f1f9b8423f98a0aaee4d6ee9bd7"` [INFO] [stdout] 7d5b996ec6cd71bb79052f22249eee19218a2f1f9b8423f98a0aaee4d6ee9bd7