[INFO] updating cached repository pepyakin/rust-wasm-interp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pepyakin/rust-wasm-interp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pepyakin/rust-wasm-interp" "work/ex/clippy-test-run/sources/stable/gh/pepyakin/rust-wasm-interp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pepyakin/rust-wasm-interp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pepyakin/rust-wasm-interp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/rust-wasm-interp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/rust-wasm-interp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6ba63fa8e03fe38ecaf2e8f99a8e78dd5919348 [INFO] sha for GitHub repo pepyakin/rust-wasm-interp: e6ba63fa8e03fe38ecaf2e8f99a8e78dd5919348 [INFO] validating manifest of pepyakin/rust-wasm-interp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pepyakin/rust-wasm-interp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pepyakin/rust-wasm-interp [INFO] finished frobbing pepyakin/rust-wasm-interp [INFO] frobbed toml for pepyakin/rust-wasm-interp written to work/ex/clippy-test-run/sources/stable/gh/pepyakin/rust-wasm-interp/Cargo.toml [INFO] started frobbing pepyakin/rust-wasm-interp [INFO] finished frobbing pepyakin/rust-wasm-interp [INFO] frobbed toml for pepyakin/rust-wasm-interp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/rust-wasm-interp/Cargo.toml [INFO] crate pepyakin/rust-wasm-interp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pepyakin/rust-wasm-interp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pepyakin/rust-wasm-interp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8d9bdc43bbfd0d47af4a51cbca2cbb744b44808aa266c6e003a6d09ef92c433 [INFO] running `"docker" "start" "-a" "e8d9bdc43bbfd0d47af4a51cbca2cbb744b44808aa266c6e003a6d09ef92c433"` [INFO] [stderr] Checking wasm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:236:59 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn instantiate<'a>(module: &ValidatedModule, imports: HashMap) -> ModuleRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 236 | pub fn instantiate<'a, S: ::std::hash::BuildHasher>(module: &ValidatedModule, imports: HashMap) -> ModuleRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:247:24 [INFO] [stderr] | [INFO] [stderr] 247 | let resolver = imports.get(&import.module_name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&imports[&import.module_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:327:48 [INFO] [stderr] | [INFO] [stderr] 327 | fn pop_args(stack: &mut Vec, signature: &Signature) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Signature` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:236:59 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn instantiate<'a>(module: &ValidatedModule, imports: HashMap) -> ModuleRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 236 | pub fn instantiate<'a, S: ::std::hash::BuildHasher>(module: &ValidatedModule, imports: HashMap) -> ModuleRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:247:24 [INFO] [stderr] | [INFO] [stderr] 247 | let resolver = imports.get(&import.module_name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&imports[&import.module_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:327:48 [INFO] [stderr] | [INFO] [stderr] 327 | fn pop_args(stack: &mut Vec, signature: &Signature) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Signature` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "e8d9bdc43bbfd0d47af4a51cbca2cbb744b44808aa266c6e003a6d09ef92c433"` [INFO] running `"docker" "rm" "-f" "e8d9bdc43bbfd0d47af4a51cbca2cbb744b44808aa266c6e003a6d09ef92c433"` [INFO] [stdout] e8d9bdc43bbfd0d47af4a51cbca2cbb744b44808aa266c6e003a6d09ef92c433