[INFO] updating cached repository pbzweihander/subway-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pbzweihander/subway-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pbzweihander/subway-rs" "work/ex/clippy-test-run/sources/stable/gh/pbzweihander/subway-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pbzweihander/subway-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pbzweihander/subway-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/subway-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/subway-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d3fe9aba4a83beda092ccde77080a977da8be0eb [INFO] sha for GitHub repo pbzweihander/subway-rs: d3fe9aba4a83beda092ccde77080a977da8be0eb [INFO] validating manifest of pbzweihander/subway-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pbzweihander/subway-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pbzweihander/subway-rs [INFO] finished frobbing pbzweihander/subway-rs [INFO] frobbed toml for pbzweihander/subway-rs written to work/ex/clippy-test-run/sources/stable/gh/pbzweihander/subway-rs/Cargo.toml [INFO] started frobbing pbzweihander/subway-rs [INFO] finished frobbing pbzweihander/subway-rs [INFO] frobbed toml for pbzweihander/subway-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/subway-rs/Cargo.toml [INFO] crate pbzweihander/subway-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pbzweihander/subway-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pbzweihander/subway-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88d38f2486c93d5424ccce5be51baf9e59755f0ab64296ca91d712c495481adc [INFO] running `"docker" "start" "-a" "88d38f2486c93d5424ccce5be51baf9e59755f0ab64296ca91d712c495481adc"` [INFO] [stderr] Checking subway v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dijkstra.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / starts [INFO] [stderr] 101 | | .into_iter() [INFO] [stderr] 102 | | .filter_map(|v| self.v_to_index_map.get(v)) [INFO] [stderr] 103 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 100 | starts [INFO] [stderr] 101 | .into_iter() [INFO] [stderr] 102 | .filter_map(|v| self.v_to_index_map.get(v)).cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dijkstra.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / ends.into_iter() [INFO] [stderr] 107 | | .filter_map(|v| self.v_to_index_map.get(v)) [INFO] [stderr] 108 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 106 | ends.into_iter() [INFO] [stderr] 107 | .filter_map(|v| self.v_to_index_map.get(v)).cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dijkstra.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | let to = *self.v_to_index_map.get(&to_vertex).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.v_to_index_map[&to_vertex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dijkstra.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / starts [INFO] [stderr] 101 | | .into_iter() [INFO] [stderr] 102 | | .filter_map(|v| self.v_to_index_map.get(v)) [INFO] [stderr] 103 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 100 | starts [INFO] [stderr] 101 | .into_iter() [INFO] [stderr] 102 | .filter_map(|v| self.v_to_index_map.get(v)).cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dijkstra.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / ends.into_iter() [INFO] [stderr] 107 | | .filter_map(|v| self.v_to_index_map.get(v)) [INFO] [stderr] 108 | | .map(|&i| i), [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 106 | ends.into_iter() [INFO] [stderr] 107 | .filter_map(|v| self.v_to_index_map.get(v)).cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dijkstra.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | let to = *self.v_to_index_map.get(&to_vertex).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.v_to_index_map[&to_vertex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "88d38f2486c93d5424ccce5be51baf9e59755f0ab64296ca91d712c495481adc"` [INFO] running `"docker" "rm" "-f" "88d38f2486c93d5424ccce5be51baf9e59755f0ab64296ca91d712c495481adc"` [INFO] [stdout] 88d38f2486c93d5424ccce5be51baf9e59755f0ab64296ca91d712c495481adc