[INFO] updating cached repository paytchoo/hands_of_time [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paytchoo/hands_of_time [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paytchoo/hands_of_time" "work/ex/clippy-test-run/sources/stable/gh/paytchoo/hands_of_time"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paytchoo/hands_of_time'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paytchoo/hands_of_time" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paytchoo/hands_of_time"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paytchoo/hands_of_time'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bf9df820640b7b960b30d77de824608e84fe919 [INFO] sha for GitHub repo paytchoo/hands_of_time: 7bf9df820640b7b960b30d77de824608e84fe919 [INFO] validating manifest of paytchoo/hands_of_time on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paytchoo/hands_of_time on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paytchoo/hands_of_time [INFO] finished frobbing paytchoo/hands_of_time [INFO] frobbed toml for paytchoo/hands_of_time written to work/ex/clippy-test-run/sources/stable/gh/paytchoo/hands_of_time/Cargo.toml [INFO] started frobbing paytchoo/hands_of_time [INFO] finished frobbing paytchoo/hands_of_time [INFO] frobbed toml for paytchoo/hands_of_time written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paytchoo/hands_of_time/Cargo.toml [INFO] crate paytchoo/hands_of_time has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paytchoo/hands_of_time against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paytchoo/hands_of_time:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5d7b8a4a41d992be8027b33d9faa63e52ad813662b0d384855e51938f899e8e [INFO] running `"docker" "start" "-a" "a5d7b8a4a41d992be8027b33d9faa63e52ad813662b0d384855e51938f899e8e"` [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking hands_of_time v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn from_vec(tiles: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | clock [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let clock = match Clock::from_vec(&args) { [INFO] [stderr] | _________________^ [INFO] [stderr] 12 | | Ok(c) => c, [INFO] [stderr] 13 | | Err(s) => { [INFO] [stderr] 14 | | println!("{}", s); [INFO] [stderr] 15 | | Clock::generate(6) [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | clock [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let clock = match Clock::from_vec(&args) { [INFO] [stderr] | _________________^ [INFO] [stderr] 12 | | Ok(c) => c, [INFO] [stderr] 13 | | Err(s) => { [INFO] [stderr] 14 | | println!("{}", s); [INFO] [stderr] 15 | | Clock::generate(6) [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn from_vec(tiles: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.75s [INFO] running `"docker" "inspect" "a5d7b8a4a41d992be8027b33d9faa63e52ad813662b0d384855e51938f899e8e"` [INFO] running `"docker" "rm" "-f" "a5d7b8a4a41d992be8027b33d9faa63e52ad813662b0d384855e51938f899e8e"` [INFO] [stdout] a5d7b8a4a41d992be8027b33d9faa63e52ad813662b0d384855e51938f899e8e