[INFO] updating cached repository paulkramme/rustybrainfuck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/paulkramme/rustybrainfuck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/paulkramme/rustybrainfuck" "work/ex/clippy-test-run/sources/stable/gh/paulkramme/rustybrainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/paulkramme/rustybrainfuck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/paulkramme/rustybrainfuck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulkramme/rustybrainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulkramme/rustybrainfuck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 072942e1220da27ccc56b3bc04c7165bdf5cef0d [INFO] sha for GitHub repo paulkramme/rustybrainfuck: 072942e1220da27ccc56b3bc04c7165bdf5cef0d [INFO] validating manifest of paulkramme/rustybrainfuck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paulkramme/rustybrainfuck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paulkramme/rustybrainfuck [INFO] finished frobbing paulkramme/rustybrainfuck [INFO] frobbed toml for paulkramme/rustybrainfuck written to work/ex/clippy-test-run/sources/stable/gh/paulkramme/rustybrainfuck/Cargo.toml [INFO] started frobbing paulkramme/rustybrainfuck [INFO] finished frobbing paulkramme/rustybrainfuck [INFO] frobbed toml for paulkramme/rustybrainfuck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulkramme/rustybrainfuck/Cargo.toml [INFO] crate paulkramme/rustybrainfuck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paulkramme/rustybrainfuck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/paulkramme/rustybrainfuck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac20bf05079f8aa46ccbc6569d8159f7baec870849bee343a7a2b4eb74f94972 [INFO] running `"docker" "start" "-a" "ac20bf05079f8aa46ccbc6569d8159f7baec870849bee343a7a2b4eb74f94972"` [INFO] [stderr] Checking rustybrainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if args.len() > 2 { [INFO] [stderr] 38 | | if args[2] == "fullprint" { [INFO] [stderr] 39 | | print!("\n{:?} p_loc {}", register, register_pointer); [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if args.len() > 2 && args[2] == "fullprint" { [INFO] [stderr] 38 | print!("\n{:?} p_loc {}", register, register_pointer); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / match file.read_to_string(&mut content) { [INFO] [stderr] 17 | | Err(why) => panic!("{}", why.description()), [INFO] [stderr] 18 | | Ok(_) => {}, [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut content) { panic!("{}", why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Debug)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | fn to_ascii(i: &i32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if args.len() > 2 { [INFO] [stderr] 38 | | if args[2] == "fullprint" { [INFO] [stderr] 39 | | print!("\n{:?} p_loc {}", register, register_pointer); [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if args.len() > 2 && args[2] == "fullprint" { [INFO] [stderr] 38 | print!("\n{:?} p_loc {}", register, register_pointer); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / match file.read_to_string(&mut content) { [INFO] [stderr] 17 | | Err(why) => panic!("{}", why.description()), [INFO] [stderr] 18 | | Ok(_) => {}, [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut content) { panic!("{}", why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Debug)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | fn to_ascii(i: &i32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "ac20bf05079f8aa46ccbc6569d8159f7baec870849bee343a7a2b4eb74f94972"` [INFO] running `"docker" "rm" "-f" "ac20bf05079f8aa46ccbc6569d8159f7baec870849bee343a7a2b4eb74f94972"` [INFO] [stdout] ac20bf05079f8aa46ccbc6569d8159f7baec870849bee343a7a2b4eb74f94972