[INFO] updating cached repository panther99/rox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/panther99/rox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/panther99/rox" "work/ex/clippy-test-run/sources/stable/gh/panther99/rox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/panther99/rox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/panther99/rox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther99/rox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther99/rox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d8c74bdf3c5eeafe913ac8ef5e9d7d40b1060e2 [INFO] sha for GitHub repo panther99/rox: 7d8c74bdf3c5eeafe913ac8ef5e9d7d40b1060e2 [INFO] validating manifest of panther99/rox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of panther99/rox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing panther99/rox [INFO] finished frobbing panther99/rox [INFO] frobbed toml for panther99/rox written to work/ex/clippy-test-run/sources/stable/gh/panther99/rox/Cargo.toml [INFO] started frobbing panther99/rox [INFO] finished frobbing panther99/rox [INFO] frobbed toml for panther99/rox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther99/rox/Cargo.toml [INFO] crate panther99/rox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting panther99/rox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther99/rox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af7be59143d2c142430deafcc1aac4dd6d031ad1cb440aa787173957d51e1315 [INFO] running `"docker" "start" "-a" "af7be59143d2c142430deafcc1aac4dd6d031ad1cb440aa787173957d51e1315"` [INFO] [stderr] Checking rox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:155:34 [INFO] [stderr] | [INFO] [stderr] 155 | PlayerKind::X => return GameState::ComputerWon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::ComputerWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:156:34 [INFO] [stderr] | [INFO] [stderr] 156 | PlayerKind::O => return GameState::HumanWon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::HumanWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | PlayerKind::X => return GameState::OWon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::OWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | PlayerKind::O => return GameState::XWon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::XWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:155:34 [INFO] [stderr] | [INFO] [stderr] 155 | PlayerKind::X => return GameState::ComputerWon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::ComputerWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:156:34 [INFO] [stderr] | [INFO] [stderr] 156 | PlayerKind::O => return GameState::HumanWon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::HumanWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | PlayerKind::X => return GameState::OWon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::OWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | PlayerKind::O => return GameState::XWon [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `GameState::XWon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/game.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(_) = self.available_moves.get(&_move) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 82 | | self.available_moves.remove(&_move); [INFO] [stderr] 83 | | self.ref_available_moves.retain(|&x| x != _move); [INFO] [stderr] 84 | | return true; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if self.available_moves.get(&_move).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/game.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if let Some(_) = self.available_moves.get(&_move) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 82 | | self.available_moves.remove(&_move); [INFO] [stderr] 83 | | self.ref_available_moves.retain(|&x| x != _move); [INFO] [stderr] 84 | | return true; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if self.available_moves.get(&_move).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "af7be59143d2c142430deafcc1aac4dd6d031ad1cb440aa787173957d51e1315"` [INFO] running `"docker" "rm" "-f" "af7be59143d2c142430deafcc1aac4dd6d031ad1cb440aa787173957d51e1315"` [INFO] [stdout] af7be59143d2c142430deafcc1aac4dd6d031ad1cb440aa787173957d51e1315