[INFO] updating cached repository panther-king/dogrun [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/panther-king/dogrun [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/panther-king/dogrun" "work/ex/clippy-test-run/sources/stable/gh/panther-king/dogrun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/panther-king/dogrun'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/panther-king/dogrun" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther-king/dogrun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther-king/dogrun'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78c0621731c54a4fcd3aa8e84fe542db6c0c986a [INFO] sha for GitHub repo panther-king/dogrun: 78c0621731c54a4fcd3aa8e84fe542db6c0c986a [INFO] validating manifest of panther-king/dogrun on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of panther-king/dogrun on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing panther-king/dogrun [INFO] finished frobbing panther-king/dogrun [INFO] frobbed toml for panther-king/dogrun written to work/ex/clippy-test-run/sources/stable/gh/panther-king/dogrun/Cargo.toml [INFO] started frobbing panther-king/dogrun [INFO] finished frobbing panther-king/dogrun [INFO] frobbed toml for panther-king/dogrun written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther-king/dogrun/Cargo.toml [INFO] crate panther-king/dogrun has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting panther-king/dogrun against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/panther-king/dogrun:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0de4f34cb9ca64d286d9e81d71c53c85a8a020cadc3ed2884e67610d0118cf0d [INFO] running `"docker" "start" "-a" "0de4f34cb9ca64d286d9e81d71c53c85a8a020cadc3ed2884e67610d0118cf0d"` [INFO] [stderr] Checking dogrun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(Dog { foods: foods }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `foods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(Dog { foods: foods }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `foods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let collect = args.iter() [INFO] [stderr] | _______________________^ [INFO] [stderr] 82 | | .skip(1) [INFO] [stderr] 83 | | .map(|arg| arg.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 81 | let collect = args.iter() [INFO] [stderr] 82 | .skip(1).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | 0 => Ok(self.eat()), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 143 | 0 => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | let collect = args.iter() [INFO] [stderr] | _______________________^ [INFO] [stderr] 82 | | .skip(1) [INFO] [stderr] 83 | | .map(|arg| arg.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 81 | let collect = args.iter() [INFO] [stderr] 82 | .skip(1).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/lib.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | 0 => Ok(self.eat()), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 143 | 0 => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const USAGE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const USAGE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/lib.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | if path.contains(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "0de4f34cb9ca64d286d9e81d71c53c85a8a020cadc3ed2884e67610d0118cf0d"` [INFO] running `"docker" "rm" "-f" "0de4f34cb9ca64d286d9e81d71c53c85a8a020cadc3ed2884e67610d0118cf0d"` [INFO] [stdout] 0de4f34cb9ca64d286d9e81d71c53c85a8a020cadc3ed2884e67610d0118cf0d