[INFO] updating cached repository pandaman64/meshi-777 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pandaman64/meshi-777 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pandaman64/meshi-777" "work/ex/clippy-test-run/sources/stable/gh/pandaman64/meshi-777"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pandaman64/meshi-777'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pandaman64/meshi-777" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pandaman64/meshi-777"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pandaman64/meshi-777'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3daf8db63a63a78a12e1616e99f4217a1aebb0e1 [INFO] sha for GitHub repo pandaman64/meshi-777: 3daf8db63a63a78a12e1616e99f4217a1aebb0e1 [INFO] validating manifest of pandaman64/meshi-777 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pandaman64/meshi-777 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pandaman64/meshi-777 [INFO] finished frobbing pandaman64/meshi-777 [INFO] frobbed toml for pandaman64/meshi-777 written to work/ex/clippy-test-run/sources/stable/gh/pandaman64/meshi-777/Cargo.toml [INFO] started frobbing pandaman64/meshi-777 [INFO] finished frobbing pandaman64/meshi-777 [INFO] frobbed toml for pandaman64/meshi-777 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pandaman64/meshi-777/Cargo.toml [INFO] crate pandaman64/meshi-777 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pandaman64/meshi-777 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pandaman64/meshi-777:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed646dcc284b4b4bf8e4cf5222900a89fc1a410e20ba634894aa4932bb488aa7 [INFO] running `"docker" "start" "-a" "ed646dcc284b4b4bf8e4cf5222900a89fc1a410e20ba634894aa4932bb488aa7"` [INFO] [stderr] Checking meshi-777 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.cell{ [INFO] [stderr] 42 | | &Nil => None, [INFO] [stderr] 43 | | &Cons(ref v,ref c) => { [INFO] [stderr] 44 | | self.cell = c; [INFO] [stderr] 45 | | Some(v) [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self.cell{ [INFO] [stderr] 42 | Nil => None, [INFO] [stderr] 43 | Cons(ref v,ref c) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | prices.entry(price).or_insert(vec![]).push(name.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.cell{ [INFO] [stderr] 42 | | &Nil => None, [INFO] [stderr] 43 | | &Cons(ref v,ref c) => { [INFO] [stderr] 44 | | self.cell = c; [INFO] [stderr] 45 | | Some(v) [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self.cell{ [INFO] [stderr] 42 | Nil => None, [INFO] [stderr] 43 | Cons(ref v,ref c) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | prices.entry(price).or_insert(vec![]).push(name.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "ed646dcc284b4b4bf8e4cf5222900a89fc1a410e20ba634894aa4932bb488aa7"` [INFO] running `"docker" "rm" "-f" "ed646dcc284b4b4bf8e4cf5222900a89fc1a410e20ba634894aa4932bb488aa7"` [INFO] [stdout] ed646dcc284b4b4bf8e4cf5222900a89fc1a410e20ba634894aa4932bb488aa7