[INFO] updating cached repository pamsilva/rusty-hangman
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/pamsilva/rusty-hangman
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/pamsilva/rusty-hangman" "work/ex/clippy-test-run/sources/stable/gh/pamsilva/rusty-hangman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pamsilva/rusty-hangman'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/pamsilva/rusty-hangman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pamsilva/rusty-hangman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pamsilva/rusty-hangman'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e4eba14cc905b7dcad7bd608b669297e1c47d8b6
[INFO] sha for GitHub repo pamsilva/rusty-hangman: e4eba14cc905b7dcad7bd608b669297e1c47d8b6
[INFO] validating manifest of pamsilva/rusty-hangman on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pamsilva/rusty-hangman on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pamsilva/rusty-hangman
[INFO] finished frobbing pamsilva/rusty-hangman
[INFO] frobbed toml for pamsilva/rusty-hangman written to work/ex/clippy-test-run/sources/stable/gh/pamsilva/rusty-hangman/Cargo.toml
[INFO] started frobbing pamsilva/rusty-hangman
[INFO] finished frobbing pamsilva/rusty-hangman
[INFO] frobbed toml for pamsilva/rusty-hangman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pamsilva/rusty-hangman/Cargo.toml
[INFO] crate pamsilva/rusty-hangman has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pamsilva/rusty-hangman against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pamsilva/rusty-hangman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 92ee6a299dc51a35b333c7ea57704a36022e4600f3a247d0c7669f5eb57beb1d
[INFO] running `"docker" "start" "-a" "92ee6a299dc51a35b333c7ea57704a36022e4600f3a247d0c7669f5eb57beb1d"`
[INFO] [stderr]     Checking rusty_hangman v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:22:4
[INFO] [stderr]    |
[INFO] [stderr] 22 |               return GameState{
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 23 | |                 attempts: state.attempts -1,
[INFO] [stderr] 24 | |                 word: state.word.to_vec(),
[INFO] [stderr] 25 | |                 visibility: vec![true; state.word.len()]
[INFO] [stderr] 26 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 22 |             GameState{
[INFO] [stderr] 23 |                 attempts: state.attempts -1,
[INFO] [stderr] 24 |                 word: state.word.to_vec(),
[INFO] [stderr] 25 |                 visibility: vec![true; state.word.len()]
[INFO] [stderr] 26 |             }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:28:4
[INFO] [stderr]    |
[INFO] [stderr] 28 |               return GameState{
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 29 | |                 attempts: state.attempts -1,
[INFO] [stderr] 30 | |                 word: state.word.to_vec(),
[INFO] [stderr] 31 | |                 visibility: state.visibility.to_vec()
[INFO] [stderr] 32 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |             GameState{
[INFO] [stderr] 29 |                 attempts: state.attempts -1,
[INFO] [stderr] 30 |                 word: state.word.to_vec(),
[INFO] [stderr] 31 |                 visibility: state.visibility.to_vec()
[INFO] [stderr] 32 |             }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:43:3
[INFO] [stderr]    |
[INFO] [stderr] 43 |           return GameState{
[INFO] [stderr]    |  _________^
[INFO] [stderr] 44 | |             attempts: state.attempts -1,
[INFO] [stderr] 45 | |             word: state.word.to_vec(),
[INFO] [stderr] 46 | |             visibility: new_visibility
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 43 |         GameState{
[INFO] [stderr] 44 |             attempts: state.attempts -1,
[INFO] [stderr] 45 |             word: state.word.to_vec(),
[INFO] [stderr] 46 |             visibility: new_visibility
[INFO] [stderr] 47 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/word_source.rs:6:21
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DICTIONARY:  &'static [&'static str] = &[
[INFO] [stderr]   |                    -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/word_source.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DICTIONARY:  &'static [&'static str] = &[
[INFO] [stderr]   |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:22:4
[INFO] [stderr]    |
[INFO] [stderr] 22 |               return GameState{
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 23 | |                 attempts: state.attempts -1,
[INFO] [stderr] 24 | |                 word: state.word.to_vec(),
[INFO] [stderr] 25 | |                 visibility: vec![true; state.word.len()]
[INFO] [stderr] 26 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 22 |             GameState{
[INFO] [stderr] 23 |                 attempts: state.attempts -1,
[INFO] [stderr] 24 |                 word: state.word.to_vec(),
[INFO] [stderr] 25 |                 visibility: vec![true; state.word.len()]
[INFO] [stderr] 26 |             }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:28:4
[INFO] [stderr]    |
[INFO] [stderr] 28 |               return GameState{
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 29 | |                 attempts: state.attempts -1,
[INFO] [stderr] 30 | |                 word: state.word.to_vec(),
[INFO] [stderr] 31 | |                 visibility: state.visibility.to_vec()
[INFO] [stderr] 32 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |             GameState{
[INFO] [stderr] 29 |                 attempts: state.attempts -1,
[INFO] [stderr] 30 |                 word: state.word.to_vec(),
[INFO] [stderr] 31 |                 visibility: state.visibility.to_vec()
[INFO] [stderr] 32 |             }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/state.rs:43:3
[INFO] [stderr]    |
[INFO] [stderr] 43 |           return GameState{
[INFO] [stderr]    |  _________^
[INFO] [stderr] 44 | |             attempts: state.attempts -1,
[INFO] [stderr] 45 | |             word: state.word.to_vec(),
[INFO] [stderr] 46 | |             visibility: new_visibility
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 43 |         GameState{
[INFO] [stderr] 44 |             attempts: state.attempts -1,
[INFO] [stderr] 45 |             word: state.word.to_vec(),
[INFO] [stderr] 46 |             visibility: new_visibility
[INFO] [stderr] 47 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/word_source.rs:6:21
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DICTIONARY:  &'static [&'static str] = &[
[INFO] [stderr]   |                    -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/word_source.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DICTIONARY:  &'static [&'static str] = &[
[INFO] [stderr]   |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `new_visibility`
[INFO] [stderr]   --> src/state.rs:39:12
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..state.word.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (i, <item>) in new_visibility.iter_mut().enumerate().take(state.word.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `new_visibility`
[INFO] [stderr]   --> src/state.rs:39:12
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..state.word.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (i, <item>) in new_visibility.iter_mut().enumerate().take(state.word.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/word_source.rs:28:40
[INFO] [stderr]    |
[INFO] [stderr] 28 |         assert_eq!(true, DICTIONARY.iter().fold(false, |t, &candidate| {t || (word == candidate)}));
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|candidate| (word == candidate))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.56s
[INFO] running `"docker" "inspect" "92ee6a299dc51a35b333c7ea57704a36022e4600f3a247d0c7669f5eb57beb1d"`
[INFO] running `"docker" "rm" "-f" "92ee6a299dc51a35b333c7ea57704a36022e4600f3a247d0c7669f5eb57beb1d"`
[INFO] [stdout] 92ee6a299dc51a35b333c7ea57704a36022e4600f3a247d0c7669f5eb57beb1d