[INFO] updating cached repository pacf531/pp_table_converter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/pacf531/pp_table_converter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/pacf531/pp_table_converter" "work/ex/clippy-test-run/sources/stable/gh/pacf531/pp_table_converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/pacf531/pp_table_converter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/pacf531/pp_table_converter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacf531/pp_table_converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacf531/pp_table_converter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b52fa55ab5b62b0fd8d3203dbd91ce542c96a679 [INFO] sha for GitHub repo pacf531/pp_table_converter: b52fa55ab5b62b0fd8d3203dbd91ce542c96a679 [INFO] validating manifest of pacf531/pp_table_converter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pacf531/pp_table_converter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pacf531/pp_table_converter [INFO] finished frobbing pacf531/pp_table_converter [INFO] frobbed toml for pacf531/pp_table_converter written to work/ex/clippy-test-run/sources/stable/gh/pacf531/pp_table_converter/Cargo.toml [INFO] started frobbing pacf531/pp_table_converter [INFO] finished frobbing pacf531/pp_table_converter [INFO] frobbed toml for pacf531/pp_table_converter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacf531/pp_table_converter/Cargo.toml [INFO] crate pacf531/pp_table_converter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pacf531/pp_table_converter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/pacf531/pp_table_converter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b393d936fe50ef3a27b7689adc01ea11f7da9412f923559a9105f5b9ac0e8411 [INFO] running `"docker" "start" "-a" "b393d936fe50ef3a27b7689adc01ea11f7da9412f923559a9105f5b9ac0e8411"` [INFO] [stderr] Checking pp_table_converter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:18:64 [INFO] [stderr] | [INFO] [stderr] 18 | let hex_pp_table = &windows_pp_table[windows_pp_table.find(":").unwrap_or(windows_pp_table.len() - 1) + 1..].replace(chars_to_trim, ""); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:18:64 [INFO] [stderr] | [INFO] [stderr] 18 | let hex_pp_table = &windows_pp_table[windows_pp_table.find(":").unwrap_or(windows_pp_table.len() - 1) + 1..].replace(chars_to_trim, ""); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "b393d936fe50ef3a27b7689adc01ea11f7da9412f923559a9105f5b9ac0e8411"` [INFO] running `"docker" "rm" "-f" "b393d936fe50ef3a27b7689adc01ea11f7da9412f923559a9105f5b9ac0e8411"` [INFO] [stdout] b393d936fe50ef3a27b7689adc01ea11f7da9412f923559a9105f5b9ac0e8411