[INFO] updating cached repository p00s/miniurl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/p00s/miniurl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/p00s/miniurl" "work/ex/clippy-test-run/sources/stable/gh/p00s/miniurl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/p00s/miniurl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/p00s/miniurl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p00s/miniurl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p00s/miniurl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c1d297db8abd488e46e3974c26f54d246752bc22
[INFO] sha for GitHub repo p00s/miniurl: c1d297db8abd488e46e3974c26f54d246752bc22
[INFO] validating manifest of p00s/miniurl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of p00s/miniurl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing p00s/miniurl
[INFO] finished frobbing p00s/miniurl
[INFO] frobbed toml for p00s/miniurl written to work/ex/clippy-test-run/sources/stable/gh/p00s/miniurl/Cargo.toml
[INFO] started frobbing p00s/miniurl
[INFO] finished frobbing p00s/miniurl
[INFO] frobbed toml for p00s/miniurl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p00s/miniurl/Cargo.toml
[INFO] crate p00s/miniurl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting p00s/miniurl against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p00s/miniurl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b285cf79ec647ac4958853a2d72edeb2f3836306eaee18549aff5eaf241ac2b4
[INFO] running `"docker" "start" "-a" "b285cf79ec647ac4958853a2d72edeb2f3836306eaee18549aff5eaf241ac2b4"`
[INFO] [stderr]     Checking miniurl v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             port: port,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             port: port,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:23:23
[INFO] [stderr]    |
[INFO] [stderr] 23 | const SCHEMA_CHARS : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ\
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:23:23
[INFO] [stderr]    |
[INFO] [stderr] 23 | const SCHEMA_CHARS : &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ\
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Url`
[INFO] [stderr]   --> src/lib.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> Url {
[INFO] [stderr] 47 | |         Url {
[INFO] [stderr] 48 | |             scheme: String::new(),
[INFO] [stderr] 49 | |             netloc: String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 31 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:100:31
[INFO] [stderr]     |
[INFO] [stderr] 100 |           let (netloc, extra) = match extra.starts_with("//") {
[INFO] [stderr]     |  _______________________________^
[INFO] [stderr] 101 | |             true => {
[INFO] [stderr] 102 | |                 let _extra = &extra[2..];
[INFO] [stderr] 103 | |                 let mut a = _extra;
[INFO] [stderr] ...   |
[INFO] [stderr] 121 | |             false => ("", extra),
[INFO] [stderr] 122 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let (netloc, extra) = if extra.starts_with("//") {
[INFO] [stderr] 101 |     let _extra = &extra[2..];
[INFO] [stderr] 102 |     let mut a = _extra;
[INFO] [stderr] 103 |     let mut b = "";
[INFO] [stderr] 104 |     let mut delim = !0 as usize;
[INFO] [stderr] 105 |     for c in "/?#".chars() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:212:26
[INFO] [stderr]     |
[INFO] [stderr] 212 |         let mut result = format!("{}",self.path);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.path.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Url`
[INFO] [stderr]   --> src/lib.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> Url {
[INFO] [stderr] 47 | |         Url {
[INFO] [stderr] 48 | |             scheme: String::new(),
[INFO] [stderr] 49 | |             netloc: String::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 31 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:100:31
[INFO] [stderr]     |
[INFO] [stderr] 100 |           let (netloc, extra) = match extra.starts_with("//") {
[INFO] [stderr]     |  _______________________________^
[INFO] [stderr] 101 | |             true => {
[INFO] [stderr] 102 | |                 let _extra = &extra[2..];
[INFO] [stderr] 103 | |                 let mut a = _extra;
[INFO] [stderr] ...   |
[INFO] [stderr] 121 | |             false => ("", extra),
[INFO] [stderr] 122 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let (netloc, extra) = if extra.starts_with("//") {
[INFO] [stderr] 101 |     let _extra = &extra[2..];
[INFO] [stderr] 102 |     let mut a = _extra;
[INFO] [stderr] 103 |     let mut b = "";
[INFO] [stderr] 104 |     let mut delim = !0 as usize;
[INFO] [stderr] 105 |     for c in "/?#".chars() {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:212:26
[INFO] [stderr]     |
[INFO] [stderr] 212 |         let mut result = format!("{}",self.path);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.path.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.88s
[INFO] running `"docker" "inspect" "b285cf79ec647ac4958853a2d72edeb2f3836306eaee18549aff5eaf241ac2b4"`
[INFO] running `"docker" "rm" "-f" "b285cf79ec647ac4958853a2d72edeb2f3836306eaee18549aff5eaf241ac2b4"`
[INFO] [stdout] b285cf79ec647ac4958853a2d72edeb2f3836306eaee18549aff5eaf241ac2b4