[INFO] updating cached repository p-jackson/how-do-i-escape
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/p-jackson/how-do-i-escape
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/p-jackson/how-do-i-escape" "work/ex/clippy-test-run/sources/stable/gh/p-jackson/how-do-i-escape"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/p-jackson/how-do-i-escape'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/p-jackson/how-do-i-escape" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p-jackson/how-do-i-escape"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p-jackson/how-do-i-escape'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 747ba880784d49b87d02c02220e8ff1fe7c30086
[INFO] sha for GitHub repo p-jackson/how-do-i-escape: 747ba880784d49b87d02c02220e8ff1fe7c30086
[INFO] validating manifest of p-jackson/how-do-i-escape on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of p-jackson/how-do-i-escape on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing p-jackson/how-do-i-escape
[INFO] finished frobbing p-jackson/how-do-i-escape
[INFO] frobbed toml for p-jackson/how-do-i-escape written to work/ex/clippy-test-run/sources/stable/gh/p-jackson/how-do-i-escape/Cargo.toml
[INFO] started frobbing p-jackson/how-do-i-escape
[INFO] finished frobbing p-jackson/how-do-i-escape
[INFO] frobbed toml for p-jackson/how-do-i-escape written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p-jackson/how-do-i-escape/Cargo.toml
[INFO] crate p-jackson/how-do-i-escape has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting p-jackson/how-do-i-escape against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/p-jackson/how-do-i-escape:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 82a0d8cc0fa673ca40f19951ce70ba466a5b5f037a4514a08d7a0cee07677ba5
[INFO] running `"docker" "start" "-a" "82a0d8cc0fa673ca40f19951ce70ba466a5b5f037a4514a08d7a0cee07677ba5"`
[INFO] [stderr]     Checking entities v1.0.1
[INFO] [stderr]     Checking how-do-i-escape v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lang/html.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |     entity.ends_with(";")
[INFO] [stderr]    |                      ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     loop {
[INFO] [stderr] 41 | |         match T::encode(&mut iter) {
[INFO] [stderr] 42 | |             Some(s) => result.push_str(&s),
[INFO] [stderr] 43 | |             None => break,
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(s) = T::encode(&mut iter) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lang/html.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |     entity.ends_with(";")
[INFO] [stderr]    |                      ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/lib.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     loop {
[INFO] [stderr] 41 | |         match T::encode(&mut iter) {
[INFO] [stderr] 42 | |             Some(s) => result.push_str(&s),
[INFO] [stderr] 43 | |             None => break,
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(s) = T::encode(&mut iter) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:8:23
[INFO] [stderr]   |
[INFO] [stderr] 8 | const HELP_TEMPLATE: &'static str = "
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:8:23
[INFO] [stderr]   |
[INFO] [stderr] 8 | const HELP_TEMPLATE: &'static str = "
[INFO] [stderr]   |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.56s
[INFO] running `"docker" "inspect" "82a0d8cc0fa673ca40f19951ce70ba466a5b5f037a4514a08d7a0cee07677ba5"`
[INFO] running `"docker" "rm" "-f" "82a0d8cc0fa673ca40f19951ce70ba466a5b5f037a4514a08d7a0cee07677ba5"`
[INFO] [stdout] 82a0d8cc0fa673ca40f19951ce70ba466a5b5f037a4514a08d7a0cee07677ba5