[INFO] updating cached repository owtotwo/rcbc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/owtotwo/rcbc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/rcbc" "work/ex/clippy-test-run/sources/stable/gh/owtotwo/rcbc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owtotwo/rcbc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/rcbc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/rcbc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/rcbc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d17bc0b6826d4fa1223b29ca995433e2e69fbb9 [INFO] sha for GitHub repo owtotwo/rcbc: 0d17bc0b6826d4fa1223b29ca995433e2e69fbb9 [INFO] validating manifest of owtotwo/rcbc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owtotwo/rcbc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owtotwo/rcbc [INFO] finished frobbing owtotwo/rcbc [INFO] frobbed toml for owtotwo/rcbc written to work/ex/clippy-test-run/sources/stable/gh/owtotwo/rcbc/Cargo.toml [INFO] started frobbing owtotwo/rcbc [INFO] finished frobbing owtotwo/rcbc [INFO] frobbed toml for owtotwo/rcbc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/rcbc/Cargo.toml [INFO] crate owtotwo/rcbc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owtotwo/rcbc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/rcbc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be1976a5c32706e35ed09b6f46dfe0f582bb2626e9f36047a6eaf18f14e4a4a6 [INFO] running `"docker" "start" "-a" "be1976a5c32706e35ed09b6f46dfe0f582bb2626e9f36047a6eaf18f14e4a4a6"` [INFO] [stderr] Checking rcbc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/location.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/location.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:21 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:33 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:49 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:61 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1436:22 [INFO] [stderr] | [INFO] [stderr] 1436 | ParseError { kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/location.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/location.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:21 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:33 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:49 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:512:61 [INFO] [stderr] | [INFO] [stderr] 512 | ScanError { line: line, column: column, kind: kind, stray: stray } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/token.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1436:22 [INFO] [stderr] | [INFO] [stderr] 1436 | ParseError { kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/ast.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const INDENT_STRING: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::location::Location` [INFO] [stderr] --> src/rcbc/compiler/type_.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::location::Location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/mod.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | const COMPILER_NAME: &'static str = "rcbc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/mod.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | const COMPILER_VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | const EXT_CFLAT_SOURCE: &'static str = "cb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | const EXT_ASSEMBLY_SOURCE: &'static str = "s" ; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | const EXT_OBJECT_FILE: &'static str = "o" ; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | const EXECUTABLE_FILE_DEFAULT: &'static str = "a.out"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/ast.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const INDENT_STRING: &'static str = " "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::location::Location` [INFO] [stderr] --> src/rcbc/compiler/type_.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::location::Location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/mod.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | const COMPILER_NAME: &'static str = "rcbc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/compiler/mod.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | const COMPILER_VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | const EXT_CFLAT_SOURCE: &'static str = "cb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | const EXT_ASSEMBLY_SOURCE: &'static str = "s" ; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | const EXT_OBJECT_FILE: &'static str = "o" ; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rcbc/mod.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | const EXECUTABLE_FILE_DEFAULT: &'static str = "a.out"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:799:48 [INFO] [stderr] | [INFO] [stderr] 799 | return Ok(Box::new(SizeofTypeNode::new(location, type_, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:805:48 [INFO] [stderr] | [INFO] [stderr] 805 | return Ok(Box::new(SizeofExprNode::new(location, node, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:815:40 [INFO] [stderr] | [INFO] [stderr] 815 | return Ok(Box::new(SizeofExprNode::new(location, node, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/rcbc/compiler/parser.rs:824:9 [INFO] [stderr] | [INFO] [stderr] 824 | println!("Unary Found!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:799:48 [INFO] [stderr] | [INFO] [stderr] 799 | return Ok(Box::new(SizeofTypeNode::new(location, type_, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:805:48 [INFO] [stderr] | [INFO] [stderr] 805 | return Ok(Box::new(SizeofExprNode::new(location, node, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/rcbc/compiler/parser.rs:815:40 [INFO] [stderr] | [INFO] [stderr] 815 | return Ok(Box::new(SizeofExprNode::new(location, node, unimplemented!()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/rcbc/compiler/parser.rs:824:9 [INFO] [stderr] | [INFO] [stderr] 824 | println!("Unary Found!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(stream: &'a String) -> Scanner<'a> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 85 [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / fn scan_reserved_words_or_identifier(&mut self) -> Result<()> { [INFO] [stderr] 155 | | let s = self.iter.as_str(); [INFO] [stderr] 156 | | [INFO] [stderr] 157 | | macro_rules! match_keyword { [INFO] [stderr] ... | [INFO] [stderr] 207 | | self.scan_identifier() [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(stream: &'a String) -> Scanner<'a> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 85 [INFO] [stderr] --> src/rcbc/compiler/scanner.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / fn scan_reserved_words_or_identifier(&mut self) -> Result<()> { [INFO] [stderr] 155 | | let s = self.iter.as_str(); [INFO] [stderr] 156 | | [INFO] [stderr] 157 | | macro_rules! match_keyword { [INFO] [stderr] ... | [INFO] [stderr] 207 | | self.scan_identifier() [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rcbc/compiler/parser.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn new(token_stream: &'a Vec) -> Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/rcbc/compiler/parser.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | let location = token_stream [INFO] [stderr] | ________________________^ [INFO] [stderr] 147 | | .iter() [INFO] [stderr] 148 | | .next() [INFO] [stderr] 149 | | .map(|x| x.location()) [INFO] [stderr] 150 | | .unwrap_or(Location::default()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | let location = token_stream [INFO] [stderr] 147 | .iter() [INFO] [stderr] 148 | .next() [INFO] [stderr] 149 | .map(|x| x.location()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rcbc/compiler/parser.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn new(token_stream: &'a Vec) -> Parser<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/rcbc/compiler/parser.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | let location = token_stream [INFO] [stderr] | ________________________^ [INFO] [stderr] 147 | | .iter() [INFO] [stderr] 148 | | .next() [INFO] [stderr] 149 | | .map(|x| x.location()) [INFO] [stderr] 150 | | .unwrap_or(Location::default()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | let location = token_stream [INFO] [stderr] 147 | .iter() [INFO] [stderr] 148 | .next() [INFO] [stderr] 149 | .map(|x| x.location()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1279:12 [INFO] [stderr] | [INFO] [stderr] 1279 | if normal_cases.len() == 0 && default_case.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `normal_cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1283:20 [INFO] [stderr] | [INFO] [stderr] 1283 | if normal_cases.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!normal_cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1300:24 [INFO] [stderr] | [INFO] [stderr] 1300 | let right = if stmts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stmts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1314:24 [INFO] [stderr] | [INFO] [stderr] 1314 | let right = if stmts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stmts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1279:12 [INFO] [stderr] | [INFO] [stderr] 1279 | if normal_cases.len() == 0 && default_case.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `normal_cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1283:20 [INFO] [stderr] | [INFO] [stderr] 1283 | if normal_cases.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!normal_cases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1300:24 [INFO] [stderr] | [INFO] [stderr] 1300 | let right = if stmts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stmts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/compiler/parser.rs:1314:24 [INFO] [stderr] | [INFO] [stderr] 1314 | let right = if stmts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stmts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rcbc/compiler/ast.rs:524:35 [INFO] [stderr] | [INFO] [stderr] 524 | } else if value.ends_with("L") { [INFO] [stderr] | ^^^ help: try using a char instead: `'L'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rcbc/compiler/ast.rs:526:35 [INFO] [stderr] | [INFO] [stderr] 526 | } else if value.ends_with("U") { [INFO] [stderr] | ^^^ help: try using a char instead: `'U'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rcbc/compiler/mod.rs:91:44 [INFO] [stderr] | [INFO] [stderr] 91 | .and_then(|mut asm| asm.write("Something...".as_bytes())) ?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Something..."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rcbc/compiler/mod.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn is_dump_tokens(&mut self, is_dump: bool) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rcbc/linker/mod.rs:12:51 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn link>(&self, obj_files: &Vec

, exec_file: &P) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[P]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/mod.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | } else if matches.free.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rcbc/compiler/ast.rs:524:35 [INFO] [stderr] | [INFO] [stderr] 524 | } else if value.ends_with("L") { [INFO] [stderr] | ^^^ help: try using a char instead: `'L'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rcbc/compiler/ast.rs:526:35 [INFO] [stderr] | [INFO] [stderr] 526 | } else if value.ends_with("U") { [INFO] [stderr] | ^^^ help: try using a char instead: `'U'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rcbc/compiler/mod.rs:91:44 [INFO] [stderr] | [INFO] [stderr] 91 | .and_then(|mut asm| asm.write("Something...".as_bytes())) ?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Something..."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rcbc/compiler/mod.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn is_dump_tokens(&mut self, is_dump: bool) -> &mut Self { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rcbc/linker/mod.rs:12:51 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn link>(&self, obj_files: &Vec

, exec_file: &P) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[P]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rcbc/mod.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | } else if matches.free.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.44s [INFO] running `"docker" "inspect" "be1976a5c32706e35ed09b6f46dfe0f582bb2626e9f36047a6eaf18f14e4a4a6"` [INFO] running `"docker" "rm" "-f" "be1976a5c32706e35ed09b6f46dfe0f582bb2626e9f36047a6eaf18f14e4a4a6"` [INFO] [stdout] be1976a5c32706e35ed09b6f46dfe0f582bb2626e9f36047a6eaf18f14e4a4a6