[INFO] updating cached repository owtotwo/hexdump [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/owtotwo/hexdump [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/hexdump" "work/ex/clippy-test-run/sources/stable/gh/owtotwo/hexdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owtotwo/hexdump'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/owtotwo/hexdump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/hexdump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/hexdump'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8fa0ec2fac81576b380653a96970df48b87fb84 [INFO] sha for GitHub repo owtotwo/hexdump: f8fa0ec2fac81576b380653a96970df48b87fb84 [INFO] validating manifest of owtotwo/hexdump on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owtotwo/hexdump on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owtotwo/hexdump [INFO] finished frobbing owtotwo/hexdump [INFO] frobbed toml for owtotwo/hexdump written to work/ex/clippy-test-run/sources/stable/gh/owtotwo/hexdump/Cargo.toml [INFO] started frobbing owtotwo/hexdump [INFO] finished frobbing owtotwo/hexdump [INFO] frobbed toml for owtotwo/hexdump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/hexdump/Cargo.toml [INFO] crate owtotwo/hexdump has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owtotwo/hexdump against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owtotwo/hexdump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5be1c7bf2f97c1a4d1b3819c948e1539579559ea1ff079c303bbd345875b10f5 [INFO] running `"docker" "start" "-a" "5be1c7bf2f97c1a4d1b3819c948e1539579559ea1ff079c303bbd345875b10f5"` [INFO] [stderr] Checking hexdump v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const HINTS: &'static str = "Usage: hexdump "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const HINTS: &'static str = "Usage: hexdump "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let mut prev_line = line.clone(); // storage previous line content [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let mut prev_line = line.clone(); // storage previous line content [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `line` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | line[count % 16] = i.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | prev_line = line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | line[count % 16] = i.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | prev_line = line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hexdump.rs:77:62 [INFO] [stderr] | [INFO] [stderr] 77 | to_printable_chars(&line[0..(count % 16 + 1)]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=count % 16` [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hexdump.rs:77:62 [INFO] [stderr] | [INFO] [stderr] 77 | to_printable_chars(&line[0..(count % 16 + 1)]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `0..=count % 16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hexdump.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | let c = match char::from_u32(i.clone() as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(i.clone())` [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hexdump.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | let c = match char::from_u32(i.clone() as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(i.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | let c = match char::from_u32(i.clone() as u32) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hexdump.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | let c = match char::from_u32(i.clone() as u32) { [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "5be1c7bf2f97c1a4d1b3819c948e1539579559ea1ff079c303bbd345875b10f5"` [INFO] running `"docker" "rm" "-f" "5be1c7bf2f97c1a4d1b3819c948e1539579559ea1ff079c303bbd345875b10f5"` [INFO] [stdout] 5be1c7bf2f97c1a4d1b3819c948e1539579559ea1ff079c303bbd345875b10f5