[INFO] updating cached repository owlinux1000/rust-casl2
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/owlinux1000/rust-casl2
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/owlinux1000/rust-casl2" "work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-casl2"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-casl2'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/owlinux1000/rust-casl2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-casl2"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-casl2'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 24704cbcf3aacc51a2bf33a332377ab661012a79
[INFO] sha for GitHub repo owlinux1000/rust-casl2: 24704cbcf3aacc51a2bf33a332377ab661012a79
[INFO] validating manifest of owlinux1000/rust-casl2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of owlinux1000/rust-casl2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing owlinux1000/rust-casl2
[INFO] finished frobbing owlinux1000/rust-casl2
[INFO] frobbed toml for owlinux1000/rust-casl2 written to work/ex/clippy-test-run/sources/stable/gh/owlinux1000/rust-casl2/Cargo.toml
[INFO] started frobbing owlinux1000/rust-casl2
[INFO] finished frobbing owlinux1000/rust-casl2
[INFO] frobbed toml for owlinux1000/rust-casl2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-casl2/Cargo.toml
[INFO] crate owlinux1000/rust-casl2 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting owlinux1000/rust-casl2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/owlinux1000/rust-casl2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9973347b5cc77ae23a47d14485c95d9a814b8ed67a59c9b494a019b7b91b377e
[INFO] running `"docker" "start" "-a" "9973347b5cc77ae23a47d14485c95d9a814b8ed67a59c9b494a019b7b91b377e"`
[INFO] [stderr]     Checking getopts v0.2.15
[INFO] [stderr]     Checking rust-casl2 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:36:15
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Token{kind: kind, value: value}
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Token{kind: kind, value: value}
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:36:15
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Token{kind: kind, value: value}
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/token.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Token{kind: kind, value: value}
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/literal.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     return !(is_decimal(constant) &&
[INFO] [stderr] 13 | |              is_hex(constant) &&
[INFO] [stderr] 14 | |              is_char(constant)
[INFO] [stderr] 15 | |     )
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |     !(is_decimal(constant) &&
[INFO] [stderr] 13 |              is_hex(constant) &&
[INFO] [stderr] 14 |              is_char(constant)
[INFO] [stderr] 15 |     )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return Decimal;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Decimal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return Hex;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `Hex`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return Char;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `Char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return Address
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return Other
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `Other`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 |         return s.parse::<u16>().unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::<u16>().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 |         return u16::from_str_radix(&s[1..], 16).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u16::from_str_radix(&s[1..], 16).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 |         return *labels.get(s).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*labels.get(s).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/token.rs:441:21
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     v
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/token.rs:440:29
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     let v = iter.next().unwrap().value.parse::<u16>().unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/token.rs:716:28
[INFO] [stderr]     |
[INFO] [stderr] 716 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 717 | |                     
[INFO] [stderr] 718 | |                         if is_label(l) {
[INFO] [stderr] 719 | |                             self.tokens.push(Token::new(Label,l.to_string()));
[INFO] [stderr] ...   |
[INFO] [stderr] 722 | |                         }
[INFO] [stderr] 723 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 716 |                     } else if is_label(l) {
[INFO] [stderr] 717 |     self.tokens.push(Token::new(Label,l.to_string()));
[INFO] [stderr] 718 | } else {
[INFO] [stderr] 719 |     panic!("Invalid label format");
[INFO] [stderr] 720 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/token.rs:739:28
[INFO] [stderr]     |
[INFO] [stderr] 739 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 740 | |                         
[INFO] [stderr] 741 | |                         if is_register(l) {
[INFO] [stderr] 742 | |                             self.tokens.push(Token::new(Register,l.to_string()));
[INFO] [stderr] ...   |
[INFO] [stderr] 752 | |                         }
[INFO] [stderr] 753 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 739 |                     } else if is_register(l) {
[INFO] [stderr] 740 |     self.tokens.push(Token::new(Register,l.to_string()));
[INFO] [stderr] 741 | } else if is_literal(l) {
[INFO] [stderr] 742 |     self.tokens.push(Token::new(Literal,l.to_string()));
[INFO] [stderr] 743 |     self.with_literal = true;
[INFO] [stderr] 744 | } else if is_constant(l) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/literal.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     return !(is_decimal(constant) &&
[INFO] [stderr] 13 | |              is_hex(constant) &&
[INFO] [stderr] 14 | |              is_char(constant)
[INFO] [stderr] 15 | |     )
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |     !(is_decimal(constant) &&
[INFO] [stderr] 13 |              is_hex(constant) &&
[INFO] [stderr] 14 |              is_char(constant)
[INFO] [stderr] 15 |     )
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return Decimal;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Decimal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return Hex;
[INFO] [stderr]    |         ^^^^^^^^^^^ help: remove `return` as shown: `Hex`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return Char;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `Char`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return Address
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Address`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/constant.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return Other
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `Other`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 |         return s.parse::<u16>().unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::<u16>().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 |         return u16::from_str_radix(&s[1..], 16).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u16::from_str_radix(&s[1..], 16).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/constant.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 |         return *labels.get(s).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*labels.get(s).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/token.rs:441:21
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     v
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/token.rs:440:29
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     let v = iter.next().unwrap().value.parse::<u16>().unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/token.rs:716:28
[INFO] [stderr]     |
[INFO] [stderr] 716 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 717 | |                     
[INFO] [stderr] 718 | |                         if is_label(l) {
[INFO] [stderr] 719 | |                             self.tokens.push(Token::new(Label,l.to_string()));
[INFO] [stderr] ...   |
[INFO] [stderr] 722 | |                         }
[INFO] [stderr] 723 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 716 |                     } else if is_label(l) {
[INFO] [stderr] 717 |     self.tokens.push(Token::new(Label,l.to_string()));
[INFO] [stderr] 718 | } else {
[INFO] [stderr] 719 |     panic!("Invalid label format");
[INFO] [stderr] 720 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/token.rs:739:28
[INFO] [stderr]     |
[INFO] [stderr] 739 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 740 | |                         
[INFO] [stderr] 741 | |                         if is_register(l) {
[INFO] [stderr] 742 | |                             self.tokens.push(Token::new(Register,l.to_string()));
[INFO] [stderr] ...   |
[INFO] [stderr] 752 | |                         }
[INFO] [stderr] 753 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 739 |                     } else if is_register(l) {
[INFO] [stderr] 740 |     self.tokens.push(Token::new(Register,l.to_string()));
[INFO] [stderr] 741 | } else if is_literal(l) {
[INFO] [stderr] 742 |     self.tokens.push(Token::new(Literal,l.to_string()));
[INFO] [stderr] 743 |     self.with_literal = true;
[INFO] [stderr] 744 | } else if is_constant(l) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn write_machine_code(vec: &Vec<u16>, path: &str) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u16]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn print_machine_code(vec: &Vec<u16>) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u16]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/constant.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     match s.parse::<u16>() {
[INFO] [stderr] 37 | |         Ok(_) => true,
[INFO] [stderr] 38 | |         Err(_) => false,
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^ help: try this: `s.parse::<u16>().is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/constant.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     match u16::from_str_radix(&s[1..], 16) {
[INFO] [stderr] 44 | |         Ok(_) => true,
[INFO] [stderr] 45 | |         Err(_) => false,
[INFO] [stderr] 46 | |     }
[INFO] [stderr]    | |_____^ help: try this: `u16::from_str_radix(&s[1..], 16).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/constant.rs:82:10
[INFO] [stderr]    |
[INFO] [stderr] 82 |     if !(1 <= s.len() && s.len() <= 8) {
[INFO] [stderr]    |          ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:20:32
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn write_machine_code(vec: &Vec<u16>, path: &str) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u16]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/token.rs:108:41
[INFO] [stderr]     |
[INFO] [stderr] 108 |                     while let Some(v) = iter.next() {
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/token.rs:169:25
[INFO] [stderr]     |
[INFO] [stderr] 169 | /                         let len: u16;
[INFO] [stderr] 170 | |                         
[INFO] [stderr] 171 | |                         if kind == Constant::Char {
[INFO] [stderr] 172 | |                             len = constant_of_char_len(arg);
[INFO] [stderr] 173 | |                         } else {
[INFO] [stderr] 174 | |                             len = 1;
[INFO] [stderr] 175 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let len = if kind == Constant::Char { constant_of_char_len(arg) } else { 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn print_machine_code(vec: &Vec<u16>) {
[INFO] [stderr]    |                                ^^^^^^^^^ help: change this to: `&[u16]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/constant.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     match s.parse::<u16>() {
[INFO] [stderr] 37 | |         Ok(_) => true,
[INFO] [stderr] 38 | |         Err(_) => false,
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^ help: try this: `s.parse::<u16>().is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/constant.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     match u16::from_str_radix(&s[1..], 16) {
[INFO] [stderr] 44 | |         Ok(_) => true,
[INFO] [stderr] 45 | |         Err(_) => false,
[INFO] [stderr] 46 | |     }
[INFO] [stderr]    | |_____^ help: try this: `u16::from_str_radix(&s[1..], 16).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/constant.rs:82:10
[INFO] [stderr]    |
[INFO] [stderr] 82 |     if !(1 <= s.len() && s.len() <= 8) {
[INFO] [stderr]    |          ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/token.rs:108:41
[INFO] [stderr]     |
[INFO] [stderr] 108 |                     while let Some(v) = iter.next() {
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/token.rs:169:25
[INFO] [stderr]     |
[INFO] [stderr] 169 | /                         let len: u16;
[INFO] [stderr] 170 | |                         
[INFO] [stderr] 171 | |                         if kind == Constant::Char {
[INFO] [stderr] 172 | |                             len = constant_of_char_len(arg);
[INFO] [stderr] 173 | |                         } else {
[INFO] [stderr] 174 | |                             len = 1;
[INFO] [stderr] 175 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let len = if kind == Constant::Char { constant_of_char_len(arg) } else { 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/main.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 | /         .collect::<Vec<&str>>()
[INFO] [stderr] 84 | |         .len() - 2;
[INFO] [stderr]    | |______________^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:100:12
[INFO] [stderr]     |
[INFO] [stderr] 100 |         if line.machine_code.len() != 0  {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.machine_code.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/main.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 | /         .collect::<Vec<&str>>()
[INFO] [stderr] 84 | |         .len() - 2;
[INFO] [stderr]    | |______________^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:100:12
[INFO] [stderr]     |
[INFO] [stderr] 100 |         if line.machine_code.len() != 0  {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.machine_code.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.62s
[INFO] running `"docker" "inspect" "9973347b5cc77ae23a47d14485c95d9a814b8ed67a59c9b494a019b7b91b377e"`
[INFO] running `"docker" "rm" "-f" "9973347b5cc77ae23a47d14485c95d9a814b8ed67a59c9b494a019b7b91b377e"`
[INFO] [stdout] 9973347b5cc77ae23a47d14485c95d9a814b8ed67a59c9b494a019b7b91b377e