[INFO] updating cached repository ormris/srpnc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ormris/srpnc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ormris/srpnc" "work/ex/clippy-test-run/sources/stable/gh/ormris/srpnc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ormris/srpnc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ormris/srpnc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ormris/srpnc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ormris/srpnc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a71f566d31ceebf9f0e6af90eb04ff91f003b3a5 [INFO] sha for GitHub repo ormris/srpnc: a71f566d31ceebf9f0e6af90eb04ff91f003b3a5 [INFO] validating manifest of ormris/srpnc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ormris/srpnc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ormris/srpnc [INFO] finished frobbing ormris/srpnc [INFO] frobbed toml for ormris/srpnc written to work/ex/clippy-test-run/sources/stable/gh/ormris/srpnc/Cargo.toml [INFO] started frobbing ormris/srpnc [INFO] finished frobbing ormris/srpnc [INFO] frobbed toml for ormris/srpnc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ormris/srpnc/Cargo.toml [INFO] crate ormris/srpnc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ormris/srpnc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ormris/srpnc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9997442fc0e8cb98d9dcd04d867b2b459728ee6197e82d4a9814fd8a336eb448 [INFO] running `"docker" "start" "-a" "9997442fc0e8cb98d9dcd04d867b2b459728ee6197e82d4a9814fd8a336eb448"` [INFO] [stderr] Checking srpnc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 160 | | if found { [INFO] [stderr] 161 | | parse(program, stack, macros, recurse + 1); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if found { [INFO] [stderr] 160 | parse(program, stack, macros, recurse + 1); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 160 | | if found { [INFO] [stderr] 161 | | parse(program, stack, macros, recurse + 1); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if found { [INFO] [stderr] 160 | parse(program, stack, macros, recurse + 1); [INFO] [stderr] 161 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | match it.next() { [INFO] [stderr] | _____^ [INFO] [stderr] 15 | | Some(val) => macro_name = String::from(val), [INFO] [stderr] 16 | | _ => { }, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(val) = it.next() { macro_name = String::from(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | match macro_name.pop() { [INFO] [stderr] | _____^ [INFO] [stderr] 20 | | Some(':') => { [INFO] [stderr] 21 | | let mut macro_body = String::new(); [INFO] [stderr] 22 | | for token in it { [INFO] [stderr] ... | [INFO] [stderr] 28 | | _ => { }, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(':') = macro_name.pop() { [INFO] [stderr] 20 | let mut macro_body = String::new(); [INFO] [stderr] 21 | for token in it { [INFO] [stderr] 22 | macro_body = macro_body + " " + token; [INFO] [stderr] 23 | } [INFO] [stderr] 24 | macros.insert(macro_name, macro_body); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | match token.parse::() { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | Ok(val) => { [INFO] [stderr] 34 | | stack.push(val); [INFO] [stderr] 35 | | continue; [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => { }, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(val) = token.parse::() { [INFO] [stderr] 33 | stack.push(val); [INFO] [stderr] 34 | continue; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | match token.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | match it.next() { [INFO] [stderr] | _____^ [INFO] [stderr] 15 | | Some(val) => macro_name = String::from(val), [INFO] [stderr] 16 | | _ => { }, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(val) = it.next() { macro_name = String::from(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | match macro_name.pop() { [INFO] [stderr] | _____^ [INFO] [stderr] 20 | | Some(':') => { [INFO] [stderr] 21 | | let mut macro_body = String::new(); [INFO] [stderr] 22 | | for token in it { [INFO] [stderr] ... | [INFO] [stderr] 28 | | _ => { }, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(':') = macro_name.pop() { [INFO] [stderr] 20 | let mut macro_body = String::new(); [INFO] [stderr] 21 | for token in it { [INFO] [stderr] 22 | macro_body = macro_body + " " + token; [INFO] [stderr] 23 | } [INFO] [stderr] 24 | macros.insert(macro_name, macro_body); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | match token.parse::() { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | Ok(val) => { [INFO] [stderr] 34 | | stack.push(val); [INFO] [stderr] 35 | | continue; [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => { }, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(val) = token.parse::() { [INFO] [stderr] 33 | stack.push(val); [INFO] [stderr] 34 | continue; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | match token.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "9997442fc0e8cb98d9dcd04d867b2b459728ee6197e82d4a9814fd8a336eb448"` [INFO] running `"docker" "rm" "-f" "9997442fc0e8cb98d9dcd04d867b2b459728ee6197e82d4a9814fd8a336eb448"` [INFO] [stdout] 9997442fc0e8cb98d9dcd04d867b2b459728ee6197e82d4a9814fd8a336eb448