[INFO] updating cached repository openriceworks/rust_grep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/openriceworks/rust_grep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/openriceworks/rust_grep" "work/ex/clippy-test-run/sources/stable/gh/openriceworks/rust_grep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/openriceworks/rust_grep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/openriceworks/rust_grep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/openriceworks/rust_grep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/openriceworks/rust_grep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 400dde6535de11c95f78930ad7d3e468e5ad35e0 [INFO] sha for GitHub repo openriceworks/rust_grep: 400dde6535de11c95f78930ad7d3e468e5ad35e0 [INFO] validating manifest of openriceworks/rust_grep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openriceworks/rust_grep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openriceworks/rust_grep [INFO] finished frobbing openriceworks/rust_grep [INFO] frobbed toml for openriceworks/rust_grep written to work/ex/clippy-test-run/sources/stable/gh/openriceworks/rust_grep/Cargo.toml [INFO] started frobbing openriceworks/rust_grep [INFO] finished frobbing openriceworks/rust_grep [INFO] frobbed toml for openriceworks/rust_grep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/openriceworks/rust_grep/Cargo.toml [INFO] crate openriceworks/rust_grep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openriceworks/rust_grep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/openriceworks/rust_grep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75f2d95c20310b0ab1f7f76a36a57077731fc743ac2aad95881f3b2ddda0d3c8 [INFO] running `"docker" "start" "-a" "75f2d95c20310b0ab1f7f76a36a57077731fc743ac2aad95881f3b2ddda0d3c8"` [INFO] [stderr] Checking getopts v0.2.18 [INFO] [stderr] Checking grep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return Some("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return Some("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / loop{ [INFO] [stderr] 22 | | match pattern_match(pattern,&mut input_buffer){ [INFO] [stderr] 23 | | Some(o) => print!("{}",o), [INFO] [stderr] 24 | | _ => break, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(o) = pattern_match(pattern,&mut input_buffer) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / loop{ [INFO] [stderr] 32 | | match pattern_match(pattern,&mut input_buffer){ [INFO] [stderr] 33 | | Some(o) => print!("{}",o), [INFO] [stderr] 34 | | _ => break, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(o) = pattern_match(pattern,&mut input_buffer) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | matches.free.get(1).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `matches.free.get(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / loop{ [INFO] [stderr] 22 | | match pattern_match(pattern,&mut input_buffer){ [INFO] [stderr] 23 | | Some(o) => print!("{}",o), [INFO] [stderr] 24 | | _ => break, [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(o) = pattern_match(pattern,&mut input_buffer) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / loop{ [INFO] [stderr] 32 | | match pattern_match(pattern,&mut input_buffer){ [INFO] [stderr] 33 | | Some(o) => print!("{}",o), [INFO] [stderr] 34 | | _ => break, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(o) = pattern_match(pattern,&mut input_buffer) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | matches.free.get(1).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `matches.free.get(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `"docker" "inspect" "75f2d95c20310b0ab1f7f76a36a57077731fc743ac2aad95881f3b2ddda0d3c8"` [INFO] running `"docker" "rm" "-f" "75f2d95c20310b0ab1f7f76a36a57077731fc743ac2aad95881f3b2ddda0d3c8"` [INFO] [stdout] 75f2d95c20310b0ab1f7f76a36a57077731fc743ac2aad95881f3b2ddda0d3c8