[INFO] updating cached repository ooooak/resolve-pkg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ooooak/resolve-pkg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ooooak/resolve-pkg" "work/ex/clippy-test-run/sources/stable/gh/ooooak/resolve-pkg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ooooak/resolve-pkg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ooooak/resolve-pkg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/resolve-pkg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/resolve-pkg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcb6c79335c09c2539bfb914903b95f5acd09b6d [INFO] sha for GitHub repo ooooak/resolve-pkg: bcb6c79335c09c2539bfb914903b95f5acd09b6d [INFO] validating manifest of ooooak/resolve-pkg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ooooak/resolve-pkg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ooooak/resolve-pkg [INFO] finished frobbing ooooak/resolve-pkg [INFO] frobbed toml for ooooak/resolve-pkg written to work/ex/clippy-test-run/sources/stable/gh/ooooak/resolve-pkg/Cargo.toml [INFO] started frobbing ooooak/resolve-pkg [INFO] finished frobbing ooooak/resolve-pkg [INFO] frobbed toml for ooooak/resolve-pkg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/resolve-pkg/Cargo.toml [INFO] crate ooooak/resolve-pkg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ooooak/resolve-pkg against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ooooak/resolve-pkg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e78e5a57eb069ba933f664796c131dd7c2a159f3e1cf7fa1bb69630e76af13a [INFO] running `"docker" "start" "-a" "3e78e5a57eb069ba933f664796c131dd7c2a159f3e1cf7fa1bb69630e76af13a"` [INFO] [stderr] Checking fiber-lang v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/cli.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | source:source, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/token.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/cli.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | source:source, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/token.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | str: str, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/deps.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn log_deps(tokens: &Vec){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[token::Identifiers]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/deps.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match item { [INFO] [stderr] 11 | | Identifiers::Import => { [INFO] [stderr] 12 | | let package_name = iter.next(); [INFO] [stderr] 13 | | match &package_name { [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Identifiers::Import = item { [INFO] [stderr] 11 | let package_name = iter.next(); [INFO] [stderr] 12 | match &package_name { [INFO] [stderr] 13 | Some(Identifiers::String(value)) => { [INFO] [stderr] 14 | println!("{:?}", value); [INFO] [stderr] 15 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/deps.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn log_deps(tokens: &Vec){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[token::Identifiers]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/deps.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match item { [INFO] [stderr] 11 | | Identifiers::Import => { [INFO] [stderr] 12 | | let package_name = iter.next(); [INFO] [stderr] 13 | | match &package_name { [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Identifiers::Import = item { [INFO] [stderr] 11 | let package_name = iter.next(); [INFO] [stderr] 12 | match &package_name { [INFO] [stderr] 13 | Some(Identifiers::String(value)) => { [INFO] [stderr] 14 | println!("{:?}", value); [INFO] [stderr] 15 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "3e78e5a57eb069ba933f664796c131dd7c2a159f3e1cf7fa1bb69630e76af13a"` [INFO] running `"docker" "rm" "-f" "3e78e5a57eb069ba933f664796c131dd7c2a159f3e1cf7fa1bb69630e76af13a"` [INFO] [stdout] 3e78e5a57eb069ba933f664796c131dd7c2a159f3e1cf7fa1bb69630e76af13a